You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joris Van Remoortere <jo...@gmail.com> on 2015/07/26 21:02:29 UTC

Review Request 36822: Used std::thread instead of pthread for Long Lived Executor.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36822/
-----------------------------------------------------------

Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Michael Park.


Bugs: MESOS-3120
    https://issues.apache.org/jira/browse/MESOS-3120


Repository: mesos


Description
-------

See summary.


Diffs
-----

  src/examples/long_lived_executor.cpp d9b7fa1eefd1c53447244586797cb96a5c33d4f1 

Diff: https://reviews.apache.org/r/36822/diff/


Testing
-------

make check


Thanks,

Joris Van Remoortere


Re: Review Request 36822: Used std::thread instead of pthread for Long Lived Executor.

Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36822/#review93161
-----------------------------------------------------------



src/examples/long_lived_executor.cpp (lines 79 - 80)
<https://reviews.apache.org/r/36822/#comment147430>

    Why not just capture 'driver' and 'task' and make the lambda we're using in the std::thread constructor be 'run(driver, task);'?


- Benjamin Hindman


On July 26, 2015, 7:02 p.m., Joris Van Remoortere wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36822/
> -----------------------------------------------------------
> 
> (Updated July 26, 2015, 7:02 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Michael Park.
> 
> 
> Bugs: MESOS-3120
>     https://issues.apache.org/jira/browse/MESOS-3120
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/examples/long_lived_executor.cpp d9b7fa1eefd1c53447244586797cb96a5c33d4f1 
> 
> Diff: https://reviews.apache.org/r/36822/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>


Re: Review Request 36822: Used std::thread instead of pthread for Long Lived Executor.

Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36822/#review93522
-----------------------------------------------------------

Ship it!


Ship It!

- Benjamin Hindman


On July 27, 2015, 8:18 p.m., Joris Van Remoortere wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36822/
> -----------------------------------------------------------
> 
> (Updated July 27, 2015, 8:18 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Michael Park.
> 
> 
> Bugs: MESOS-3120
>     https://issues.apache.org/jira/browse/MESOS-3120
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/examples/long_lived_executor.cpp d9b7fa1eefd1c53447244586797cb96a5c33d4f1 
> 
> Diff: https://reviews.apache.org/r/36822/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>


Re: Review Request 36822: Used std::thread instead of pthread for Long Lived Executor.

Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36822/
-----------------------------------------------------------

(Updated July 27, 2015, 8:18 p.m.)


Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Michael Park.


Changes
-------

Minor refactor.


Bugs: MESOS-3120
    https://issues.apache.org/jira/browse/MESOS-3120


Repository: mesos


Description
-------

See summary.


Diffs (updated)
-----

  src/examples/long_lived_executor.cpp d9b7fa1eefd1c53447244586797cb96a5c33d4f1 

Diff: https://reviews.apache.org/r/36822/diff/


Testing
-------

make check


Thanks,

Joris Van Remoortere