You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/11/14 20:02:28 UTC
[GitHub] [incubator-superset] suddjian commented on a change in pull request
#8562: showing version and SHA (subtly) in user menu.
suddjian commented on a change in pull request #8562: showing version and SHA (subtly) in user menu.
URL: https://github.com/apache/incubator-superset/pull/8562#discussion_r346519510
##########
File path: superset/assets/stylesheets/superset.less
##########
@@ -139,6 +139,14 @@ span.title-block {
}
div.navbar {
z-index: 999;
+ .dropdown-menu .fineprint{
+ padding: 10px 20px 0 20px;
Review comment:
Seconded on preferring the verbose version. Three-parameter padding/margin always confuse me and I have to look it up.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org