You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/09/01 04:54:54 UTC

[GitHub] [spark] HyukjinKwon opened a new pull request #29606: [SPARK-32191][FOLLOW-UP][PYTHON][DOCS] Indent the table and reword the main page in migration guide

HyukjinKwon opened a new pull request #29606:
URL: https://github.com/apache/spark/pull/29606


   ### What changes were proposed in this pull request?
   
   This PR is a minor followup to fix:
   
   1. Slightly reword the wording in the main page.
   
   2. The indentation in the table at the migration guide;
   
       from
     
       ![Screen Shot 2020-09-01 at 1 53 40 PM](https://user-images.githubusercontent.com/6477701/91796204-91781800-ec5a-11ea-9f57-d7a9f4207ba0.png)
   
       to
   
       ![Screen Shot 2020-09-01 at 1 53 26 PM](https://user-images.githubusercontent.com/6477701/91796202-9046eb00-ec5a-11ea-9db2-815139ddfdb9.png)
   
   
   ### Why are the changes needed?
   
   In order to show the migration guide pretty.
   
   ### Does this PR introduce _any_ user-facing change?
   
   Yes, this is a change to user-facing documentation.
   
   ### How was this patch tested?
   
   Manually built the documentation.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #29606: [SPARK-32191][FOLLOW-UP][PYTHON][DOCS] Indent the table and reword the main page in migration guide

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29606:
URL: https://github.com/apache/spark/pull/29606#issuecomment-684253813






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #29606: [SPARK-32191][FOLLOW-UP][PYTHON][DOCS] Indent the table and reword the main page in migration guide

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29606:
URL: https://github.com/apache/spark/pull/29606#issuecomment-684241267






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon commented on pull request #29606: [SPARK-32191][FOLLOW-UP][PYTHON][DOCS] Indent the table and reword the main page in migration guide

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #29606:
URL: https://github.com/apache/spark/pull/29606#issuecomment-684407990


   Merged to master.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #29606: [SPARK-32191][FOLLOW-UP][PYTHON][DOCS] Indent the table and reword the main page in migration guide

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29606:
URL: https://github.com/apache/spark/pull/29606#issuecomment-684251336


   **[Test build #128131 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128131/testReport)** for PR 29606 at commit [`4dbae46`](https://github.com/apache/spark/commit/4dbae46726cc4df09a2aebe4a149c62b2d06758a).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] viirya commented on a change in pull request #29606: [SPARK-32191][FOLLOW-UP][PYTHON][DOCS] Indent the table and reword the main page in migration guide

Posted by GitBox <gi...@apache.org>.
viirya commented on a change in pull request #29606:
URL: https://github.com/apache/spark/pull/29606#discussion_r480808908



##########
File path: python/docs/source/migration_guide/index.rst
##########
@@ -20,11 +20,9 @@
 Migration Guide
 ===============
 
-Migration Guide: PySpark (Python on Spark)
-
-Note that this migration guide describes the items specific to PySpark.
-Many items of SQL migration can be applied when migrating PySpark to higher versions.
-Please refer `Migration Guide: SQL, Datasets and DataFrame <http://spark.apache.org/docs/latest/sql-migration-guide.html>`_.
+This page describes the migration guide specific to PySpark.
+Many items of other migration guides can be applied when migrating PySpark to higher versions because PySpark internally shares other components.

Review comment:
       nit: ... can also be applied ...




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29606: [SPARK-32191][FOLLOW-UP][PYTHON][DOCS] Indent the table and reword the main page in migration guide

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29606:
URL: https://github.com/apache/spark/pull/29606#issuecomment-684313135






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29606: [SPARK-32191][FOLLOW-UP][PYTHON][DOCS] Indent the table and reword the main page in migration guide

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29606:
URL: https://github.com/apache/spark/pull/29606#issuecomment-684241267






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #29606: [SPARK-32191][FOLLOW-UP][PYTHON][DOCS] Indent the table and reword the main page in migration guide

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29606:
URL: https://github.com/apache/spark/pull/29606#issuecomment-684313135






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on pull request #29606: [SPARK-32191][FOLLOW-UP][PYTHON][DOCS] Indent the table and reword the main page in migration guide

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29606:
URL: https://github.com/apache/spark/pull/29606#issuecomment-684251336


   **[Test build #128131 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128131/testReport)** for PR 29606 at commit [`4dbae46`](https://github.com/apache/spark/commit/4dbae46726cc4df09a2aebe4a149c62b2d06758a).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #29606: [SPARK-32191][FOLLOW-UP][PYTHON][DOCS] Indent the table and reword the main page in migration guide

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29606:
URL: https://github.com/apache/spark/pull/29606#issuecomment-684310589


   **[Test build #128131 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128131/testReport)** for PR 29606 at commit [`4dbae46`](https://github.com/apache/spark/commit/4dbae46726cc4df09a2aebe4a149c62b2d06758a).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29606: [SPARK-32191][FOLLOW-UP][PYTHON][DOCS] Indent the table and reword the main page in migration guide

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29606:
URL: https://github.com/apache/spark/pull/29606#issuecomment-684253813






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon closed pull request #29606: [SPARK-32191][FOLLOW-UP][PYTHON][DOCS] Indent the table and reword the main page in migration guide

Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #29606:
URL: https://github.com/apache/spark/pull/29606


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon commented on pull request #29606: [SPARK-32191][FOLLOW-UP][PYTHON][DOCS] Indent the table and reword the main page in migration guide

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #29606:
URL: https://github.com/apache/spark/pull/29606#issuecomment-684240166


   cc @viirya, can you take a quick look when you're available? 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org