You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Greg Mann <gr...@mesosphere.io> on 2017/04/04 14:15:53 UTC

Review Request 58175: Fixed an iterator bug in 'CombinedAuthenticator::authenticate()'.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58175/
-----------------------------------------------------------

Review request for mesos, Anand Mazumdar, Michael Park, and Vinod Kone.


Repository: mesos


Description
-------

This patch updates the `loop()` logic within
`CombinedAuthenticatorProcess::authenticate()` to fix a bug
in which an iterator is incremented past the end of its vector.


Diffs
-----

  src/authentication/http/combined_authenticator.cpp c734e7672e96087fa715501cfc594a0165f5bce7 


Diff: https://reviews.apache.org/r/58175/diff/1/


Testing
-------

`make && bin/mesos-tests.sh --gtest_filter="CombinedAuthenticatorTest.MultipleAuthenticators"`


Thanks,

Greg Mann

Re: Review Request 58175: Fixed an iterator bug in 'CombinedAuthenticator::authenticate()'.

Posted by Anand Mazumdar <an...@apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58175/#review170993
-----------------------------------------------------------


Ship it!




Ship It!

- Anand Mazumdar


On April 4, 2017, 2:15 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58175/
> -----------------------------------------------------------
> 
> (Updated April 4, 2017, 2:15 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Michael Park, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch updates the `loop()` logic within
> `CombinedAuthenticatorProcess::authenticate()` to fix a bug
> in which an iterator is incremented past the end of its vector.
> 
> 
> Diffs
> -----
> 
>   src/authentication/http/combined_authenticator.cpp c734e7672e96087fa715501cfc594a0165f5bce7 
> 
> 
> Diff: https://reviews.apache.org/r/58175/diff/1/
> 
> 
> Testing
> -------
> 
> `make && bin/mesos-tests.sh --gtest_filter="CombinedAuthenticatorTest.MultipleAuthenticators"`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 58175: Fixed an iterator bug in 'CombinedAuthenticator::authenticate()'.

Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.


> On April 4, 2017, 5:42 p.m., Andrew Schwartzmeyer wrote:
> > Ship It!

This patch fixes the `CombinedAuthenticatorTest.MultipleAuthenticators` test failure that otherwise reproduces on Windows 10 with the VS 2017 tools.


- Andrew


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58175/#review170995
-----------------------------------------------------------


On April 4, 2017, 2:15 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58175/
> -----------------------------------------------------------
> 
> (Updated April 4, 2017, 2:15 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Michael Park, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch updates the `loop()` logic within
> `CombinedAuthenticatorProcess::authenticate()` to fix a bug
> in which an iterator is incremented past the end of its vector.
> 
> 
> Diffs
> -----
> 
>   src/authentication/http/combined_authenticator.cpp c734e7672e96087fa715501cfc594a0165f5bce7 
> 
> 
> Diff: https://reviews.apache.org/r/58175/diff/1/
> 
> 
> Testing
> -------
> 
> `make && bin/mesos-tests.sh --gtest_filter="CombinedAuthenticatorTest.MultipleAuthenticators"`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 58175: Fixed an iterator bug in 'CombinedAuthenticator::authenticate()'.

Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58175/#review170995
-----------------------------------------------------------


Ship it!




Ship It!

- Andrew Schwartzmeyer


On April 4, 2017, 2:15 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58175/
> -----------------------------------------------------------
> 
> (Updated April 4, 2017, 2:15 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Michael Park, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch updates the `loop()` logic within
> `CombinedAuthenticatorProcess::authenticate()` to fix a bug
> in which an iterator is incremented past the end of its vector.
> 
> 
> Diffs
> -----
> 
>   src/authentication/http/combined_authenticator.cpp c734e7672e96087fa715501cfc594a0165f5bce7 
> 
> 
> Diff: https://reviews.apache.org/r/58175/diff/1/
> 
> 
> Testing
> -------
> 
> `make && bin/mesos-tests.sh --gtest_filter="CombinedAuthenticatorTest.MultipleAuthenticators"`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 58175: Fixed an iterator bug in 'CombinedAuthenticator::authenticate()'.

Posted by Mesos Reviewbot <re...@mesos.apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58175/#review171006
-----------------------------------------------------------



Patch looks great!

Reviews applied: [58174, 58175]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On April 4, 2017, 2:15 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58175/
> -----------------------------------------------------------
> 
> (Updated April 4, 2017, 2:15 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Michael Park, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch updates the `loop()` logic within
> `CombinedAuthenticatorProcess::authenticate()` to fix a bug
> in which an iterator is incremented past the end of its vector.
> 
> 
> Diffs
> -----
> 
>   src/authentication/http/combined_authenticator.cpp c734e7672e96087fa715501cfc594a0165f5bce7 
> 
> 
> Diff: https://reviews.apache.org/r/58175/diff/1/
> 
> 
> Testing
> -------
> 
> `make && bin/mesos-tests.sh --gtest_filter="CombinedAuthenticatorTest.MultipleAuthenticators"`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>