You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/04/05 09:30:27 UTC
[GitHub] [skywalking-docker] kezhenxu94 opened a new pull request #17: Add Java agent Dockerfile and build / push script
kezhenxu94 opened a new pull request #17:
URL: https://github.com/apache/skywalking-docker/pull/17
related to https://github.com/apache/skywalking/issues/6029
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-docker] kezhenxu94 commented on a change in pull request #17: Add Java agent Dockerfile and build / push script
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #17:
URL: https://github.com/apache/skywalking-docker/pull/17#discussion_r610635423
##########
File path: java-agent/README.md
##########
@@ -0,0 +1,69 @@
+# Apache SkyWalking Agent docker file
+
+**Docker images are not official ASF releases but provided for convenience. Recommended usage is always to build the
+source**
+
+<img src="http://skywalking.apache.org/assets/logo.svg" alt="Sky Walking logo" height="90px" align="right" />
+
+**SkyWalking**: an APM(application performance monitor) system, especially designed for microservices, cloud native and
+container-based (Docker, Kubernetes, Mesos) architectures.
+
+[](https://github.com/apache/skywalking)
+[](https://twitter.com/AsfSkyWalking)
+
+You could find docker file at [here](https://github.com/apache/skywalking-docker)
+
+This image only hosts the pre-built SkyWalking Java agent jars, and provides some convenient configurations for
+containerization scenarios.
+
+# How to use this image
+
+## Build your Java application image on top of this image
+
+```dockerfile
+FROM apache/skywalking-java-agent:8.5.0-jdk8
+
+# ... build your java application
+```
+
+You can start your Java application with `CMD` or `ENTRYPOINT`, but you don't need to care about the Java options to
+enable SkyWalking agent, it should be adopted automatically.
+
+## Use this image as sidecar of Kubernetes service
+
+In Kubernetes scenarios, you can also use this agent image as a sidecar.
Review comment:
The example below is not the ultimate goal, the ultimate goal would be https://github.com/apache/skywalking/issues/6029 , auto injection of sidecar
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-docker] hanahmily commented on a change in pull request #17: Add Java agent Dockerfile and build / push script
Posted by GitBox <gi...@apache.org>.
hanahmily commented on a change in pull request #17:
URL: https://github.com/apache/skywalking-docker/pull/17#discussion_r607416322
##########
File path: java-agent/README.md
##########
@@ -0,0 +1,27 @@
+# Apache SkyWalking Agent docker file
+
+**Docker images are not official ASF releases but provided for convenience. Recommended usage is always to build the source**
+
+<img src="http://skywalking.apache.org/assets/logo.svg" alt="Sky Walking logo" height="90px" align="right" />
+
+**SkyWalking**: an APM(application performance monitor) system, especially designed for
+microservices, cloud native and container-based (Docker, Kubernetes, Mesos) architectures.
+
+[](https://github.com/apache/skywalking)
+[](https://twitter.com/AsfSkyWalking)
+
+You could find docker file at [here](https://github.com/apache/skywalking-docker)
+
+This image only hosts the pre-built SkyWalking Java agent jars, and provides some convenient configurations for containerization scenarios.
+
+# How to use this image
Review comment:
Could you add an example to show kubernetes[ shared volume usage](https://kubernetes.io/docs/tasks/access-application-cluster/communicate-containers-same-pod-shared-volume/)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-docker] hanahmily commented on a change in pull request #17: Add Java agent Dockerfile and build / push script
Posted by GitBox <gi...@apache.org>.
hanahmily commented on a change in pull request #17:
URL: https://github.com/apache/skywalking-docker/pull/17#discussion_r607415892
##########
File path: java-agent/Dockerfile
##########
@@ -0,0 +1,38 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+ARG BASE_IMAGE='adoptopenjdk/openjdk8:alpine'
Review comment:
Same as https://github.com/apache/skywalking/pull/6686/files#r607415421
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-docker] wu-sheng commented on a change in pull request #17: Add Java agent Dockerfile and build / push script
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #17:
URL: https://github.com/apache/skywalking-docker/pull/17#discussion_r610970647
##########
File path: java-agent/README.md
##########
@@ -0,0 +1,69 @@
+# Apache SkyWalking Agent docker file
+
+**Docker images are not official ASF releases but provided for convenience. Recommended usage is always to build the
+source**
+
+<img src="http://skywalking.apache.org/assets/logo.svg" alt="Sky Walking logo" height="90px" align="right" />
+
+**SkyWalking**: an APM(application performance monitor) system, especially designed for microservices, cloud native and
+container-based (Docker, Kubernetes, Mesos) architectures.
+
+[](https://github.com/apache/skywalking)
+[](https://twitter.com/AsfSkyWalking)
+
+You could find docker file at [here](https://github.com/apache/skywalking-docker)
+
+This image only hosts the pre-built SkyWalking Java agent jars, and provides some convenient configurations for
+containerization scenarios.
+
+# How to use this image
+
+## Build your Java application image on top of this image
+
+```dockerfile
+FROM apache/skywalking-java-agent:8.5.0-jdk8
+
+# ... build your java application
+```
+
+You can start your Java application with `CMD` or `ENTRYPOINT`, but you don't need to care about the Java options to
+enable SkyWalking agent, it should be adopted automatically.
+
+## Use this image as sidecar of Kubernetes service
+
+In Kubernetes scenarios, you can also use this agent image as a sidecar.
Review comment:
Why a system env could make users don't need to modify? Could do be more clear?
They still to change like, don't they?
> java $JAVA_TOOL_OPTIONS xxx.jar
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-docker] kezhenxu94 commented on a change in pull request #17: Add Java agent Dockerfile and build / push script
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #17:
URL: https://github.com/apache/skywalking-docker/pull/17#discussion_r610634318
##########
File path: java-agent/README.md
##########
@@ -0,0 +1,27 @@
+# Apache SkyWalking Agent docker file
+
+**Docker images are not official ASF releases but provided for convenience. Recommended usage is always to build the source**
+
+<img src="http://skywalking.apache.org/assets/logo.svg" alt="Sky Walking logo" height="90px" align="right" />
+
+**SkyWalking**: an APM(application performance monitor) system, especially designed for
+microservices, cloud native and container-based (Docker, Kubernetes, Mesos) architectures.
+
+[](https://github.com/apache/skywalking)
+[](https://twitter.com/AsfSkyWalking)
+
+You could find docker file at [here](https://github.com/apache/skywalking-docker)
+
+This image only hosts the pre-built SkyWalking Java agent jars, and provides some convenient configurations for containerization scenarios.
+
+# How to use this image
Review comment:
Added
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-docker] wu-sheng commented on a change in pull request #17: Add Java agent Dockerfile and build / push script
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #17:
URL: https://github.com/apache/skywalking-docker/pull/17#discussion_r610644627
##########
File path: java-agent/README.md
##########
@@ -0,0 +1,69 @@
+# Apache SkyWalking Agent docker file
+
+**Docker images are not official ASF releases but provided for convenience. Recommended usage is always to build the
+source**
+
+<img src="http://skywalking.apache.org/assets/logo.svg" alt="Sky Walking logo" height="90px" align="right" />
+
+**SkyWalking**: an APM(application performance monitor) system, especially designed for microservices, cloud native and
+container-based (Docker, Kubernetes, Mesos) architectures.
+
+[](https://github.com/apache/skywalking)
+[](https://twitter.com/AsfSkyWalking)
+
+You could find docker file at [here](https://github.com/apache/skywalking-docker)
+
+This image only hosts the pre-built SkyWalking Java agent jars, and provides some convenient configurations for
+containerization scenarios.
+
+# How to use this image
+
+## Build your Java application image on top of this image
+
+```dockerfile
+FROM apache/skywalking-java-agent:8.5.0-jdk8
+
+# ... build your java application
+```
+
+You can start your Java application with `CMD` or `ENTRYPOINT`, but you don't need to care about the Java options to
+enable SkyWalking agent, it should be adopted automatically.
+
+## Use this image as sidecar of Kubernetes service
+
+In Kubernetes scenarios, you can also use this agent image as a sidecar.
Review comment:
When he does this, please document what user should do on his application. Such as how to write `-javaagent:xxx`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-docker] kezhenxu94 commented on a change in pull request #17: Add Java agent Dockerfile and build / push script
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #17:
URL: https://github.com/apache/skywalking-docker/pull/17#discussion_r610929416
##########
File path: java-agent/README.md
##########
@@ -0,0 +1,69 @@
+# Apache SkyWalking Agent docker file
+
+**Docker images are not official ASF releases but provided for convenience. Recommended usage is always to build the
+source**
+
+<img src="http://skywalking.apache.org/assets/logo.svg" alt="Sky Walking logo" height="90px" align="right" />
+
+**SkyWalking**: an APM(application performance monitor) system, especially designed for microservices, cloud native and
+container-based (Docker, Kubernetes, Mesos) architectures.
+
+[](https://github.com/apache/skywalking)
+[](https://twitter.com/AsfSkyWalking)
+
+You could find docker file at [here](https://github.com/apache/skywalking-docker)
+
+This image only hosts the pre-built SkyWalking Java agent jars, and provides some convenient configurations for
+containerization scenarios.
+
+# How to use this image
+
+## Build your Java application image on top of this image
+
+```dockerfile
+FROM apache/skywalking-java-agent:8.5.0-jdk8
+
+# ... build your java application
+```
+
+You can start your Java application with `CMD` or `ENTRYPOINT`, but you don't need to care about the Java options to
+enable SkyWalking agent, it should be adopted automatically.
+
+## Use this image as sidecar of Kubernetes service
+
+In Kubernetes scenarios, you can also use this agent image as a sidecar.
Review comment:
Take a look at https://github.com/apache/skywalking-docker/blob/74be4f870334af2cf0707c755240d54842e08195/java-agent/Dockerfile#L27 , and I believe our operator is able to set this env var after injecting the agent, no?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-docker] kezhenxu94 commented on a change in pull request #17: Add Java agent Dockerfile and build / push script
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #17:
URL: https://github.com/apache/skywalking-docker/pull/17#discussion_r610652113
##########
File path: java-agent/README.md
##########
@@ -0,0 +1,69 @@
+# Apache SkyWalking Agent docker file
+
+**Docker images are not official ASF releases but provided for convenience. Recommended usage is always to build the
+source**
+
+<img src="http://skywalking.apache.org/assets/logo.svg" alt="Sky Walking logo" height="90px" align="right" />
+
+**SkyWalking**: an APM(application performance monitor) system, especially designed for microservices, cloud native and
+container-based (Docker, Kubernetes, Mesos) architectures.
+
+[](https://github.com/apache/skywalking)
+[](https://twitter.com/AsfSkyWalking)
+
+You could find docker file at [here](https://github.com/apache/skywalking-docker)
+
+This image only hosts the pre-built SkyWalking Java agent jars, and provides some convenient configurations for
+containerization scenarios.
+
+# How to use this image
+
+## Build your Java application image on top of this image
+
+```dockerfile
+FROM apache/skywalking-java-agent:8.5.0-jdk8
+
+# ... build your java application
+```
+
+You can start your Java application with `CMD` or `ENTRYPOINT`, but you don't need to care about the Java options to
+enable SkyWalking agent, it should be adopted automatically.
+
+## Use this image as sidecar of Kubernetes service
+
+In Kubernetes scenarios, you can also use this agent image as a sidecar.
Review comment:
> When he does this, please document what user should do on his application. Such as how to write `-javaagent:xxx`
If the auto injection is done in SWCK, I think there is nothing for the users to do except for labeling the namespace such as `skywalking-agent-injection=true`, all the remaining operations are done via the SWCK operator @hanahmily right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-docker] kezhenxu94 commented on a change in pull request #17: Add Java agent Dockerfile and build / push script
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #17:
URL: https://github.com/apache/skywalking-docker/pull/17#discussion_r610973023
##########
File path: java-agent/README.md
##########
@@ -0,0 +1,69 @@
+# Apache SkyWalking Agent docker file
+
+**Docker images are not official ASF releases but provided for convenience. Recommended usage is always to build the
+source**
+
+<img src="http://skywalking.apache.org/assets/logo.svg" alt="Sky Walking logo" height="90px" align="right" />
+
+**SkyWalking**: an APM(application performance monitor) system, especially designed for microservices, cloud native and
+container-based (Docker, Kubernetes, Mesos) architectures.
+
+[](https://github.com/apache/skywalking)
+[](https://twitter.com/AsfSkyWalking)
+
+You could find docker file at [here](https://github.com/apache/skywalking-docker)
+
+This image only hosts the pre-built SkyWalking Java agent jars, and provides some convenient configurations for
+containerization scenarios.
+
+# How to use this image
+
+## Build your Java application image on top of this image
+
+```dockerfile
+FROM apache/skywalking-java-agent:8.5.0-jdk8
+
+# ... build your java application
+```
+
+You can start your Java application with `CMD` or `ENTRYPOINT`, but you don't need to care about the Java options to
+enable SkyWalking agent, it should be adopted automatically.
+
+## Use this image as sidecar of Kubernetes service
+
+In Kubernetes scenarios, you can also use this agent image as a sidecar.
Review comment:
> Why a system env could make users don't need to modify? Could do be more clear?
>
> They still to change like, don't they?
>
> > java $JAVA_TOOL_OPTIONS xxx.jar
No, JAVA_TOOL_OPTIONS is automatically adopted by JVM, this is the typical use of this option IMO. Check [this](https://docs.oracle.com/javase/8/docs/technotes/guides/troubleshoot/envvars002.html)
> In many environments the command line is not readily accessible to start the application with necessary command-line options. This often arises with applications that use embedded VMs (meaning they use the Java Native Interface (JNI) Invocation API to start the VM), or where the startup is deeply nested in scripts. In these environments the JAVA_TOOL_OPTIONS environment variable can be useful to augment a command line.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-docker] kezhenxu94 commented on a change in pull request #17: Add Java agent Dockerfile and build / push script
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #17:
URL: https://github.com/apache/skywalking-docker/pull/17#discussion_r610635423
##########
File path: java-agent/README.md
##########
@@ -0,0 +1,69 @@
+# Apache SkyWalking Agent docker file
+
+**Docker images are not official ASF releases but provided for convenience. Recommended usage is always to build the
+source**
+
+<img src="http://skywalking.apache.org/assets/logo.svg" alt="Sky Walking logo" height="90px" align="right" />
+
+**SkyWalking**: an APM(application performance monitor) system, especially designed for microservices, cloud native and
+container-based (Docker, Kubernetes, Mesos) architectures.
+
+[](https://github.com/apache/skywalking)
+[](https://twitter.com/AsfSkyWalking)
+
+You could find docker file at [here](https://github.com/apache/skywalking-docker)
+
+This image only hosts the pre-built SkyWalking Java agent jars, and provides some convenient configurations for
+containerization scenarios.
+
+# How to use this image
+
+## Build your Java application image on top of this image
+
+```dockerfile
+FROM apache/skywalking-java-agent:8.5.0-jdk8
+
+# ... build your java application
+```
+
+You can start your Java application with `CMD` or `ENTRYPOINT`, but you don't need to care about the Java options to
+enable SkyWalking agent, it should be adopted automatically.
+
+## Use this image as sidecar of Kubernetes service
+
+In Kubernetes scenarios, you can also use this agent image as a sidecar.
Review comment:
This is not the ultimate goal, the ultimate goal would be https://github.com/apache/skywalking/issues/6029 , auto injection of sidecar
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-docker] kezhenxu94 commented on a change in pull request #17: Add Java agent Dockerfile and build / push script
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #17:
URL: https://github.com/apache/skywalking-docker/pull/17#discussion_r610929416
##########
File path: java-agent/README.md
##########
@@ -0,0 +1,69 @@
+# Apache SkyWalking Agent docker file
+
+**Docker images are not official ASF releases but provided for convenience. Recommended usage is always to build the
+source**
+
+<img src="http://skywalking.apache.org/assets/logo.svg" alt="Sky Walking logo" height="90px" align="right" />
+
+**SkyWalking**: an APM(application performance monitor) system, especially designed for microservices, cloud native and
+container-based (Docker, Kubernetes, Mesos) architectures.
+
+[](https://github.com/apache/skywalking)
+[](https://twitter.com/AsfSkyWalking)
+
+You could find docker file at [here](https://github.com/apache/skywalking-docker)
+
+This image only hosts the pre-built SkyWalking Java agent jars, and provides some convenient configurations for
+containerization scenarios.
+
+# How to use this image
+
+## Build your Java application image on top of this image
+
+```dockerfile
+FROM apache/skywalking-java-agent:8.5.0-jdk8
+
+# ... build your java application
+```
+
+You can start your Java application with `CMD` or `ENTRYPOINT`, but you don't need to care about the Java options to
+enable SkyWalking agent, it should be adopted automatically.
+
+## Use this image as sidecar of Kubernetes service
+
+In Kubernetes scenarios, you can also use this agent image as a sidecar.
Review comment:
Take a look at https://github.com/apache/skywalking-docker/blob/74be4f870334af2cf0707c755240d54842e08195/java-agent/Dockerfile#L27 , which makes the users don’t need to modify their start script, and I believe our operator is able to set this env var after injecting the agent, no?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-docker] wu-sheng commented on a change in pull request #17: Add Java agent Dockerfile and build / push script
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #17:
URL: https://github.com/apache/skywalking-docker/pull/17#discussion_r610737194
##########
File path: java-agent/README.md
##########
@@ -0,0 +1,69 @@
+# Apache SkyWalking Agent docker file
+
+**Docker images are not official ASF releases but provided for convenience. Recommended usage is always to build the
+source**
+
+<img src="http://skywalking.apache.org/assets/logo.svg" alt="Sky Walking logo" height="90px" align="right" />
+
+**SkyWalking**: an APM(application performance monitor) system, especially designed for microservices, cloud native and
+container-based (Docker, Kubernetes, Mesos) architectures.
+
+[](https://github.com/apache/skywalking)
+[](https://twitter.com/AsfSkyWalking)
+
+You could find docker file at [here](https://github.com/apache/skywalking-docker)
+
+This image only hosts the pre-built SkyWalking Java agent jars, and provides some convenient configurations for
+containerization scenarios.
+
+# How to use this image
+
+## Build your Java application image on top of this image
+
+```dockerfile
+FROM apache/skywalking-java-agent:8.5.0-jdk8
+
+# ... build your java application
+```
+
+You can start your Java application with `CMD` or `ENTRYPOINT`, but you don't need to care about the Java options to
+enable SkyWalking agent, it should be adopted automatically.
+
+## Use this image as sidecar of Kubernetes service
+
+In Kubernetes scenarios, you can also use this agent image as a sidecar.
Review comment:
I don't think SWCK will affect how user set their Java booting script. Do I miss anything?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-docker] wu-sheng merged pull request #17: Add Java agent Dockerfile and build / push script
Posted by GitBox <gi...@apache.org>.
wu-sheng merged pull request #17:
URL: https://github.com/apache/skywalking-docker/pull/17
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org