You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by "wido (via GitHub)" <gi...@apache.org> on 2023/05/31 09:42:10 UTC
[GitHub] [cloudstack-documentation] wido opened a new pull request, #320: docs: Update instructions for adding DEB repository
wido opened a new pull request, #320:
URL: https://github.com/apache/cloudstack-documentation/pull/320
apt-key and apt-get are deprecated. This PR makes use of the proper commands
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-documentation] rohityadavcloud commented on a diff in pull request #320: docs: Update instructions for adding DEB repository
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud commented on code in PR #320:
URL: https://github.com/apache/cloudstack-documentation/pull/320#discussion_r1211427547
##########
source/installguide/management-server/_pkg_repo.rst:
##########
@@ -99,19 +99,19 @@ repository to the file (replace "trusty" with "xenial" or "bionic" if it is the
.. parsed-literal::
- deb http://download.cloudstack.org/ubuntu focal |version|
+ deb https://download.cloudstack.org/ubuntu focal |version|
We now have to add the public key to the trusted keys.
.. parsed-literal::
- wget -O - http://download.cloudstack.org/release.asc |sudo apt-key add -
+ wget -O - https://download.cloudstack.org/release.asc |sudo tee /etc/apt/trusted.gpg.d/cloudstack.asc
Review Comment:
Should this be, something like:
```
mkdir -p /etc/apt/keyrings
wget -O- https://download.cloudstack.org/release.asc | gpg --dearmor | sudo tee /etc/apt/keyrings/cloudstack.gpg > /dev/null
```
And for use for the repo, the usage is like or something similar:
```
echo deb [signed-by=/etc/apt/keyrings/cloudstack.gpg] https://download.cloudstack.org/<path to repo here> / > /etc/apt/sources.list.d/cloudstack.list
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-documentation] DaanHoogland commented on a diff in pull request #320: docs: Update instructions for adding DEB repository
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on code in PR #320:
URL: https://github.com/apache/cloudstack-documentation/pull/320#discussion_r1211437350
##########
source/installguide/management-server/_pkg_repo.rst:
##########
@@ -99,19 +99,19 @@ repository to the file (replace "trusty" with "xenial" or "bionic" if it is the
.. parsed-literal::
- deb http://download.cloudstack.org/ubuntu focal |version|
+ deb https://download.cloudstack.org/ubuntu focal |version|
We now have to add the public key to the trusted keys.
.. parsed-literal::
- wget -O - http://download.cloudstack.org/release.asc |sudo apt-key add -
Review Comment:
I suppose you tested this doesn't screw up the FDs for input and output (and maybe error) when it asks for pw, or screws up the file rights on `cloudstack.asc`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-documentation] weizhouapache merged pull request #320: docs: Update instructions for adding DEB repository
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache merged PR #320:
URL: https://github.com/apache/cloudstack-documentation/pull/320
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-documentation] wido commented on a diff in pull request #320: docs: Update instructions for adding DEB repository
Posted by "wido (via GitHub)" <gi...@apache.org>.
wido commented on code in PR #320:
URL: https://github.com/apache/cloudstack-documentation/pull/320#discussion_r1212874913
##########
source/installguide/management-server/_pkg_repo.rst:
##########
@@ -99,19 +99,19 @@ repository to the file (replace "trusty" with "xenial" or "bionic" if it is the
.. parsed-literal::
- deb http://download.cloudstack.org/ubuntu focal |version|
+ deb https://download.cloudstack.org/ubuntu focal |version|
We now have to add the public key to the trusted keys.
.. parsed-literal::
- wget -O - http://download.cloudstack.org/release.asc |sudo apt-key add -
+ wget -O - https://download.cloudstack.org/release.asc |sudo tee /etc/apt/trusted.gpg.d/cloudstack.asc
Review Comment:
Would that really be needed that way? I have tested the commands and worked on my environment.
Happy to change it though
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-documentation] DaanHoogland commented on pull request #320: docs: Update instructions for adding DEB repository
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #320:
URL: https://github.com/apache/cloudstack-documentation/pull/320#issuecomment-1580284970
one more thing @wido do we need this on the 4.18 branch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-documentation] wido commented on a diff in pull request #320: docs: Update instructions for adding DEB repository
Posted by "wido (via GitHub)" <gi...@apache.org>.
wido commented on code in PR #320:
URL: https://github.com/apache/cloudstack-documentation/pull/320#discussion_r1212873873
##########
source/installguide/management-server/_pkg_repo.rst:
##########
@@ -99,19 +99,19 @@ repository to the file (replace "trusty" with "xenial" or "bionic" if it is the
.. parsed-literal::
- deb http://download.cloudstack.org/ubuntu focal |version|
+ deb https://download.cloudstack.org/ubuntu focal |version|
We now have to add the public key to the trusted keys.
.. parsed-literal::
- wget -O - http://download.cloudstack.org/release.asc |sudo apt-key add -
Review Comment:
I have tested this and it worked on the Ubuntu 22.04 systems I tested this on
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org