Re: [PR] fix(embedded-sdk): clear fetchGuestToken timers on unmount #35143 [superset]

["rusackas (via GitHub)" <gi...@apache.org>]

rusackas commented on PR #37280:
URL: https://github.com/apache/superset/pull/37280#issuecomment-4747258107

   @pachara-strike the fix reads right, but it's conflicting with `master` now — can you rebase? Also `guestTokenRefresh.test.ts` already gives you a fake-timer harness; mind adding a case that asserts `unmount()` stops the refresh from firing? That race is exactly the kind of thing that silently regresses.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org