[GitHub] [kafka] hudeqi commented on a diff in pull request #13348: MINOR: Fix ProducerPerformance still counting successful sending when sending failed

["hudeqi (via GitHub)" <gi...@apache.org>]

hudeqi commented on code in PR #13348:
URL: https://github.com/apache/kafka/pull/13348#discussion_r1132477341


##########
tools/src/main/java/org/apache/kafka/tools/ProducerPerformance.java:
##########
@@ -113,7 +113,7 @@ void start(String[] args) throws IOException {
                 record = new ProducerRecord<>(topicName, payload);
 
                 long sendStartMs = System.currentTimeMillis();
-                Callback cb = stats.nextCompletion(sendStartMs, payload.length, stats);
+                cb = stats.nextCompletion(sendStartMs, payload.length, stats);

Review Comment:
   A great and careful code optimization.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org