You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "pierrejeambrun (via GitHub)" <gi...@apache.org> on 2025/03/31 16:44:58 UTC
[PR] Add retry to triggerer_job test [airflow]
pierrejeambrun opened a new pull request, #48586:
URL: https://github.com/apache/airflow/pull/48586
Test with a retry.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add retry to triggerer_job test [airflow]
Posted by "rawwar (via GitHub)" <gi...@apache.org>.
rawwar commented on code in PR #48586:
URL: https://github.com/apache/airflow/pull/48586#discussion_r2021528809
##########
airflow-core/tests/unit/jobs/test_triggerer_job.py:
##########
@@ -665,6 +665,7 @@ def handle_events(self):
@pytest.mark.asyncio
+@pytest.mark.flaky(reruns=2, reruns_delay=10)
Review Comment:
```suggestion
@pytest.mark.flaky(reruns=3, reruns_delay=10)
```
Maybe 3?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add retry to triggerer_job test [airflow]
Posted by "kaxil (via GitHub)" <gi...@apache.org>.
kaxil commented on code in PR #48586:
URL: https://github.com/apache/airflow/pull/48586#discussion_r2021609764
##########
airflow-core/tests/unit/jobs/test_triggerer_job.py:
##########
@@ -665,6 +665,7 @@ def handle_events(self):
@pytest.mark.asyncio
+@pytest.mark.flaky(reruns=2, reruns_delay=10)
Review Comment:
```suggestion
@pytest.mark.flaky(reruns=2, reruns_delay=10)
@pytest.mark.execution_timeout(20)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add retry to triggerer_job test [airflow]
Posted by "kaxil (via GitHub)" <gi...@apache.org>.
kaxil merged PR #48586:
URL: https://github.com/apache/airflow/pull/48586
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add retry to triggerer_job test [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #48586:
URL: https://github.com/apache/airflow/pull/48586#issuecomment-2767067852
> For some reason the supervisor can hang. Couldn't reproduce locally yet.
I'd also set smaller timeout for it. It seems it might either run quickly or fail after 60 seconds
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add retry to triggerer_job test [airflow]
Posted by "kaxil (via GitHub)" <gi...@apache.org>.
kaxil commented on PR #48586:
URL: https://github.com/apache/airflow/pull/48586#issuecomment-2767128300
> > For some reason the supervisor can hang. Couldn't reproduce locally yet.
>
> I'd also set smaller timeout for it. It seems it might either run quickly or fail after 60 seconds
added
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add retry to triggerer_job test [airflow]
Posted by "rawwar (via GitHub)" <gi...@apache.org>.
rawwar commented on code in PR #48586:
URL: https://github.com/apache/airflow/pull/48586#discussion_r2021528809
##########
airflow-core/tests/unit/jobs/test_triggerer_job.py:
##########
@@ -665,6 +665,7 @@ def handle_events(self):
@pytest.mark.asyncio
+@pytest.mark.flaky(reruns=2, reruns_delay=10)
Review Comment:
```suggestion
@pytest.mark.flaky(reruns=3, reruns_delay=10)
```
Maybe 3? Given, 2 reruns failed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add retry to triggerer_job test [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #48586:
URL: https://github.com/apache/airflow/pull/48586#issuecomment-2767142486
> > > For some reason the supervisor can hang. Couldn't reproduce locally yet.
> >
> >
> > I'd also set smaller timeout for it. It seems it might either run quickly or fail after 60 seconds
>
> added
Cool
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org