[GitHub] [incubator-pinot] bxji commented on a change in pull request #4862: [TE] Generify centralized cache DAO and add certificate-based authentication support for Couchbase

[GitBox <gi...@apache.org>]

bxji commented on a change in pull request #4862: [TE] Generify centralized cache DAO and add certificate-based authentication support for Couchbase
URL: https://github.com/apache/incubator-pinot/pull/4862#discussion_r352809297
 
 

 ##########
 File path: thirdeye/thirdeye-pinot/config/data-sources/cache-config.yml
 ##########
 @@ -9,12 +7,28 @@ centralizedCacheSettings:
   # if inserting data points individually, max number of threads to spawn to parallel insert at a time
   maxParallelInserts: 10
   # which store to use
-  cacheDataStoreName: couchbase
+  cacheDataStoreName: 'couchbase'
   cacheDataSources:
     couchbase:
-      # host can just be localhost if you're using this locally.
-      host: your_host
-      authUsername: your_username
-      authPassword: your_password
-      bucketName: your_bucket_name
-    # add your store of choice here
\ No newline at end of file
+      className: org.apache.pinot.thirdeye.detection.cache.CouchbaseCacheDAO
+      config:
+        useCertificateBasedAuthentication: falses
+        # at least 1 host needed
+        hosts:
+          - 'host1' # ex. http://localhost:8091
+          - 'host2' # ex. http://localhost:8092
+          - 'host3' # ex. http://localhost:8093
+          - 'host4' # and so on...
+        bucketName: 'your_bucket_name'
+        # if using certificate-based authentication, authUsername and authPassword values don't matter and won't be used
+        authUsername: 'your_bucket_user_username'
+        authPassword: 'your_bucket_user_password'
+        enableDnsSrv: true
+        # certificate based authentication is only available in Couchbase enterprise edition. 
+        keyStoreFilePath: 'key/store/path/keystore_file' # e.g. '/var/identity.p12'
+        # by default, Java uses this password to enable empty passwords for certificates.
+        keyStorePassword: 'work_around_jdk-6879539'
 
 Review comment:
   No, it is used as a placeholder to designate empty/not used password. See https://bugs.java.com/bugdatabase/view_bug.do?bug_id=6879539
   
   If there is a password associated with the keystore file, user can set it here.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org