You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "freemandealer (via GitHub)" <gi...@apache.org> on 2026/03/27 14:10:51 UTC
[PR] branch-4.1: [fix](filecache) reclaim expired tablet hotspot counters and compact sparse shards [doris]
freemandealer opened a new pull request, #61834:
URL: https://github.com/apache/doris/pull/61834
TabletHotspot memory kept growing by about 1.8-2.7 GB per day because counters for cold tablets remained resident even after they no longer contributed to the hour/day/week hotspot windows. Their history deques kept consuming memory, and the sharded unordered_maps continued to hold expanded bucket arrays without a reclamation path.
Fix this by running a maintenance pass after each hourly rollup to evict counters whose last access is older than the one-week window and whose current/day/week contributions are all zero. When a shard becomes sparse after eviction, rebuild the map to release bucket memory. Also add GC-focused diagnostics and unit tests to verify eviction, recreation, and shard compaction behavior.
### What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg: https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] branch-4.1: [fix](filecache) reclaim expired tablet hotspot counters and compact sparse shards [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #61834:
URL: https://github.com/apache/doris/pull/61834#issuecomment-4143457571
# BE UT Coverage Report
Increment line coverage `71.76% (183/255)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/0958ce129130dd0ab735e78394c69df0d3c29eb8_0958ce129130dd0ab735e78394c69df0d3c29eb8/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/0958ce129130dd0ab735e78394c69df0d3c29eb8_0958ce129130dd0ab735e78394c69df0d3c29eb8/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 52.91% (19576/36999) |
| Line Coverage | 36.21% (182820/504890) |
| Region Coverage | 32.50% (141288/434668) |
| Branch Coverage | 33.73% (62023/183900) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] branch-4.1: [fix](filecache) reclaim expired tablet hotspot counters and compact sparse shards [doris]
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei merged PR #61834:
URL: https://github.com/apache/doris/pull/61834
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] branch-4.1: [fix](filecache) reclaim expired tablet hotspot counters and compact sparse shards [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #61834:
URL: https://github.com/apache/doris/pull/61834#issuecomment-4148170743
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] branch-4.1: [fix](filecache) reclaim expired tablet hotspot counters and compact sparse shards [doris]
Posted by "Thearas (via GitHub)" <gi...@apache.org>.
Thearas commented on PR #61834:
URL: https://github.com/apache/doris/pull/61834#issuecomment-4142901676
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR).
Please clearly describe your PR:
1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
3. What features were added. Why was this function added?
4. Which code was refactored and why was this part of the code refactored?
5. Which functions were optimized and what is the difference before and after the optimization?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] branch-4.1: [fix](filecache) reclaim expired tablet hotspot counters and compact sparse shards [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #61834:
URL: https://github.com/apache/doris/pull/61834#issuecomment-4144065386
# BE Regression && UT Coverage Report
Increment line coverage `95.69% (244/255)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/61834_0958ce129130dd0ab735e78394c69df0d3c29eb8_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/61834_0958ce129130dd0ab735e78394c69df0d3c29eb8_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 71.08% (25742/36214) |
| Line Coverage | 53.77% (270554/503189) |
| Region Coverage | 51.22% (224673/438635) |
| Branch Coverage | 52.71% (97216/184426) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] branch-4.1: [fix](filecache) reclaim expired tablet hotspot counters and compact sparse shards [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #61834:
URL: https://github.com/apache/doris/pull/61834#issuecomment-4148170799
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] branch-4.1: [fix](filecache) reclaim expired tablet hotspot counters and compact sparse shards [doris]
Posted by "freemandealer (via GitHub)" <gi...@apache.org>.
freemandealer commented on PR #61834:
URL: https://github.com/apache/doris/pull/61834#issuecomment-4142901871
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org