You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@arrow.apache.org by "Zherui Cao (JIRA)" <ji...@apache.org> on 2019/08/13 14:23:00 UTC
[jira] [Commented] (ARROW-6191) [C++] buffer size default value
will throw an error
[ https://issues.apache.org/jira/browse/ARROW-6191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16906250#comment-16906250 ]
Zherui Cao commented on ARROW-6191:
-----------------------------------
letting caller set the buffer size themselves is ok. If they see these error, they may notice they forgot to change the buffer size.
> [C++] buffer size default value will throw an error
> ---------------------------------------------------
>
> Key: ARROW-6191
> URL: https://issues.apache.org/jira/browse/ARROW-6191
> Project: Apache Arrow
> Issue Type: Bug
> Reporter: Zherui Cao
> Assignee: Zherui Cao
> Priority: Major
>
> [https://github.com/apache/arrow/blob/master/cpp/src/parquet/properties.h#L40]
> this set default size as 0,
> but in
> [https://github.com/apache/arrow/blob/master/cpp/src/arrow/io/buffered.cc#L259]
> it prevent the buffer size being 0.
>
> Even though "ReaderProperties::buffered_stream_enabled_" is default false. But if user set it true, but remain buffer size default. This causes an error.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)