You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/09/14 16:45:23 UTC
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #33993: [SPARK-36741][SQL] ArrayDistinct handle duplicated Double.NaN and Float.Nan
dongjoon-hyun commented on a change in pull request #33993:
URL: https://github.com/apache/spark/pull/33993#discussion_r708454521
##########
File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CollectionExpressionsSuite.scala
##########
@@ -2326,4 +2326,13 @@ class CollectionExpressionsSuite extends SparkFunSuite with ExpressionEvalHelper
Literal.create(Seq(Float.NaN, null, 1f), ArrayType(FloatType))),
Seq(Float.NaN, null, 1f))
}
+
+ test("SPARK-36740: ArrayDistinct should handle duplicated Double.NaN and Float.Nan") {
Review comment:
SPARK-36741 instead of SPARK-36740?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org