You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by gu...@apache.org on 2024/04/18 23:53:35 UTC
(spark) branch master updated: [SPARK-44461][FOLLOWUP][SS][CONNECT] Remove unneeded TODOs
This is an automated email from the ASF dual-hosted git repository.
gurwls223 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/spark.git
The following commit(s) were added to refs/heads/master by this push:
new d09230b6601c [SPARK-44461][FOLLOWUP][SS][CONNECT] Remove unneeded TODOs
d09230b6601c is described below
commit d09230b6601ce180213fd24d567ca36c38f90d6c
Author: Wei Liu <we...@databricks.com>
AuthorDate: Fri Apr 19 08:53:23 2024 +0900
[SPARK-44461][FOLLOWUP][SS][CONNECT] Remove unneeded TODOs
### What changes were proposed in this pull request?
Remove unneeded todos
### Why are the changes needed?
code cleanup
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
No need
### Was this patch authored or co-authored using generative AI tooling?
No
Closes #46124 from WweiL/remove-todo.
Authored-by: Wei Liu <we...@databricks.com>
Signed-off-by: Hyukjin Kwon <gu...@apache.org>
---
python/pyspark/sql/connect/streaming/worker/foreach_batch_worker.py | 2 --
python/pyspark/sql/connect/streaming/worker/listener_worker.py | 2 --
2 files changed, 4 deletions(-)
diff --git a/python/pyspark/sql/connect/streaming/worker/foreach_batch_worker.py b/python/pyspark/sql/connect/streaming/worker/foreach_batch_worker.py
index 92ed7a4aaff5..c5730dea4ca1 100644
--- a/python/pyspark/sql/connect/streaming/worker/foreach_batch_worker.py
+++ b/python/pyspark/sql/connect/streaming/worker/foreach_batch_worker.py
@@ -62,8 +62,6 @@ def main(infile: IO, outfile: IO) -> None:
assert spark_connect_session.session_id == session_id
spark = spark_connect_session
- # TODO(SPARK-44461): Enable Process Isolation
-
func = worker.read_command(pickle_ser, infile)
write_int(0, outfile) # Indicate successful initialization
diff --git a/python/pyspark/sql/connect/streaming/worker/listener_worker.py b/python/pyspark/sql/connect/streaming/worker/listener_worker.py
index d3efb5894fc0..3709e50ba026 100644
--- a/python/pyspark/sql/connect/streaming/worker/listener_worker.py
+++ b/python/pyspark/sql/connect/streaming/worker/listener_worker.py
@@ -70,8 +70,6 @@ def main(infile: IO, outfile: IO) -> None:
assert spark_connect_session.session_id == session_id
spark = spark_connect_session
- # TODO(SPARK-44461): Enable Process Isolation
-
listener = worker.read_command(pickle_ser, infile)
write_int(0, outfile) # Indicate successful initialization
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org