You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by Jaydeep Vishwakarma <ja...@gmail.com> on 2015/07/24 12:20:32 UTC
Review Request 36772: OOZIE-2314 Unable to kill old instance child
job by workflow or coord rerun by Launcher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36772/
-----------------------------------------------------------
Review request for oozie.
Bugs: OOZIE-2314
https://issues.apache.org/jira/browse/OOZIE-2314
Repository: oozie-git
Description
-------
In case of coord action using nominal time other wise using workflow created time.
Diffs
-----
core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 6e959df
core/src/main/java/org/apache/oozie/action/hadoop/LauncherMapperHelper.java e22329d
core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java 98f356e
core/src/test/java/org/apache/oozie/action/hadoop/TestLauncher.java 31b5e91
Diff: https://reviews.apache.org/r/36772/diff/
Testing
-------
Tested by running the job on server.
Thanks,
Jaydeep Vishwakarma
Re: Review Request 36772: OOZIE-2314 Unable to kill old instance
child job by workflow or coord rerun by Launcher
Posted by Srikanth Sundarrajan <sr...@hotmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36772/#review100536
-----------------------------------------------------------
core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java (line 880)
<https://reviews.apache.org/r/36772/#comment157758>
Can we save the conf value and use it for both the condition check and the laucnherTimer assignment. A brief code comment on why this is needed would help maintainers in future.
- Srikanth Sundarrajan
On July 24, 2015, 10:24 a.m., Jaydeep Vishwakarma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36772/
> -----------------------------------------------------------
>
> (Updated July 24, 2015, 10:24 a.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-2314
> https://issues.apache.org/jira/browse/OOZIE-2314
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> In case of coord action using nominal time of coord action otherwise using workflow created time.
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 6e959df
> core/src/main/java/org/apache/oozie/action/hadoop/LauncherMapperHelper.java e22329d
> core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java 98f356e
> core/src/test/java/org/apache/oozie/action/hadoop/TestLauncher.java 31b5e91
>
> Diff: https://reviews.apache.org/r/36772/diff/
>
>
> Testing
> -------
>
> Tested by running the job on server.
>
>
> Thanks,
>
> Jaydeep Vishwakarma
>
>
Re: Review Request 36772: OOZIE-2314 Unable to kill old instance
child job by workflow or coord rerun by Launcher
Posted by Robert Kanter <rk...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36772/#review103007
-----------------------------------------------------------
Ship it!
Ship It!
- Robert Kanter
On Oct. 1, 2015, 11:17 a.m., Jaydeep Vishwakarma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36772/
> -----------------------------------------------------------
>
> (Updated Oct. 1, 2015, 11:17 a.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-2314
> https://issues.apache.org/jira/browse/OOZIE-2314
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> In case of coord action using nominal time of coord action otherwise using workflow created time.
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 6e959df
> core/src/main/java/org/apache/oozie/action/hadoop/LauncherMapperHelper.java e22329d
> core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java 98f356e
> core/src/test/java/org/apache/oozie/action/hadoop/TestLauncher.java 31b5e91
>
> Diff: https://reviews.apache.org/r/36772/diff/
>
>
> Testing
> -------
>
> Tested by running the job on server.
>
>
> Thanks,
>
> Jaydeep Vishwakarma
>
>
Re: Review Request 36772: OOZIE-2314 Unable to kill old instance
child job by workflow or coord rerun by Launcher
Posted by Jaydeep Vishwakarma <ja...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36772/
-----------------------------------------------------------
(Updated Oct. 1, 2015, 11:17 a.m.)
Review request for oozie.
Bugs: OOZIE-2314
https://issues.apache.org/jira/browse/OOZIE-2314
Repository: oozie-git
Description
-------
In case of coord action using nominal time of coord action otherwise using workflow created time.
Diffs (updated)
-----
core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 6e959df
core/src/main/java/org/apache/oozie/action/hadoop/LauncherMapperHelper.java e22329d
core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java 98f356e
core/src/test/java/org/apache/oozie/action/hadoop/TestLauncher.java 31b5e91
Diff: https://reviews.apache.org/r/36772/diff/
Testing
-------
Tested by running the job on server.
Thanks,
Jaydeep Vishwakarma
Re: Review Request 36772: OOZIE-2314 Unable to kill old instance
child job by workflow or coord rerun by Launcher
Posted by Jaydeep Vishwakarma <ja...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36772/
-----------------------------------------------------------
(Updated July 24, 2015, 10:24 a.m.)
Review request for oozie.
Bugs: OOZIE-2314
https://issues.apache.org/jira/browse/OOZIE-2314
Repository: oozie-git
Description (updated)
-------
In case of coord action using nominal time of coord action otherwise using workflow created time.
Diffs
-----
core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 6e959df
core/src/main/java/org/apache/oozie/action/hadoop/LauncherMapperHelper.java e22329d
core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java 98f356e
core/src/test/java/org/apache/oozie/action/hadoop/TestLauncher.java 31b5e91
Diff: https://reviews.apache.org/r/36772/diff/
Testing
-------
Tested by running the job on server.
Thanks,
Jaydeep Vishwakarma