[jira] [Commented] (AIRFLOW-6510) DruidOperator templating not working as expected

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AIRFLOW-6510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17010757#comment-17010757 ] 

ASF GitHub Bot commented on AIRFLOW-6510:
-----------------------------------------

alexnu commented on pull request #7102: [AIRFLOW-6510] - Fix Druid operator rendering from file
URL: https://github.com/apache/airflow/pull/7102
 
 
   Dear maintainers,
   
   Please accept my PR which fixes the way druid specification json is loaded by leveraging template fields as in most other operators, rather that manually parsing the file in the operator.
   
   I am also working on providing a valid unit test.
   ---
   Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg)
   
   - [ ] Description above provides context of the change
   - [ ] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN = JIRA ID<sup>*</sup>
   - [ ] Unit tests coverage for changes (not needed for documentation changes)
   - [ ] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
   - [ ] Relevant documentation is updated including usage instructions.
   - [ ] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
   
   <sup>*</sup> For document-only changes commit message can start with `[AIRFLOW-XXXX]`.
   
   ---
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> DruidOperator templating not working as expected
> ------------------------------------------------
>
>                 Key: AIRFLOW-6510
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-6510
>             Project: Apache Airflow
>          Issue Type: Bug
>          Components: contrib, operators
>    Affects Versions: 1.10.0
>            Reporter: Alexandros Nafas
>            Priority: Major
>
> When trying to load the druid specification from a file, I get the following error:
> {code:java}
> Broken DAG: [/etc/airflow/dags/central/central_hourly.py] [Errno 2] No such file or directory: 'central_hourly_spec.json'
> {code}
> even though file central_hourly_spec.json exists in the same folder as the DAG.
> This is the task definition:
> {code:java}
> druid = DruidOperator(
>     task_id='central_druid',
>     json_index_file='central_hourly_spec.json',
>     druid_ingest_conn_id='druid_ingest',
>     dag=dag
> )
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)