You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Abe Ratnofsky (Jira)" <ji...@apache.org> on 2025/06/02 17:19:00 UTC
[jira] [Comment Edited] (CASSJAVA-102) Fix revapi surious complaints about optional dependencies
[ https://issues.apache.org/jira/browse/CASSJAVA-102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17955716#comment-17955716 ]
Abe Ratnofsky edited comment on CASSJAVA-102 at 6/2/25 5:18 PM:
----------------------------------------------------------------
Looks like this is failing in CI because our CI image is only on Maven 3.6.3, and newer revapi versions require at least 3.8.1:
From [CI run|https://ci-cassandra.apache.org/job/cassandra-java-driver/job/PR-2042/1/cloudbees-pipeline-explorer/?filter=110&line=169]:
> [ERROR] Failed to execute goal org.revapi:revapi-maven-plugin:0.15.1:check (default) on project java-driver-parent: The plugin org.revapi:revapi-maven-plugin:0.15.1 requires Maven version 3.8.1 -> [Help 1]
For context, 3.6.3 is EOL and was released in 2019, 3.8.1 was released in 2021. I'd support upgrading to 3.8.8 from 2023. Proposed change here to include a newer Maven version: https://github.com/apache/cassandra-builds/blob/trunk/docker/testing/ubuntu2204_java_driver_testing.docker#L18
We'd have to install from a release tarball here, since the Ubuntu repositories are out of date: https://dlcdn.apache.org/maven/maven-3/3.8.8/binaries/apache-maven-3.8.8-bin.tar.gz
Then need to build and publish new images, looks like Mick has done that in the past: https://github.com/apache/cassandra-builds/pull/103
was (Author: aratnofsky):
Looks like this is failing in CI because our CI image is only on Maven 3.6.3, and newer revapi versions require at least 3.8.1:
From [CI run|https://ci-cassandra.apache.org/job/cassandra-java-driver/job/PR-2042/1/cloudbees-pipeline-explorer/?filter=110&line=169]:
> [ERROR] Failed to execute goal org.revapi:revapi-maven-plugin:0.15.1:check (default) on project java-driver-parent: The plugin org.revapi:revapi-maven-plugin:0.15.1 requires Maven version 3.8.1 -> [Help 1]
For context, 3.6.3 is EOL and was released in 2019, 3.8.1 was released in 2021. I'd support upgrading to 3.8.8 from 2023. Proposed change here to include a newer Maven version: https://github.com/apache/cassandra-builds/blob/trunk/docker/testing/ubuntu2204_java_driver_testing.docker#L18
We'd have to install from a release tarball here, since the Ubuntu repositories are out of date: https://dlcdn.apache.org/maven/maven-3/3.8.8/binaries/apache-maven-3.8.8-bin.tar.gz
> Fix revapi surious complaints about optional dependencies
> ---------------------------------------------------------
>
> Key: CASSJAVA-102
> URL: https://issues.apache.org/jira/browse/CASSJAVA-102
> Project: Apache Cassandra Java driver
> Issue Type: Improvement
> Components: Core
> Reporter: Abe Ratnofsky
> Assignee: Abe Ratnofsky
> Priority: Low
> Time Spent: 10m
> Remaining Estimate: 0h
>
> We use revapi on cassandra-java-driver 4.x to ensure we’re not breaking public / external APIs that users depend on. The tool doesn’t work correctly on my machine (even with default Maven repositories, cleared out local ~/.m2, clean slate). Here are some of the complaints I would get with revapi, even when I tweaked the configuration to compare a version against itself:
> Comparing [org.apache.cassandra:java-driver-core:jar:4.18.0] against [org.apache.cassandra:java-driver-core:jar:4.18.0]
> ...
> [INFO] java.missing.oldClass: missing-class com.esri.core.geometry.Geometry: Class 'com.esri.core.geometry.Geometry' could not be found in the archives of the old API. It has been detected as contributing to the API and thus the analysis results may be incorrect.
> [INFO] java.missing.newClass: missing-class com.esri.core.geometry.Geometry: Class 'com.esri.core.geometry.Geometry' could not be found in the archives of the new API. It has been detected as contributing to the API and thus the analysis results may be incorrect.
> Common offenders were optional dependencies: esri, tinkerpop, etc.
> Patch available.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org