You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/12/31 01:10:44 UTC

[GitHub] [apisix-dashboard] nic-chen commented on pull request #1162: fix: correct Version and GitHash output for manager-api command

nic-chen commented on pull request #1162:
URL: https://github.com/apache/apisix-dashboard/pull/1162#issuecomment-752807854


   @imjoey 
   
   It would be great to add an assertion for the modified code in the corresponding test case:
   https://github.com/apache/apisix-dashboard/blob/master/api/test/shell/cli_test.sh#L118-L145
   
   Thanks!
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org