You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2018/12/06 01:29:01 UTC

[GitHub] jihoonson commented on a change in pull request #6713: Fix travis timeout in BufferHashGrouperTest

jihoonson commented on a change in pull request #6713: Fix travis timeout in BufferHashGrouperTest
URL: https://github.com/apache/incubator-druid/pull/6713#discussion_r239300916
 
 

 ##########
 File path: processing/src/test/java/org/apache/druid/query/groupby/epinephelinae/BufferHashGrouperTest.java
 ##########
 @@ -140,8 +140,8 @@ public void testGrowing()
   public void testGrowing2()
   {
     final TestColumnSelectorFactory columnSelectorFactory = GrouperTestUtil.newColumnSelectorFactory();
-    final Grouper<Integer> grouper = makeGrouper(columnSelectorFactory, 2_000_000_000, 2);
-    final int expectedMaxSize = NullHandling.replaceWithDefault() ? 40988516 : 39141224;
+    final Grouper<Integer> grouper = makeGrouper(columnSelectorFactory, 250_000_000, 2);
 
 Review comment:
   Oh, yeah. I forgot to rename those tests. I'll add a comment too.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org