You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Don Bosco Durai <bo...@apache.org> on 2015/11/25 07:53:50 UTC
Review Request 40696: RANGER-744: Kafka Authorizer has updated how
IP/Host is passed
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40696/
-----------------------------------------------------------
Review request for ranger and Gautam Borad.
Bugs: RANGER-744
https://issues.apache.org/jira/browse/RANGER-744
Repository: ranger
Description
-------
Fixed how to get Host from Kafka Authentication session. Also added new interface method .close() to the shim class
Diffs
-----
plugin-kafka/src/main/java/org/apache/ranger/authorization/kafka/authorizer/RangerKafkaAuthorizer.java 29c2ceb
ranger-kafka-plugin-shim/src/main/java/org/apache/ranger/authorization/kafka/authorizer/RangerKafkaAuthorizer.java 0937835
Diff: https://reviews.apache.org/r/40696/diff/
Testing
-------
Thanks,
Don Bosco Durai
Re: Review Request 40696: RANGER-744: Kafka Authorizer has updated how
IP/Host is passed
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40696/#review108441
-----------------------------------------------------------
plugin-kafka/src/main/java/org/apache/ranger/authorization/kafka/authorizer/RangerKafkaAuthorizer.java (line 139)
<https://reviews.apache.org/r/40696/#comment167904>
it will be safer to check for "session.clientAddress() == null" - unless if we are sure that Kafka will always return non-null value here.
- Madhan Neethiraj
On Nov. 25, 2015, 6:53 a.m., Don Bosco Durai wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40696/
> -----------------------------------------------------------
>
> (Updated Nov. 25, 2015, 6:53 a.m.)
>
>
> Review request for ranger and Gautam Borad.
>
>
> Bugs: RANGER-744
> https://issues.apache.org/jira/browse/RANGER-744
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Fixed how to get Host from Kafka Authentication session. Also added new interface method .close() to the shim class
>
>
> Diffs
> -----
>
> plugin-kafka/src/main/java/org/apache/ranger/authorization/kafka/authorizer/RangerKafkaAuthorizer.java 29c2ceb
> ranger-kafka-plugin-shim/src/main/java/org/apache/ranger/authorization/kafka/authorizer/RangerKafkaAuthorizer.java 0937835
>
> Diff: https://reviews.apache.org/r/40696/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Don Bosco Durai
>
>
Re: Review Request 40696: RANGER-744: Kafka Authorizer has updated how
IP/Host is passed
Posted by Gautam Borad <gb...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40696/#review107932
-----------------------------------------------------------
Ship it!
Ship It!
- Gautam Borad
On Nov. 25, 2015, 6:53 a.m., Don Bosco Durai wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40696/
> -----------------------------------------------------------
>
> (Updated Nov. 25, 2015, 6:53 a.m.)
>
>
> Review request for ranger and Gautam Borad.
>
>
> Bugs: RANGER-744
> https://issues.apache.org/jira/browse/RANGER-744
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Fixed how to get Host from Kafka Authentication session. Also added new interface method .close() to the shim class
>
>
> Diffs
> -----
>
> plugin-kafka/src/main/java/org/apache/ranger/authorization/kafka/authorizer/RangerKafkaAuthorizer.java 29c2ceb
> ranger-kafka-plugin-shim/src/main/java/org/apache/ranger/authorization/kafka/authorizer/RangerKafkaAuthorizer.java 0937835
>
> Diff: https://reviews.apache.org/r/40696/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Don Bosco Durai
>
>