You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/07/14 12:52:15 UTC

[GitHub] [flink-benchmarks] zentol opened a new pull request #20: [FLINK-23383] Prevent duplicate setUp/tearDown calls

zentol opened a new pull request #20:
URL: https://github.com/apache/flink-benchmarks/pull/20


   Prevents an issue where `FlinkEnvironmentContext#setUp/tearDown` would be called multiple times, because subclasses contained overrides annotated with `@SetUp/@TearDown` which called into the parent version.
   
   The effect can be easily seen by adding some `println` statements to `FlinkEnvironmentContext#setUp` and running the `WindowBenchmarks`, (or any benchmark with a `FlinkEnvironmentContext` subclass).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink-benchmarks] zentol merged pull request #20: [FLINK-23383] Prevent duplicate setUp/tearDown calls

Posted by GitBox <gi...@apache.org>.
zentol merged pull request #20:
URL: https://github.com/apache/flink-benchmarks/pull/20


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org