[GitHub] [hbase] ramkrish86 commented on a change in pull request #656: HBASE-23063 Add an option to enable multiget in parallel

[GitBox <gi...@apache.org>]

ramkrish86 commented on a change in pull request #656: HBASE-23063 Add an option to enable multiget in parallel
URL: https://github.com/apache/hbase/pull/656#discussion_r327937137
 
 

 ##########
 File path: hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/ServerCall.java
 ##########
 @@ -431,31 +436,42 @@ public boolean isClientCellBlockSupported() {
 
   @Override
   public long getResponseCellSize() {
-    return responseCellSize;
+    return responseCellSize.get();
   }
 
   @Override
-  public void incrementResponseCellSize(long cellSize) {
-    responseCellSize += cellSize;
+  public long getNumsOfGet() {
+    return getsNum.get();
+  }
+
+  public long incrementGetsNum() {
+    return this.getsNum.incrementAndGet();
   }
 
   @Override
-  public long getResponseBlockSize() {
-    return responseBlockSize;
+  public void addResultSize(Result result) {
+    if (result != null && !result.isEmpty()) {
+      for (Cell c : result.rawCells()) {
+        this.responseCellSize.addAndGet(PrivateCellUtil.estimatedSerializedSizeOf(c));
 
 Review comment:
   Seems the addSize() in RSRpcServices was also trying to do some calculation based on type of cell. That is not needed any more? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services