Re: [PR] Fix MSQ compaction state and native interval locking, add test coverage (druid)

["cecemei (via GitHub)" <gi...@apache.org>]

cecemei commented on code in PR #18950:
URL: https://github.com/apache/druid/pull/18950#discussion_r2752744039


##########
indexing-service/src/main/java/org/apache/druid/indexing/common/task/CompactionRunner.java:
##########
@@ -42,6 +42,28 @@ public interface CompactionRunner
 {
   String TYPE_PROPERTY = "type";
 
+  /**
+   * Returns whether this runner requires aligned intervals for compaction.
+   * When true, the compaction task will throw an error if the IOConfig has allowNonAlignedInterval enabled.
+   *
+   * @return true if aligned intervals are required by this runner, false otherwise. Default is true.
+   */
+  default boolean requireAlignedInterval()
+  {
+    return true;
+  }
+
+  /**
+   * Returns whether this runner requires dropExisting to be enabled for compaction.
+   * When true, the compaction task will fail if dropExisting is not set to true in the IOConfig.
+   *
+   * @return true if dropExisting must be enabled, false otherwise. Default is true.
+   */
+  default boolean forceDropExisting()
+  {
+    return true;

Review Comment:
   MSQ actually never read this config, but instead just run with dropExisting, even though it's set to false (which is also the default) in the config. I thought this would be somewhat confusing if ppl really look into what this field means. 
   
   So it's not a real change for compaction runner, the result would still be the same but instead we just want the config to be honest. I was also hesistant about this might break anything, so also considering maybe just revert this change in case it breaks something. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org