You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hugegraph.apache.org by "SunnyBoy-WYH (via GitHub)" <gi...@apache.org> on 2023/09/27 08:55:31 UTC

[GitHub] [incubator-hugegraph] SunnyBoy-WYH commented on a diff in pull request #2286: feat(api): support metric API Prometheus format & add statistic metric api

SunnyBoy-WYH commented on code in PR #2286:
URL: https://github.com/apache/incubator-hugegraph/pull/2286#discussion_r1338287717


##########
hugegraph-test/src/main/java/org/apache/hugegraph/api/MetricsApiTest.java:
##########
@@ -234,8 +259,8 @@ public void testMetricsBackend() {
                     String key = (String) e.getKey();
                     value = e.getValue();
                     Assert.assertTrue(String.format(
-                                      "Expect map value for key %s but got %s",
-                                      key, value),
+                                              "Expect map value for key %s but got %s",

Review Comment:
   seems done? if we choose all commit
   ![image](https://github.com/apache/incubator-hugegraph/assets/48077841/bd8d8020-5e47-4b5b-922e-13bae6ff912a)
   



##########
hugegraph-test/src/main/java/org/apache/hugegraph/api/MetricsApiTest.java:
##########
@@ -234,8 +259,8 @@ public void testMetricsBackend() {
                     String key = (String) e.getKey();
                     value = e.getValue();
                     Assert.assertTrue(String.format(
-                                      "Expect map value for key %s but got %s",
-                                      key, value),
+                                              "Expect map value for key %s but got %s",

Review Comment:
   seems done? if we choose all commit
   ![image](https://github.com/apache/incubator-hugegraph/assets/48077841/bd8d8020-5e47-4b5b-922e-13bae6ff912a)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org