[GitHub] [trafficserver] SolidWallOfCode commented on a change in pull request #6832: Duplicate regression tests in InkAPITest.cc as Au Tests

[GitBox <gi...@apache.org>]

SolidWallOfCode commented on a change in pull request #6832:
URL: https://github.com/apache/trafficserver/pull/6832#discussion_r494495856



##########
File path: iocore/eventsystem/I_EventProcessor.h
##########
@@ -299,9 +299,9 @@ class EventProcessor : public Processor
   /// The thread group ID is the index into an array of these and so is not stored explicitly.
   struct ThreadGroupDescriptor {
     std::string _name;                               ///< Name for the thread group.
-    int _count                 = 0;                  ///< # of threads of this type.
-    std::atomic<int> _started  = 0;                  ///< # of started threads of this type.
-    uint64_t _next_round_robin = 0;                  ///< Index of thread to use for events assigned to this group.

Review comment:
       Why was this changed from unsigned to signed?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org