You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cvs@httpd.apache.org by rp...@apache.org on 2021/12/09 07:40:25 UTC
svn commit: r1895715 - in /httpd/httpd/trunk/modules/proxy: mod_proxy_connect.c mod_proxy_http.c
Author: rpluem
Date: Thu Dec 9 07:40:25 2021
New Revision: 1895715
URL: http://svn.apache.org/viewvc?rev=1895715&view=rev
Log:
* Do not change the status code after we already sent it to the client.
Changing the status code after we sent it to the client causes a status
code being logged that is different from the one sent to the client which
can be confusing.
Modified:
httpd/httpd/trunk/modules/proxy/mod_proxy_connect.c
httpd/httpd/trunk/modules/proxy/mod_proxy_http.c
Modified: httpd/httpd/trunk/modules/proxy/mod_proxy_connect.c
URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/proxy/mod_proxy_connect.c?rev=1895715&r1=1895714&r2=1895715&view=diff
==============================================================================
--- httpd/httpd/trunk/modules/proxy/mod_proxy_connect.c (original)
+++ httpd/httpd/trunk/modules/proxy/mod_proxy_connect.c Thu Dec 9 07:40:25 2021
@@ -354,8 +354,6 @@ static int proxy_connect_handler(request
if (proxyport && !tunnel->replied) {
return rc;
}
- /* Custom log may need this, still */
- r->status = rc;
}
/*
Modified: httpd/httpd/trunk/modules/proxy/mod_proxy_http.c
URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/proxy/mod_proxy_http.c?rev=1895715&r1=1895714&r2=1895715&view=diff
==============================================================================
--- httpd/httpd/trunk/modules/proxy/mod_proxy_http.c (original)
+++ httpd/httpd/trunk/modules/proxy/mod_proxy_http.c Thu Dec 9 07:40:25 2021
@@ -1539,9 +1539,6 @@ int ap_proxy_http_process_response(proxy
/* Let proxy tunnel forward everything within this thread */
req->tunnel->timeout = req->idle_timeout;
status = ap_proxy_tunnel_run(req->tunnel);
- if (ap_is_HTTP_ERROR(status)) {
- r->status = status;
- }
/* Report bytes exchanged by the backend */
backend->worker->s->read +=