You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pinot.apache.org by "gortiz (via GitHub)" <gi...@apache.org> on 2023/09/04 08:16:03 UTC

[GitHub] [pinot] gortiz commented on pull request #11478: fix float to double type conversion

gortiz commented on PR #11478:
URL: https://github.com/apache/pinot/pull/11478#issuecomment-1704817573

   > Maybe we should always use BigDecimal to perform the comparison and set value for floating-point numbers
   
   No please. That would destroy the performance. I don't think we can merge this without doing proper benchmarking


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org