You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@geode.apache.org by "Owen Nichols (Jira)" <ji...@apache.org> on 2022/06/22 20:47:03 UTC

[jira] [Closed] (GEODE-9500) RedisData keeps DeltaInfo references too long

     [ https://issues.apache.org/jira/browse/GEODE-9500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Owen Nichols closed GEODE-9500.
-------------------------------

> RedisData keeps DeltaInfo references too long
> ---------------------------------------------
>
>                 Key: GEODE-9500
>                 URL: https://issues.apache.org/jira/browse/GEODE-9500
>             Project: Geode
>          Issue Type: Bug
>          Components: redis
>            Reporter: Darrel Schneider
>            Assignee: Darrel Schneider
>            Priority: Major
>              Labels: pull-request-available, unreleased
>             Fix For: 1.15.0
>
>
> The current implementation of Delta for RedisData does not clear the reference to the DeltaInfo until toDelta is called. This works fine in the normal case but in the abnormal case it can case extra memory to be used by the DeltaInfo instances being kept alive.
> What can happen is that if the extra server goes down so that geode is running with one server then some optimization are done by geode and it never calls toDelta. So in that case the DeltaInfo instances will be kept stored on the primary.
> We actually have sizing tests that found this problem but those tests were changes to clear the DeltaInfo reference in the test.
> Instead we should have these tests not clear it and change geode to clear it in AbstractRedisData.storeChanges after the put returns.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)