[GitHub] [solr] dsmiley commented on pull request #994: SOLR-16369: avoid xpath in parsing elevate.xml

[GitBox <gi...@apache.org>]

dsmiley commented on PR #994:
URL: https://github.com/apache/solr/pull/994#issuecomment-1235773336

   I'm glad we agree on XPath being not particularly useful for elevate.xml parsing (because it's so simple).  @heythm and I did multiple rounds of code review in #962 ; I would prefer to use that PR.  It also clarified some code readability and made it *not* use XmlConfigFile either.  @noblepaul could you please review #962, especially just the QueryElevationComponent file.
   
   #962 has evolved to one PR doing two distinct things that perhaps should be separated:  QueryElevationComponent changes, and XmlConfigFile changes (to use SafeXMLParsing, involving another overload of parseConfigXML).  We could split it.  WDYT?  


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org