[jira] [Commented] (HTTPCORE-445) Path matching issue when a query string is present in the URI

["Oleg Kalnichevski (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HTTPCORE-445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15861077#comment-15861077 ] 

Oleg Kalnichevski commented on HTTPCORE-445:
--------------------------------------------

Hi Francois-Xavier,
Obvious bugs like that you can just go ahead and fix right away without too much of a formal workflow. You have SVN karma for the project, don't you?

Oleg

> Path matching issue when a query string is present in the URI
> -------------------------------------------------------------
>
>                 Key: HTTPCORE-445
>                 URL: https://issues.apache.org/jira/browse/HTTPCORE-445
>             Project: HttpComponents HttpCore
>          Issue Type: Bug
>          Components: HttpCore NIO
>    Affects Versions: 5.0-alpha2, 5.0-alpha3
>            Reporter: Francois-Xavier Bonnet
>            Priority: Minor
>         Attachments: Main.java
>
>
> If I register a handler with pattern "/test*" it successfully matches "/test" or "/test/abcd" but surprisingly it does not match "/test?x=y"
> Looking at the code:{code:title=AsyncServerExchangeHandlerRegistry.create(HttpRequest)|borderStyle=solid} 
> 78        final int i = path.indexOf("?");
> 79        if (i != -1) {
> 80            path = path.substring(0, i - 1);
> 81        }
> {code}
> Doing this removes the last character before the query string, "/test?x=y" becomes "/tes" which does not match.
> I attached a sample class to reproduce the issue.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org