[GitHub] [kafka] vitojeng commented on a change in pull request #8200: KAFKA-5876: IQ should throw different exceptions for different errors(part 1)

[GitBox <gi...@apache.org>]

vitojeng commented on a change in pull request #8200:
URL: https://github.com/apache/kafka/pull/8200#discussion_r438478402



##########
File path: streams/src/main/java/org/apache/kafka/streams/errors/InvalidStateStoreException.java
##########
@@ -18,13 +18,11 @@
 
 
 /**
- * Indicates that there was a problem when trying to access a
- * {@link org.apache.kafka.streams.processor.StateStore StateStore}, i.e, the Store is no longer valid because it is
- * closed or doesn't exist any more due to a rebalance.
- * <p>
- * These exceptions may be transient, i.e., during a rebalance it won't be possible to query the stores as they are
- * being (re)-initialized. Once the rebalance has completed the stores will be available again. Hence, it is valid
- * to backoff and retry when handling this exception.
+ * <p>Indicates that there was a problem when trying to access a {@link org.apache.kafka.streams.processor.StateStore StateStore}.
+ * InvalidStateStoreException not thrown directly but only following sub-classes:</p>
+ * {@link StreamsNotStartedException}, {@link StreamsRebalancingException},
+ * {@link StateStoreMigratedException}, {@link StateStoreNotAvailableException},
+ * {@link UnknownStateStoreException}, {@link InvalidStateStorePartitionException}
  */
 public class InvalidStateStoreException extends StreamsException {

Review comment:
       @brary Thanks for reviewing. In KIP-216, the main purpose of keeping InvalidStateStoreException is to keep compatibility, this should be important to users. Your suggestion still valuable, we can do it in the future.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org