You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@marmotta.apache.org by "Sergio Fernández (JIRA)" <ji...@apache.org> on 2016/06/20 06:17:05 UTC
[jira] [Comment Edited] (MARMOTTA-644) test fails on Windows build
[ https://issues.apache.org/jira/browse/MARMOTTA-644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15338790#comment-15338790 ]
Sergio Fernández edited comment on MARMOTTA-644 at 6/20/16 6:16 AM:
--------------------------------------------------------------------
cant see where to upload a patch:
From 6d9967c66bd9a2f8ef2aa6c3874aa4bb4874dbb7 Mon Sep 17 00:00:00 2001
From: Rob Atkinson <ro...@metalinkage.com.au>
Date: Mon, 20 Jun 2016 06:40:22 +1000
Subject: [PATCH] fixes for Windows environment
{code}
---
.../marmotta/platform/ldp/services/LdpBinaryStoreServiceImplTest.java | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/platform/marmotta-ldp/src/test/java/org/apache/marmotta/platform/ldp/services/LdpBinaryStoreServiceImplTest.java b/platform/marmotta-ldp/src/test/java/org/apache/marmotta/platform/ldp/services/LdpBinaryStoreServiceImplTest.java
index ee96b8e..ace1ecb 100644
--- a/platform/marmotta-ldp/src/test/java/org/apache/marmotta/platform/ldp/services/LdpBinaryStoreServiceImplTest.java
+++ b/platform/marmotta-ldp/src/test/java/org/apache/marmotta/platform/ldp/services/LdpBinaryStoreServiceImplTest.java
@@ -25,6 +25,7 @@ import org.junit.BeforeClass;
import org.junit.Test;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
+import java.nio.file.Paths;
public class LdpBinaryStoreServiceImplTest {
@@ -47,7 +48,7 @@ public class LdpBinaryStoreServiceImplTest {
final LdpBinaryStoreServiceImpl store = marmotta.getService(LdpBinaryStoreServiceImpl.class);
final String test1 = "http://localhost:8080/foo/bar/123";
- Assert.assertThat(store.getFile(test1).toString(), CoreMatchers.endsWith("/localhost.8080/foo/bar/123"));
+ Assert.assertThat(store.getFile(test1).toString(), CoreMatchers.endsWith(Paths.get("/localhost.8080/foo/bar/123").toString()));
// There might be more testing like this here...
}
--
1.9.4.msysgit.1
{code}
was (Author: rob@metalinkage.com.au):
cant see where to upload a patch:
From 6d9967c66bd9a2f8ef2aa6c3874aa4bb4874dbb7 Mon Sep 17 00:00:00 2001
From: Rob Atkinson <ro...@metalinkage.com.au>
Date: Mon, 20 Jun 2016 06:40:22 +1000
Subject: [PATCH] fixes for Windows environment
---
.../marmotta/platform/ldp/services/LdpBinaryStoreServiceImplTest.java | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/platform/marmotta-ldp/src/test/java/org/apache/marmotta/platform/ldp/services/LdpBinaryStoreServiceImplTest.java b/platform/marmotta-ldp/src/test/java/org/apache/marmotta/platform/ldp/services/LdpBinaryStoreServiceImplTest.java
index ee96b8e..ace1ecb 100644
--- a/platform/marmotta-ldp/src/test/java/org/apache/marmotta/platform/ldp/services/LdpBinaryStoreServiceImplTest.java
+++ b/platform/marmotta-ldp/src/test/java/org/apache/marmotta/platform/ldp/services/LdpBinaryStoreServiceImplTest.java
@@ -25,6 +25,7 @@ import org.junit.BeforeClass;
import org.junit.Test;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
+import java.nio.file.Paths;
public class LdpBinaryStoreServiceImplTest {
@@ -47,7 +48,7 @@ public class LdpBinaryStoreServiceImplTest {
final LdpBinaryStoreServiceImpl store = marmotta.getService(LdpBinaryStoreServiceImpl.class);
final String test1 = "http://localhost:8080/foo/bar/123";
- Assert.assertThat(store.getFile(test1).toString(), CoreMatchers.endsWith("/localhost.8080/foo/bar/123"));
+ Assert.assertThat(store.getFile(test1).toString(), CoreMatchers.endsWith(Paths.get("/localhost.8080/foo/bar/123").toString()));
// There might be more testing like this here...
}
--
1.9.4.msysgit.1
> test fails on Windows build
> ---------------------------
>
> Key: MARMOTTA-644
> URL: https://issues.apache.org/jira/browse/MARMOTTA-644
> Project: Marmotta
> Issue Type: Test
> Components: Build Environment
> Affects Versions: 3.4.0
> Environment: Windows build environment
> Reporter: Rob Atkinson
> Priority: Trivial
> Labels: patch, test
>
> non-safe file path comparisons
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)