You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2021/10/19 05:09:53 UTC

[GitHub] [activemq-artemis] nbrendah commented on a change in pull request #3801: ARTEMIS-3523: Expose replay through AddressControl

nbrendah commented on a change in pull request #3801:
URL: https://github.com/apache/activemq-artemis/pull/3801#discussion_r731498792



##########
File path: artemis-server/src/main/java/org/apache/activemq/artemis/core/management/impl/ActiveMQServerControlImpl.java
##########
@@ -4443,7 +4443,7 @@ public void reloadConfigurationFile() throws Exception {
 
    @Override
    public void replay(String address, String target, String filter) throws Exception {
-      server.replay(null, null, address, target, filter);
+      server.replay(null, null, this.getAddressInfo(address), target, filter);

Review comment:
       I think the requirement was `this.address` but the `this` property does not have access to the address field.  Unless there is some  class we have to implement or extend.  
   
   Or this is implemented in a wrong position.
   
   Looking forward to seeing your suggestions @clebertsuconic 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org