You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/01/19 17:28:17 UTC
[GitHub] [cloudstack] DaanHoogland opened a new pull request #5879: Role escalation prevention
DaanHoogland opened a new pull request #5879:
URL: https://github.com/apache/cloudstack/pull/5879
### Description
This PR...
<!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
Fixes: #5781
<!--- ********************************************************************************* -->
<!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ********************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [x] Major
- [ ] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [x] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #5879: Role escalation prevention
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #5879:
URL: https://github.com/apache/cloudstack/pull/5879#issuecomment-1016700250
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5879: Role escalation prevention
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5879:
URL: https://github.com/apache/cloudstack/pull/5879#issuecomment-1021054048
@DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan removed a comment on pull request #5879: Role escalation prevention
Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #5879:
URL: https://github.com/apache/cloudstack/pull/5879#issuecomment-1019559062
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan removed a comment on pull request #5879: Role escalation prevention
Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #5879:
URL: https://github.com/apache/cloudstack/pull/5879#issuecomment-1019559062
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #5879: Role escalation prevention
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #5879:
URL: https://github.com/apache/cloudstack/pull/5879#issuecomment-1026704809
@blueorangutan test keepEnv
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5879: Role escalation prevention
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5879:
URL: https://github.com/apache/cloudstack/pull/5879#issuecomment-1027368501
<b>Trillian Build Failed (tid-3110)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland removed a comment on pull request #5879: Role escalation prevention
Posted by GitBox <gi...@apache.org>.
DaanHoogland removed a comment on pull request #5879:
URL: https://github.com/apache/cloudstack/pull/5879#issuecomment-1030027368
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan removed a comment on pull request #5879: Role escalation prevention
Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #5879:
URL: https://github.com/apache/cloudstack/pull/5879#issuecomment-1030027650
@DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #5879: Role escalation prevention
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on a change in pull request #5879:
URL: https://github.com/apache/cloudstack/pull/5879#discussion_r799483528
##########
File path: plugins/api/discovery/src/main/java/org/apache/cloudstack/discovery/ApiDiscoveryServiceImpl.java
##########
@@ -210,6 +211,24 @@ private ApiDiscoveryResponse getCmdRequestMap(Class<?> cmdClass, APICommand apiC
return response;
}
+ @Override
+ public List<String> listApiNames(Account account) {
+ List<String> apiNames = new ArrayList<>();
+ for (String apiName : s_apiNameDiscoveryResponseMap.keySet()) {
+ boolean isAllowed = true;
+ for (APIChecker apiChecker : _apiAccessCheckers) {
+ try {
+ apiChecker.checkAccess(account, apiName);
+ } catch (Exception ex) {
+ isAllowed = false;
Review comment:
no, multiple access checkers can be called and any one may deny.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5879: Role escalation prevention
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5879:
URL: https://github.com/apache/cloudstack/pull/5879#issuecomment-1030425553
@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5879: Role escalation prevention
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5879:
URL: https://github.com/apache/cloudstack/pull/5879#issuecomment-1019559062
@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #5879: Role escalation prevention
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #5879:
URL: https://github.com/apache/cloudstack/pull/5879#issuecomment-1019558888
@blueorangutan test keepEnv
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5879: Role escalation prevention
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5879:
URL: https://github.com/apache/cloudstack/pull/5879#issuecomment-1017272816
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 2261
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5879: Role escalation prevention
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5879:
URL: https://github.com/apache/cloudstack/pull/5879#issuecomment-1018886408
<b>Trillian test result (tid-2934)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 17810 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5879-t2934-kvm-centos7.zip
Smoke tests completed. 44 look OK, 48 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
ContextSuite context=TestPortablePublicIPAcquire>:setup | `Error` | 0.00 | test_portable_publicip.py
ContextSuite context=TestPortablePublicIPRange>:setup | `Error` | 0.00 | test_portable_publicip.py
ContextSuite context=TestVmSnapshot>:setup | `Error` | 0.25 | test_vm_snapshots.py
test_01_create_account | `Error` | 0.21 | test_accounts.py
test_02_update_account | `Error` | 0.22 | test_accounts.py
test_DeleteDomain | `Error` | 1.28 | test_accounts.py
test_forceDeleteDomain | `Error` | 1.31 | test_accounts.py
test_move_user_incorrect_account_id | `Error` | 0.17 | test_accounts.py
test_move_user_incorrect_account_name | `Error` | 0.17 | test_accounts.py
test_move_user_to_accountID | `Error` | 0.17 | test_accounts.py
test_move_user_to_account_name | `Error` | 0.17 | test_accounts.py
test_move_user_to_different_domain | `Error` | 0.16 | test_accounts.py
test_01_non_root_admin_Privileges | `Error` | 0.17 | test_accounts.py
ContextSuite context=TestRemoveUserFromAccount>:setup | `Error` | 2.50 | test_accounts.py
ContextSuite context=TestUserAPIKeys>:setup | `Error` | 5.67 | test_accounts.py
test_updateUserDetails | `Error` | 0.15 | test_accounts.py
test_LoginApiDomain | `Error` | 1.26 | test_accounts.py
test_LoginApiUuidResponse | `Error` | 0.15 | test_accounts.py
ContextSuite context=TestDeployVmWithAffinityGroup>:setup | `Error` | 0.00 | test_affinity_groups.py
ContextSuite context=TestRVPCSite2SiteVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py
ContextSuite context=TestVPCSite2SiteVPNMultipleOptions>:setup | `Error` | 0.00 | test_vpc_vpn.py
ContextSuite context=TestVpcRemoteAccessVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py
ContextSuite context=TestVpcSite2SiteVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py
test_nic_secondaryip_add_remove | `Error` | 15.38 | test_multipleips_per_nic.py
ContextSuite context=TestDeployVmWithAffinityGroup>:setup | `Error` | 0.00 | test_affinity_groups_projects.py
ContextSuite context=TestCreateTemplateWithDirectDownload>:setup | `Error` | 16.87 | test_templates.py
ContextSuite context=TestTemplates>:setup | `Error` | 18.59 | test_templates.py
ContextSuite context=TestAnnotations>:setup | `Error` | 0.00 | test_annotations.py
test_01_import_storage_policies | `Error` | 0.17 | test_storage_policy.py
ContextSuite context=TestRemoteDiagnostics>:setup | `Error` | 0.00 | test_diagnostics.py
test_query_async_job_result | `Error` | 0.16 | test_async_job.py
ContextSuite context=TestNestedVirtualization>:setup | `Error` | 0.00 | test_nested_virtualization.py
ContextSuite context=TestDedicatePublicIPRange>:setup | `Error` | 0.00 | test_public_ip_range.py
ContextSuite context=TestAddConfigtoDeployVM>:setup | `Error` | 0.00 | test_deploy_vm_extra_config_data.py
ContextSuite context=TestCreateVolume>:setup | `Error` | 0.00 | test_volumes.py
ContextSuite context=TestVolumes>:setup | `Error` | 0.00 | test_volumes.py
test_01_add_primary_storage_disabled_host | `Error` | 32.14 | test_primary_storage.py
test_01_primary_storage_nfs | `Error` | 0.11 | test_primary_storage.py
ContextSuite context=TestStorageTags>:setup | `Error` | 0.19 | test_primary_storage.py
ContextSuite context=TestResourceDetail>:setup | `Error` | 0.00 | test_resource_detail.py
ContextSuite context=TestDeployVirtioSCSIVM>:setup | `Error` | 0.00 | test_deploy_virtio_scsi_vm.py
test_deploy_vm_from_iso | `Error` | 0.19 | test_deploy_vm_iso.py
test_default_role_deletion | `Error` | 0.18 | test_dynamicroles.py
test_role_account_acls | `Error` | 0.15 | test_dynamicroles.py
test_role_account_acls_multiple_mgmt_servers | `Error` | 0.15 | test_dynamicroles.py
test_role_inuse_deletion | `Error` | 0.16 | test_dynamicroles.py
test_role_lifecycle_clone | `Error` | 0.14 | test_dynamicroles.py
test_role_lifecycle_create | `Error` | 0.14 | test_dynamicroles.py
test_role_lifecycle_delete | `Error` | 0.14 | test_dynamicroles.py
test_role_lifecycle_import | `Error` | 0.14 | test_dynamicroles.py
test_role_lifecycle_list | `Error` | 0.19 | test_dynamicroles.py
test_role_lifecycle_update | `Error` | 0.18 | test_dynamicroles.py
test_role_lifecycle_update_role_inuse | `Error` | 0.18 | test_dynamicroles.py
test_rolepermission_lifecycle_concurrent_updates | `Error` | 0.16 | test_dynamicroles.py
test_rolepermission_lifecycle_create | `Error` | 0.25 | test_dynamicroles.py
test_rolepermission_lifecycle_delete | `Error` | 0.16 | test_dynamicroles.py
test_rolepermission_lifecycle_list | `Error` | 0.14 | test_dynamicroles.py
test_rolepermission_lifecycle_update | `Error` | 0.14 | test_dynamicroles.py
test_rolepermission_lifecycle_update_permission | `Error` | 0.14 | test_dynamicroles.py
test_rolepermission_lifecycle_update_permission_negative | `Error` | 0.17 | test_dynamicroles.py
login_test_saml_user | `Error` | 0.21 | test_login.py
ContextSuite context=TestDeployVmWithUserData>:setup | `Error` | 0.00 | test_deploy_vm_with_userdata.py
ContextSuite context=TestDeployVmWithVariedPlanners>:setup | `Error` | 0.00 | test_deploy_vms_with_varied_deploymentplanners.py
ContextSuite context=TestResetVmOnReboot>:setup | `Error` | 0.00 | test_reset_vm_on_reboot.py
test_01_create_delete_portforwarding_fornonvpc | `Error` | 0.17 | test_portforwardingrules.py
test_03_create_volume_domain_disk_offering | `Error` | 0.18 | test_domain_disk_offerings.py
test_03_create_network_domain_network_offering | `Error` | 0.18 | test_domain_network_offerings.py
test_03_deploy_vm_domain_service_offering | `Error` | 0.16 | test_domain_service_offerings.py
test_03_create_vpc_domain_vpc_offering | `Error` | 0.17 | test_domain_vpc_offerings.py
ContextSuite context=TestISOUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestLBRuleUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestNatRuleUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestPublicIPUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestSnapshotUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestVmUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestVolumeUsage>:setup | `Error` | 0.00 | test_usage.py
test_01_disable_account_settings_for_domain | `Error` | 0.23 | test_enable_account_settings_for_domain.py
test_02_enable_account_settings_for_domain | `Error` | 0.21 | test_enable_account_settings_for_domain.py
test_03_enable_account_settings_for_domain | `Error` | 0.22 | test_enable_account_settings_for_domain.py
test_add_account_to_project_with_project_role | `Error` | 2.40 | test_enable_role_based_users_in_projects.py
test_add_multiple_admins_in_project | `Error` | 2.40 | test_enable_role_based_users_in_projects.py
test_add_user_to_project_with_project_role | `Error` | 2.40 | test_enable_role_based_users_in_projects.py
ContextSuite context=TestDedicateGuestVlanRange>:setup | `Error` | 0.00 | test_guest_vlan_range.py
test_01_positive_tests_usage | `Error` | 0.15 | test_usage_events.py
ContextSuite context=TestRouterServices>:setup | `Error` | 0.00 | test_routers.py
ContextSuite context=TestVMDeploymentPlanner>:setup | `Error` | 0.00 | test_vm_deployment_planner.py
ContextSuite context=TestSnapshotRootDisk>:setup | `Error` | 0.00 | test_snapshots.py
ContextSuite context=TestInternalLb>:setup | `Error` | 0.00 | test_internal_lb.py
test_01_create_iso | `Error` | 0.19 | test_iso.py
ContextSuite context=TestISO>:setup | `Error` | 0.41 | test_iso.py
ContextSuite context=TestAdapterTypeForNic>:setup | `Error` | 0.00 | test_nic_adapter_type.py
ContextSuite context=TestKubernetesCluster>:setup | `Error` | 0.00 | test_kubernetes_clusters.py
ContextSuite context=TestListIdsParams>:setup | `Error` | 0.00 | test_list_ids_parameter.py
ContextSuite context=TestPublicIP>:setup | `Error` | 2.57 | test_network.py
ContextSuite context=TestDeployVM>:setup | `Error` | 0.00 | test_vm_life_cycle.py
ContextSuite context=TestKVMLiveMigration>:setup | `Error` | 0.00 | test_vm_life_cycle.py
ContextSuite context=TestMigrateVMwithVolume>:setup | `Error` | 0.00 | test_vm_life_cycle.py
ContextSuite context=TestSecuredVmMigration>:setup | `Error` | 0.00 | test_vm_life_cycle.py
ContextSuite context=TestUnmanageVM>:setup | `Error` | 0.00 | test_vm_life_cycle.py
ContextSuite context=TestVMLifeCycle>:setup | `Error` | 0.95 | test_vm_life_cycle.py
ContextSuite context=TestNetworkACL>:setup | `Error` | 0.00 | test_network_acl.py
test_01_nic | `Error` | 1.01 | test_nic.py
ContextSuite context=TestCpuCapServiceOfferings>:setup | `Error` | 0.00 | test_service_offerings.py
ContextSuite context=TestServiceOfferings>:setup | `Error` | 1.06 | test_service_offerings.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #5879: Role escalation prevention
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #5879:
URL: https://github.com/apache/cloudstack/pull/5879#issuecomment-1021443466
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5879: Role escalation prevention
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5879:
URL: https://github.com/apache/cloudstack/pull/5879#issuecomment-1021128987
@DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland removed a comment on pull request #5879: Role escalation prevention
Posted by GitBox <gi...@apache.org>.
DaanHoogland removed a comment on pull request #5879:
URL: https://github.com/apache/cloudstack/pull/5879#issuecomment-1021053219
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti removed a comment on pull request #5879: Role escalation prevention
Posted by GitBox <gi...@apache.org>.
sureshanaparti removed a comment on pull request #5879:
URL: https://github.com/apache/cloudstack/pull/5879#issuecomment-1025797642
@blueorangutan test keepEnv
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan removed a comment on pull request #5879: Role escalation prevention
Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #5879:
URL: https://github.com/apache/cloudstack/pull/5879#issuecomment-1018390483
@DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #5879: Role escalation prevention
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #5879:
URL: https://github.com/apache/cloudstack/pull/5879#issuecomment-1028061178
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5879: Role escalation prevention
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5879:
URL: https://github.com/apache/cloudstack/pull/5879#issuecomment-1033261423
<b>Trillian test result (tid-3252)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 25131 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5879-t3252-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_primary_storage.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #5879: Role escalation prevention
Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on pull request #5879:
URL: https://github.com/apache/cloudstack/pull/5879#issuecomment-1032892228
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on a change in pull request #5879: Role escalation prevention
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on a change in pull request #5879:
URL: https://github.com/apache/cloudstack/pull/5879#discussion_r803332881
##########
File path: plugins/acl/project-role-based/src/main/java/org/apache/cloudstack/acl/ProjectRoleBasedApiAccessChecker.java
##########
@@ -103,6 +103,11 @@ public boolean checkAccess(User user, String apiCommandName) throws PermissionDe
throw new UnavailableCommandException("The API " + apiCommandName + " does not exist or is not available for this account/user in project "+project.getUuid());
}
+ @Override
+ public boolean checkAccess(Account account, String apiCommandName) throws PermissionDeniedException {
+ return true;
Review comment:
This doesn't seem to affect the project roles feature.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti merged pull request #5879: Role escalation prevention
Posted by GitBox <gi...@apache.org>.
sureshanaparti merged pull request #5879:
URL: https://github.com/apache/cloudstack/pull/5879
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan removed a comment on pull request #5879: Role escalation prevention
Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #5879:
URL: https://github.com/apache/cloudstack/pull/5879#issuecomment-1026319768
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland removed a comment on pull request #5879: Role escalation prevention
Posted by GitBox <gi...@apache.org>.
DaanHoogland removed a comment on pull request #5879:
URL: https://github.com/apache/cloudstack/pull/5879#issuecomment-1025721204
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan removed a comment on pull request #5879: Role escalation prevention
Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #5879:
URL: https://github.com/apache/cloudstack/pull/5879#issuecomment-1031190321
@DaanHoogland unsupported parameters provided. Supported mgmt server os are: `suse15, centos7, centos6, alma8, ubuntu18, ubuntu20, rocky8`. Supported hypervisors are: `kvm-centos6, kvm-centos7, kvm-rocky8, kvm-alma8, kvm-ubuntu18, kvm-ubuntu20, kvm-suse15, vmware-55u3, vmware-60u2, vmware-65u2, vmware-67u3, vmware-70u1, vmware-70u2, vmware-70u3, xenserver-65sp1, xenserver-71, xenserver-74, xcpng74, xcpng76, xcpng80, xcpng81, xcpng82`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on a change in pull request #5879: Role escalation prevention
Posted by GitBox <gi...@apache.org>.
nvazquez commented on a change in pull request #5879:
URL: https://github.com/apache/cloudstack/pull/5879#discussion_r799454586
##########
File path: plugins/api/discovery/src/main/java/org/apache/cloudstack/discovery/ApiDiscoveryServiceImpl.java
##########
@@ -210,6 +211,24 @@ private ApiDiscoveryResponse getCmdRequestMap(Class<?> cmdClass, APICommand apiC
return response;
}
+ @Override
+ public List<String> listApiNames(Account account) {
+ List<String> apiNames = new ArrayList<>();
+ for (String apiName : s_apiNameDiscoveryResponseMap.keySet()) {
+ boolean isAllowed = true;
+ for (APIChecker apiChecker : _apiAccessCheckers) {
+ try {
+ apiChecker.checkAccess(account, apiName);
+ } catch (Exception ex) {
+ isAllowed = false;
Review comment:
I think we won't need this variable - after the checkAccess method we can add the element to the list and on the catch block we can log the exception describing the error. Then the next if won't be needed either
##########
File path: plugins/acl/project-role-based/src/main/java/org/apache/cloudstack/acl/ProjectRoleBasedApiAccessChecker.java
##########
@@ -58,9 +58,13 @@ private void denyApiAccess(final String commandName) throws PermissionDeniedExce
throw new PermissionDeniedException("The API " + commandName + " is denied for the user's/account's project role.");
}
+ @Override
+ public boolean isEnabled() {
+ return roleService.isEnabled();
+ }
public boolean isDisabled() {
Review comment:
Not an issue but an improvement request - can we leave only one of these methods?
##########
File path: server/src/main/java/com/cloud/user/AccountManagerImpl.java
##########
@@ -1110,6 +1183,75 @@ public UserAccount createUserAccount(final String userName, final String passwor
return _userAccountDao.findById(userId);
}
+ /**
+ * if there is any permission under the requested role that is not permitted for the caller, refuse
+ */
+ private void checkRoleEscalation(Account caller, Account requested) {
+ if (s_logger.isDebugEnabled()) {
+ s_logger.debug(String.format("checking if user of account %s [%s] with role-id [%d] can create an account of type %s [%s] with role-id [%d]",
+ caller.getAccountName(),
+ caller.getUuid(),
+ caller.getRoleId(),
+ requested.getAccountName(),
+ requested.getUuid(),
+ requested.getRoleId()));
+ }
+ List<APIChecker> apiCheckers = getEnabledApiCheckers();
+ for (String command : apiNameList) {
+ try {
+ checkApiAccess(apiCheckers, requested, command);
+ } catch (PermissionDeniedException pde) {
+ if (s_logger.isTraceEnabled()) {
+ s_logger.trace(String.format("checking for permission to \"%s\" is irrelevant as it is not requested for %s [%s]",
+ command,
+ pde.getAccount().getAccountName(),
+ pde.getAccount().getUuid(),
+ pde.getEntitiesInViolation()
+ ));
+ }
+ continue;
+ }
+ // so requested can, now make sure caller can as well
+ try {
+ if (s_logger.isTraceEnabled()) {
+ s_logger.trace(String.format("permission to \"%s\" is requested",
+ command));
+ }
+ checkApiAccess(apiCheckers, caller, command);
+ } catch (PermissionDeniedException pde) {
+ String msg = String.format("user of account %s/%s (%s) can not create an account with access to %s",
+ caller.getAccountName(),
+ caller.getDomainId(),
+ caller.getUuid(),
+ command);
+ s_logger.warn(msg);
+ throw new PermissionDeniedException(msg,pde);
+ }
+ }
+ }
+
+ private void checkApiAccess(List<APIChecker> apiCheckers, Account caller, String command) {
+ for (final APIChecker apiChecker : apiCheckers) {
+ apiChecker.checkAccess(caller, command);
+ }
+ }
+
+ @NotNull
+ private List<APIChecker> getEnabledApiCheckers() {
+ // we are really only interested in the dynamic access checker
+ List<APIChecker> usableApiCheckera = new ArrayList<>();
Review comment:
Typo?
##########
File path: server/src/main/java/com/cloud/user/AccountManagerImpl.java
##########
@@ -358,10 +391,46 @@ public UserVO getSystemUser() {
@Override
public boolean start() {
+ if (apiNameList == null) {
Review comment:
Could somehow the list be empty but not null at this point?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #5879: Role escalation prevention
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #5879:
URL: https://github.com/apache/cloudstack/pull/5879#issuecomment-1030027368
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5879: Role escalation prevention
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5879:
URL: https://github.com/apache/cloudstack/pull/5879#issuecomment-1032944361
@rohityadavcloud a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on a change in pull request #5879: Role escalation prevention
Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on a change in pull request #5879:
URL: https://github.com/apache/cloudstack/pull/5879#discussion_r789564879
##########
File path: server/src/main/java/com/cloud/user/AccountManagerImpl.java
##########
@@ -1110,6 +1183,39 @@ public UserAccount createUserAccount(final String userName, final String passwor
return _userAccountDao.findById(userId);
}
+ /**
+ * if there is any permission under the requested role that is not permitted for the caller, refuse
+ */
+ private void checkRoleEscalation(Account caller, Account requested) {
+ Long requestedRoleId = requested.getRoleId();
+ List<RolePermission> requestedPermissions = roleService.findAllPermissionsBy(requestedRoleId);
+ for (String command : apiNameList) {
Review comment:
Could there be a simpler fix, that is the caller is only allowed to select/pass roleids while creating account that is equal or lower than their own role; for example;
root admin -> can do anything
domain admin -> create domain/sub-domain admins and user-accounts
user accounts -> none
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #5879: Role escalation prevention
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #5879:
URL: https://github.com/apache/cloudstack/pull/5879#issuecomment-1021052572
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti removed a comment on pull request #5879: Role escalation prevention
Posted by GitBox <gi...@apache.org>.
sureshanaparti removed a comment on pull request #5879:
URL: https://github.com/apache/cloudstack/pull/5879#issuecomment-1027364298
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland removed a comment on pull request #5879: Role escalation prevention
Posted by GitBox <gi...@apache.org>.
DaanHoogland removed a comment on pull request #5879:
URL: https://github.com/apache/cloudstack/pull/5879#issuecomment-1021443466
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5879: Role escalation prevention
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5879:
URL: https://github.com/apache/cloudstack/pull/5879#issuecomment-1028330639
<b>Trillian test result (tid-3120)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 41560 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5879-t3120-kvm-centos7.zip
Smoke tests completed. 87 look OK, 5 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_add_primary_storage_disabled_host | `Error` | 0.58 | test_primary_storage.py
test_01_primary_storage_nfs | `Error` | 0.11 | test_primary_storage.py
ContextSuite context=TestStorageTags>:setup | `Error` | 0.19 | test_primary_storage.py
test_01_invalid_upgrade_kubernetes_cluster | `Failure` | 3603.88 | test_kubernetes_clusters.py
test_02_upgrade_kubernetes_cluster | `Failure` | 38.09 | test_kubernetes_clusters.py
test_03_deploy_and_scale_kubernetes_cluster | `Failure` | 39.95 | test_kubernetes_clusters.py
test_04_autoscale_kubernetes_cluster | `Failure` | 37.92 | test_kubernetes_clusters.py
test_05_basic_lifecycle_kubernetes_cluster | `Failure` | 37.96 | test_kubernetes_clusters.py
test_06_delete_kubernetes_cluster | `Failure` | 39.94 | test_kubernetes_clusters.py
test_07_deploy_kubernetes_ha_cluster | `Failure` | 0.05 | test_kubernetes_clusters.py
test_08_upgrade_kubernetes_ha_cluster | `Failure` | 0.04 | test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_cluster | `Failure` | 0.04 | test_kubernetes_clusters.py
ContextSuite context=TestKubernetesCluster>:teardown | `Error` | 125.02 | test_kubernetes_clusters.py
test_01_secure_vm_migration | `Error` | 146.09 | test_vm_life_cycle.py
test_02_unsecure_vm_migration | `Error` | 268.92 | test_vm_life_cycle.py
test_03_secured_to_nonsecured_vm_migration | `Error` | 143.79 | test_vm_life_cycle.py
test_08_migrate_vm | `Error` | 43.72 | test_vm_life_cycle.py
test_02_list_snapshots_with_removed_data_store | `Error` | 9.44 | test_snapshots.py
test_02_list_snapshots_with_removed_data_store | `Error` | 9.44 | test_snapshots.py
test_hostha_kvm_host_degraded | `Error` | 686.78 | test_hostha_kvm.py
test_hostha_kvm_host_fencing | `Error` | 687.47 | test_hostha_kvm.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #5879: Role escalation prevention
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on a change in pull request #5879:
URL: https://github.com/apache/cloudstack/pull/5879#discussion_r799485280
##########
File path: server/src/main/java/com/cloud/user/AccountManagerImpl.java
##########
@@ -358,10 +391,46 @@ public UserVO getSystemUser() {
@Override
public boolean start() {
+ if (apiNameList == null) {
Review comment:
no, the private apinamelist is not initialised till in this block and nowhere else.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #5879: Role escalation prevention
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #5879:
URL: https://github.com/apache/cloudstack/pull/5879#issuecomment-1034603310
> > @DaanHoogland one remark this doesn't fix/address if the issue already exists, we should update the doc (if not already done) to explain how roles work and precautions for non-admin roles that can create accounts.
>
> I don't agree, there is a doc PR out. Please comment there if there is anything missing.
@rohityadavcloud Doc PR here, https://github.com/apache/cloudstack-documentation/pull/260, please take a look and provide your feedback. @DaanHoogland can create a separate doc PR to include if any more details has to be added to the documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5879: Role escalation prevention
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5879:
URL: https://github.com/apache/cloudstack/pull/5879#issuecomment-1031341330
@sureshanaparti a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #5879: Role escalation prevention
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #5879:
URL: https://github.com/apache/cloudstack/pull/5879#issuecomment-1031340858
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5879: Role escalation prevention
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5879:
URL: https://github.com/apache/cloudstack/pull/5879#issuecomment-1032892531
@rohityadavcloud a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5879: Role escalation prevention
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5879:
URL: https://github.com/apache/cloudstack/pull/5879#issuecomment-1025773017
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 2405
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland removed a comment on pull request #5879: Role escalation prevention
Posted by GitBox <gi...@apache.org>.
DaanHoogland removed a comment on pull request #5879:
URL: https://github.com/apache/cloudstack/pull/5879#issuecomment-1016700250
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan removed a comment on pull request #5879: Role escalation prevention
Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #5879:
URL: https://github.com/apache/cloudstack/pull/5879#issuecomment-1025739506
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #5879: Role escalation prevention
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #5879:
URL: https://github.com/apache/cloudstack/pull/5879#issuecomment-1018389921
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #5879: Role escalation prevention
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on a change in pull request #5879:
URL: https://github.com/apache/cloudstack/pull/5879#discussion_r788794681
##########
File path: server/src/main/java/com/cloud/user/AccountManagerImpl.java
##########
@@ -1110,6 +1123,31 @@ public UserAccount createUserAccount(final String userName, final String passwor
return _userAccountDao.findById(userId);
}
+ /**
+ * if there is any permission under the requested role that is not permitted for the caller, refuse
+ */
+ private void checkRoleEscalation(Account caller, Long requestedRoleId) {
+ List<RolePermission> requestedPermissions = roleService.findAllPermissionsBy(requestedRoleId);
+
+ for (RolePermission permission : requestedPermissions) {
+ if (permission.getPermission() == Permission.ALLOW) {
+ String command = permission.getRule().getRuleString();
+ if (command.contains("*")) {
+ // find all api that match command and loop
+ checkApiAccess(caller, command);
+ } else {
+ checkApiAccess(caller, command);
+ }
Review comment:
:) it will be when done, still in progress @Pearl1594
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on a change in pull request #5879: Role escalation prevention
Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on a change in pull request #5879:
URL: https://github.com/apache/cloudstack/pull/5879#discussion_r789561622
##########
File path: server/src/main/java/com/cloud/user/AccountManagerImpl.java
##########
@@ -358,10 +391,46 @@ public UserVO getSystemUser() {
@Override
public boolean start() {
+ if (apiNameList == null) {
+ long startTime = System.nanoTime();
+ apiNameList = new ArrayList<String>();
+ Set<Class<?>> cmdClasses = new LinkedHashSet<Class<?>>();
+ for (PluggableService service : services) {
+ s_logger.debug(String.format("getting api commands of service: %s", service.getClass().getName()));
+ cmdClasses.addAll(service.getCommands());
+ }
+ apiNameList = createApiNameList(cmdClasses);
+ long endTime = System.nanoTime();
+ s_logger.info("Api Discovery Service: Annotation, docstrings, api relation graph processed in " + (endTime - startTime) / 1000000.0 + " ms");
+ }
_executor.scheduleAtFixedRate(new AccountCleanupTask(), _cleanupInterval, _cleanupInterval, TimeUnit.SECONDS);
return true;
}
+ protected List<String> createApiNameList(Set<Class<?>> cmdClasses) {
+ List<String> apiNameList = new ArrayList<String>();
+
+ for (Class<?> cmdClass : cmdClasses) {
Review comment:
Can we re-use parts of this from api discovery manager/service?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #5879: Role escalation prevention
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #5879:
URL: https://github.com/apache/cloudstack/pull/5879#issuecomment-1021052572
> Most / all test failures report the following error: `Execute cmd: createaccount failed, due to: errorCode: 531, errorText:user of account admin/1 (5af79319-7414-4df3-bffb-ec4ef9728066) can not create an account with access to notifyBaremetalProvisionDone\n']` and the `notifyBaremetalProvisionDone` is only allowed for an account having User role.
ok, that is not good: `description = "Notify provision has been done on a host. This api is for baremetal virtual router service, not for end user"`, it is hard-coded to be only allowed for the role user but is not allowed for normal users. Also I tested creating accounts as domain admin. I wonder why I didn't notice this one!?
I removed the restriction to RoleTupe.User, which should do the trick. If not I'll add all role types.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti removed a comment on pull request #5879: Role escalation prevention
Posted by GitBox <gi...@apache.org>.
sureshanaparti removed a comment on pull request #5879:
URL: https://github.com/apache/cloudstack/pull/5879#issuecomment-1019761870
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland removed a comment on pull request #5879: Role escalation prevention
Posted by GitBox <gi...@apache.org>.
DaanHoogland removed a comment on pull request #5879:
URL: https://github.com/apache/cloudstack/pull/5879#issuecomment-1019558888
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland removed a comment on pull request #5879: Role escalation prevention
Posted by GitBox <gi...@apache.org>.
DaanHoogland removed a comment on pull request #5879:
URL: https://github.com/apache/cloudstack/pull/5879#issuecomment-1018660087
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5879: Role escalation prevention
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5879:
URL: https://github.com/apache/cloudstack/pull/5879#issuecomment-1021171771
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 2296
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #5879: Role escalation prevention
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on a change in pull request #5879:
URL: https://github.com/apache/cloudstack/pull/5879#discussion_r792431321
##########
File path: server/src/main/java/com/cloud/user/AccountManagerImpl.java
##########
@@ -1110,6 +1183,39 @@ public UserAccount createUserAccount(final String userName, final String passwor
return _userAccountDao.findById(userId);
}
+ /**
+ * if there is any permission under the requested role that is not permitted for the caller, refuse
+ */
+ private void checkRoleEscalation(Account caller, Account requested) {
+ Long requestedRoleId = requested.getRoleId();
+ List<RolePermission> requestedPermissions = roleService.findAllPermissionsBy(requestedRoleId);
+ for (String command : apiNameList) {
Review comment:
that would not be taking into account dynamic roles. We want the caller not to be able to create an account with a role that has any permission that they don't have themselves, independent of the RoleType.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #5879: Role escalation prevention
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on a change in pull request #5879:
URL: https://github.com/apache/cloudstack/pull/5879#discussion_r788495263
##########
File path: server/src/main/java/com/cloud/user/AccountManagerImpl.java
##########
@@ -1054,6 +1064,9 @@ public UserAccount createUserAccount(final String userName, final String passwor
// Check permissions
checkAccess(getCurrentCallingAccount(), domain);
+// get user by account
Review comment:
```suggestion
// Check role escalation permission for the account
```
remove comment if not required
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #5879: Role escalation prevention
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on a change in pull request #5879:
URL: https://github.com/apache/cloudstack/pull/5879#discussion_r788795165
##########
File path: server/src/main/java/com/cloud/user/AccountManagerImpl.java
##########
@@ -1054,6 +1064,9 @@ public UserAccount createUserAccount(final String userName, final String passwor
// Check permissions
checkAccess(getCurrentCallingAccount(), domain);
+// get user by account
Review comment:
work in progress @sureshanaparti . I need to keep options open atm.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5879: Role escalation prevention
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5879:
URL: https://github.com/apache/cloudstack/pull/5879#issuecomment-1025799002
@sureshanaparti a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #5879: Role escalation prevention
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #5879:
URL: https://github.com/apache/cloudstack/pull/5879#issuecomment-1027364298
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland removed a comment on pull request #5879: Role escalation prevention
Posted by GitBox <gi...@apache.org>.
DaanHoogland removed a comment on pull request #5879:
URL: https://github.com/apache/cloudstack/pull/5879#issuecomment-1027696846
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland removed a comment on pull request #5879: Role escalation prevention
Posted by GitBox <gi...@apache.org>.
DaanHoogland removed a comment on pull request #5879:
URL: https://github.com/apache/cloudstack/pull/5879#issuecomment-1019558888
@blueorangutan test keepEnv
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5879: Role escalation prevention
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5879:
URL: https://github.com/apache/cloudstack/pull/5879#issuecomment-1021813645
<b>Trillian test result (tid-2993)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 31776 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5879-t2993-kvm-centos7.zip
Smoke tests completed. 92 look OK, 0 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #5879: Role escalation prevention
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #5879:
URL: https://github.com/apache/cloudstack/pull/5879#issuecomment-1030425118
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5879: Role escalation prevention
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5879:
URL: https://github.com/apache/cloudstack/pull/5879#issuecomment-1031190321
@DaanHoogland unsupported parameters provided. Supported mgmt server os are: `suse15, centos7, centos6, alma8, ubuntu18, ubuntu20, rocky8`. Supported hypervisors are: `kvm-centos6, kvm-centos7, kvm-rocky8, kvm-alma8, kvm-ubuntu18, kvm-ubuntu20, kvm-suse15, vmware-55u3, vmware-60u2, vmware-65u2, vmware-67u3, vmware-70u1, vmware-70u2, vmware-70u3, xenserver-65sp1, xenserver-71, xenserver-74, xcpng74, xcpng76, xcpng80, xcpng81, xcpng82`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #5879: Role escalation prevention
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on a change in pull request #5879:
URL: https://github.com/apache/cloudstack/pull/5879#discussion_r799478634
##########
File path: plugins/acl/project-role-based/src/main/java/org/apache/cloudstack/acl/ProjectRoleBasedApiAccessChecker.java
##########
@@ -58,9 +58,13 @@ private void denyApiAccess(final String commandName) throws PermissionDeniedExce
throw new PermissionDeniedException("The API " + commandName + " is denied for the user's/account's project role.");
}
+ @Override
+ public boolean isEnabled() {
+ return roleService.isEnabled();
+ }
public boolean isDisabled() {
Review comment:
both are used, so no ;)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5879: Role escalation prevention
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5879:
URL: https://github.com/apache/cloudstack/pull/5879#issuecomment-1030587365
<b>Trillian test result (tid-3172)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 34552 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5879-t3172-kvm-centos7.zip
Smoke tests completed. 91 look OK, 1 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Failure` | 314.04 | test_vpc_redundant.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5879: Role escalation prevention
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5879:
URL: https://github.com/apache/cloudstack/pull/5879#issuecomment-1031156287
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_multiplication_x: debian :heavy_check_mark: suse15. SL-JID 2483
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #5879: Role escalation prevention
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #5879:
URL: https://github.com/apache/cloudstack/pull/5879#issuecomment-1027696846
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti removed a comment on pull request #5879: Role escalation prevention
Posted by GitBox <gi...@apache.org>.
sureshanaparti removed a comment on pull request #5879:
URL: https://github.com/apache/cloudstack/pull/5879#issuecomment-1017229611
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland removed a comment on pull request #5879: Role escalation prevention
Posted by GitBox <gi...@apache.org>.
DaanHoogland removed a comment on pull request #5879:
URL: https://github.com/apache/cloudstack/pull/5879#issuecomment-1018389921
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #5879: Role escalation prevention
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #5879:
URL: https://github.com/apache/cloudstack/pull/5879#issuecomment-1029842606
@rohityadavcloud , It needs a second review (I think @sureshanaparti tested)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan removed a comment on pull request #5879: Role escalation prevention
Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #5879:
URL: https://github.com/apache/cloudstack/pull/5879#issuecomment-1018886408
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #5879: Role escalation prevention
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #5879:
URL: https://github.com/apache/cloudstack/pull/5879#issuecomment-1019761870
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5879: Role escalation prevention
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5879:
URL: https://github.com/apache/cloudstack/pull/5879#issuecomment-1025739506
@DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #5879: Role escalation prevention
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #5879:
URL: https://github.com/apache/cloudstack/pull/5879#issuecomment-1025721204
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #5879: Role escalation prevention
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on a change in pull request #5879:
URL: https://github.com/apache/cloudstack/pull/5879#discussion_r799449368
##########
File path: server/src/main/java/com/cloud/user/AccountManagerImpl.java
##########
@@ -1110,6 +1183,75 @@ public UserAccount createUserAccount(final String userName, final String passwor
return _userAccountDao.findById(userId);
}
+ /**
+ * if there is any permission under the requested role that is not permitted for the caller, refuse
+ */
+ private void checkRoleEscalation(Account caller, Account requested) {
+ if (s_logger.isDebugEnabled()) {
+ s_logger.debug(String.format("checking if user of account %s [%s] with role-id [%d] can create an account of type %s [%s] with role-id [%d]",
+ caller.getAccountName(),
+ caller.getUuid(),
+ caller.getRoleId(),
+ requested.getAccountName(),
+ requested.getUuid(),
+ requested.getRoleId()));
+ }
+ List<APIChecker> apiCheckers = getEnabledApiCheckers();
+ for (String command : apiNameList) {
+ try {
+ checkApiAccess(apiCheckers, requested, command);
+ } catch (PermissionDeniedException pde) {
+ if (s_logger.isTraceEnabled()) {
+ s_logger.trace(String.format("checking for permission to \"%s\" is irrelevant as it is not requested for %s [%s]",
+ command,
+ pde.getAccount().getAccountName(),
+ pde.getAccount().getUuid(),
+ pde.getEntitiesInViolation()
+ ));
+ }
+ continue;
+ }
+ // so requested can, now make sure caller can as well
+ try {
+ if (s_logger.isTraceEnabled()) {
+ s_logger.trace(String.format("permission to \"%s\" is requested",
+ command));
+ }
+ checkApiAccess(apiCheckers, caller, command);
+ } catch (PermissionDeniedException pde) {
+ String msg = String.format("user of account %s/%s (%s) can not create an account with access to %s",
Review comment:
@DaanHoogland Update the message as appropriate (do not include any API name which the user doesn't have access to)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #5879: Role escalation prevention
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on a change in pull request #5879:
URL: https://github.com/apache/cloudstack/pull/5879#discussion_r799479664
##########
File path: server/src/main/java/com/cloud/user/AccountManagerImpl.java
##########
@@ -1110,6 +1183,75 @@ public UserAccount createUserAccount(final String userName, final String passwor
return _userAccountDao.findById(userId);
}
+ /**
+ * if there is any permission under the requested role that is not permitted for the caller, refuse
+ */
+ private void checkRoleEscalation(Account caller, Account requested) {
+ if (s_logger.isDebugEnabled()) {
+ s_logger.debug(String.format("checking if user of account %s [%s] with role-id [%d] can create an account of type %s [%s] with role-id [%d]",
+ caller.getAccountName(),
+ caller.getUuid(),
+ caller.getRoleId(),
+ requested.getAccountName(),
+ requested.getUuid(),
+ requested.getRoleId()));
+ }
+ List<APIChecker> apiCheckers = getEnabledApiCheckers();
+ for (String command : apiNameList) {
+ try {
+ checkApiAccess(apiCheckers, requested, command);
+ } catch (PermissionDeniedException pde) {
+ if (s_logger.isTraceEnabled()) {
+ s_logger.trace(String.format("checking for permission to \"%s\" is irrelevant as it is not requested for %s [%s]",
+ command,
+ pde.getAccount().getAccountName(),
+ pde.getAccount().getUuid(),
+ pde.getEntitiesInViolation()
+ ));
+ }
+ continue;
+ }
+ // so requested can, now make sure caller can as well
+ try {
+ if (s_logger.isTraceEnabled()) {
+ s_logger.trace(String.format("permission to \"%s\" is requested",
+ command));
+ }
+ checkApiAccess(apiCheckers, caller, command);
+ } catch (PermissionDeniedException pde) {
+ String msg = String.format("user of account %s/%s (%s) can not create an account with access to %s",
+ caller.getAccountName(),
+ caller.getDomainId(),
+ caller.getUuid(),
+ command);
+ s_logger.warn(msg);
+ throw new PermissionDeniedException(msg,pde);
+ }
+ }
+ }
+
+ private void checkApiAccess(List<APIChecker> apiCheckers, Account caller, String command) {
+ for (final APIChecker apiChecker : apiCheckers) {
+ apiChecker.checkAccess(caller, command);
+ }
+ }
+
+ @NotNull
+ private List<APIChecker> getEnabledApiCheckers() {
+ // we are really only interested in the dynamic access checker
+ List<APIChecker> usableApiCheckera = new ArrayList<>();
Review comment:
yes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #5879: Role escalation prevention
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #5879:
URL: https://github.com/apache/cloudstack/pull/5879#issuecomment-1033948678
> Do we need this re-test
>
> > @sureshanaparti a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
>
> I think the one before showed no errors and we didn't re-build in between.
couldn't see the results here, let's wait for test results.
https://github.com/apache/cloudstack/pull/5879#issuecomment-1033261423
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5879: Role escalation prevention
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5879:
URL: https://github.com/apache/cloudstack/pull/5879#issuecomment-1034173194
<b>Trillian test result (tid-3264)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 30453 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5879-t3264-kvm-centos7.zip
Smoke tests completed. 92 look OK, 0 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on a change in pull request #5879: Role escalation prevention
Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on a change in pull request #5879:
URL: https://github.com/apache/cloudstack/pull/5879#discussion_r789559680
##########
File path: plugins/acl/project-role-based/src/main/java/org/apache/cloudstack/acl/ProjectRoleBasedApiAccessChecker.java
##########
@@ -103,6 +103,11 @@ public boolean checkAccess(User user, String apiCommandName) throws PermissionDe
throw new UnavailableCommandException("The API " + apiCommandName + " does not exist or is not available for this account/user in project "+project.getUuid());
}
+ @Override
+ public boolean checkAccess(Account account, String apiCommandName) throws PermissionDeniedException {
+ return true;
Review comment:
Could this cause any issue, cc @Pearl1594 ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #5879: Role escalation prevention
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on a change in pull request #5879:
URL: https://github.com/apache/cloudstack/pull/5879#discussion_r792481257
##########
File path: server/src/main/java/com/cloud/user/AccountManagerImpl.java
##########
@@ -358,10 +391,46 @@ public UserVO getSystemUser() {
@Override
public boolean start() {
+ if (apiNameList == null) {
+ long startTime = System.nanoTime();
+ apiNameList = new ArrayList<String>();
+ Set<Class<?>> cmdClasses = new LinkedHashSet<Class<?>>();
+ for (PluggableService service : services) {
Review comment:
No, we need the full API list by name, the plugable service hold class references, which is overkill for us at this moment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5879: Role escalation prevention
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5879:
URL: https://github.com/apache/cloudstack/pull/5879#issuecomment-1027697615
@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #5879: Role escalation prevention
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #5879:
URL: https://github.com/apache/cloudstack/pull/5879#issuecomment-1027920218
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5879: Role escalation prevention
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5879:
URL: https://github.com/apache/cloudstack/pull/5879#issuecomment-1028062242
@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #5879: Role escalation prevention
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on a change in pull request #5879:
URL: https://github.com/apache/cloudstack/pull/5879#discussion_r803334008
##########
File path: plugins/acl/project-role-based/src/main/java/org/apache/cloudstack/acl/ProjectRoleBasedApiAccessChecker.java
##########
@@ -103,6 +103,11 @@ public boolean checkAccess(User user, String apiCommandName) throws PermissionDe
throw new UnavailableCommandException("The API " + apiCommandName + " does not exist or is not available for this account/user in project "+project.getUuid());
}
+ @Override
+ public boolean checkAccess(Account account, String apiCommandName) throws PermissionDeniedException {
+ return true;
Review comment:
thanks for confirming this @Pearl1594
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5879: Role escalation prevention
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5879:
URL: https://github.com/apache/cloudstack/pull/5879#issuecomment-1032926727
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 2532
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #5879: Role escalation prevention
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #5879:
URL: https://github.com/apache/cloudstack/pull/5879#issuecomment-1030118544
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #5879: Role escalation prevention
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #5879:
URL: https://github.com/apache/cloudstack/pull/5879#issuecomment-1031189550
> cc @sureshanaparti probably need to investigate why deb builds are failing @blueorangutan test
three days ago deb builds didn't fail. I think it is a environmental fluke,
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5879: Role escalation prevention
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5879:
URL: https://github.com/apache/cloudstack/pull/5879#issuecomment-1031112643
@rohityadavcloud a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #5879: Role escalation prevention
Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on pull request #5879:
URL: https://github.com/apache/cloudstack/pull/5879#issuecomment-1034577565
@DaanHoogland one remark this doesn't fix/address if the issue already exists, we should update the doc (if not already done) to explain how roles work and precautions for non-admin roles that can create accounts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #5879: Role escalation prevention
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #5879:
URL: https://github.com/apache/cloudstack/pull/5879#issuecomment-1033677748
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #5879: Role escalation prevention
Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on pull request #5879:
URL: https://github.com/apache/cloudstack/pull/5879#issuecomment-1031111888
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5879: Role escalation prevention
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5879:
URL: https://github.com/apache/cloudstack/pull/5879#issuecomment-1030027650
@DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #5879: Role escalation prevention
Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on pull request #5879:
URL: https://github.com/apache/cloudstack/pull/5879#issuecomment-1031159747
cc @sureshanaparti probably need to investigate why deb builds are failing
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #5879: Role escalation prevention
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #5879:
URL: https://github.com/apache/cloudstack/pull/5879#issuecomment-1025738080
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #5879: Role escalation prevention
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on a change in pull request #5879:
URL: https://github.com/apache/cloudstack/pull/5879#discussion_r792433049
##########
File path: api/src/test/java/org/apache/cloudstack/api/command/admin/account/CreateAccountCmdTest.java
##########
@@ -73,7 +73,7 @@ public void testExecuteWithNotBlankPassword() {
} catch (ServerApiException e) {
Assert.assertTrue("Received exception as the mock accountService createUserAccount returns null user", true);
}
- Mockito.verify(accountService, Mockito.times(1)).createUserAccount(null, "Test", null, null, null, null, null, accountType, roleId, domainId, null, null, null, null);
+ Mockito.verify(accountService, Mockito.times(1)).createUserAccount(createAccountCmd);
Review comment:
makes sense, will do
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #5879: Role escalation prevention
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on a change in pull request #5879:
URL: https://github.com/apache/cloudstack/pull/5879#discussion_r792432740
##########
File path: server/src/main/java/com/cloud/user/AccountManagerImpl.java
##########
@@ -358,10 +391,46 @@ public UserVO getSystemUser() {
@Override
public boolean start() {
+ if (apiNameList == null) {
+ long startTime = System.nanoTime();
+ apiNameList = new ArrayList<String>();
+ Set<Class<?>> cmdClasses = new LinkedHashSet<Class<?>>();
+ for (PluggableService service : services) {
Review comment:
this implementation is cleverly stolen. I'll have a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #5879: Role escalation prevention
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on a change in pull request #5879:
URL: https://github.com/apache/cloudstack/pull/5879#discussion_r792479516
##########
File path: api/src/test/java/org/apache/cloudstack/api/command/admin/account/CreateAccountCmdTest.java
##########
@@ -73,7 +73,7 @@ public void testExecuteWithNotBlankPassword() {
} catch (ServerApiException e) {
Assert.assertTrue("Received exception as the mock accountService createUserAccount returns null user", true);
}
- Mockito.verify(accountService, Mockito.times(1)).createUserAccount(null, "Test", null, null, null, null, null, accountType, roleId, domainId, null, null, null, null);
+ Mockito.verify(accountService, Mockito.times(1)).createUserAccount(createAccountCmd);
Review comment:
It actually doesn't matter for this flimsy test case. We are only verifying that the command is passed to the service, not the handling of it in the service. The service is a mock.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan removed a comment on pull request #5879: Role escalation prevention
Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #5879:
URL: https://github.com/apache/cloudstack/pull/5879#issuecomment-1027697615
@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan removed a comment on pull request #5879: Role escalation prevention
Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #5879:
URL: https://github.com/apache/cloudstack/pull/5879#issuecomment-1021067980
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #5879: Role escalation prevention
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #5879:
URL: https://github.com/apache/cloudstack/pull/5879#issuecomment-1021128421
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5879: Role escalation prevention
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5879:
URL: https://github.com/apache/cloudstack/pull/5879#issuecomment-1028532486
<b>Trillian test result (tid-3125)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 36297 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5879-t3125-kvm-centos7.zip
Smoke tests completed. 90 look OK, 0 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland removed a comment on pull request #5879: Role escalation prevention
Posted by GitBox <gi...@apache.org>.
DaanHoogland removed a comment on pull request #5879:
URL: https://github.com/apache/cloudstack/pull/5879#issuecomment-1026704809
@blueorangutan test keepEnv
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #5879: Role escalation prevention
Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on pull request #5879:
URL: https://github.com/apache/cloudstack/pull/5879#issuecomment-1029764198
ping @DaanHoogland @sureshanaparti @nvazquez - is this ready to go or need a set of thorough testing and review?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan removed a comment on pull request #5879: Role escalation prevention
Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #5879:
URL: https://github.com/apache/cloudstack/pull/5879#issuecomment-1017230972
@sureshanaparti a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5879: Role escalation prevention
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5879:
URL: https://github.com/apache/cloudstack/pull/5879#issuecomment-1018390483
@DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan removed a comment on pull request #5879: Role escalation prevention
Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #5879:
URL: https://github.com/apache/cloudstack/pull/5879#issuecomment-1017272816
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 2261
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on a change in pull request #5879: Role escalation prevention
Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on a change in pull request #5879:
URL: https://github.com/apache/cloudstack/pull/5879#discussion_r789561279
##########
File path: server/src/main/java/com/cloud/user/AccountManagerImpl.java
##########
@@ -358,10 +391,46 @@ public UserVO getSystemUser() {
@Override
public boolean start() {
+ if (apiNameList == null) {
+ long startTime = System.nanoTime();
+ apiNameList = new ArrayList<String>();
+ Set<Class<?>> cmdClasses = new LinkedHashSet<Class<?>>();
+ for (PluggableService service : services) {
Review comment:
Should we only get api name list from the configured pluggable service (the dynamic or static manager?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on a change in pull request #5879: Role escalation prevention
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on a change in pull request #5879:
URL: https://github.com/apache/cloudstack/pull/5879#discussion_r788512234
##########
File path: server/src/main/java/com/cloud/user/AccountManagerImpl.java
##########
@@ -1110,6 +1123,31 @@ public UserAccount createUserAccount(final String userName, final String passwor
return _userAccountDao.findById(userId);
}
+ /**
+ * if there is any permission under the requested role that is not permitted for the caller, refuse
+ */
+ private void checkRoleEscalation(Account caller, Long requestedRoleId) {
+ List<RolePermission> requestedPermissions = roleService.findAllPermissionsBy(requestedRoleId);
+
+ for (RolePermission permission : requestedPermissions) {
+ if (permission.getPermission() == Permission.ALLOW) {
+ String command = permission.getRule().getRuleString();
+ if (command.contains("*")) {
+ // find all api that match command and loop
+ checkApiAccess(caller, command);
+ } else {
+ checkApiAccess(caller, command);
+ }
Review comment:
maybe this if-else clause isn't required?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5879: Role escalation prevention
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5879:
URL: https://github.com/apache/cloudstack/pull/5879#issuecomment-1019627883
<b>Trillian test result (tid-2946)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 16908 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5879-t2946-kvm-centos7.zip
Smoke tests completed. 44 look OK, 48 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
ContextSuite context=TestPortablePublicIPAcquire>:setup | `Error` | 0.00 | test_portable_publicip.py
ContextSuite context=TestPortablePublicIPRange>:setup | `Error` | 0.00 | test_portable_publicip.py
ContextSuite context=TestVmSnapshot>:setup | `Error` | 1.02 | test_vm_snapshots.py
test_01_create_account | `Error` | 0.83 | test_accounts.py
test_02_update_account | `Error` | 0.88 | test_accounts.py
test_DeleteDomain | `Error` | 1.93 | test_accounts.py
test_forceDeleteDomain | `Error` | 1.95 | test_accounts.py
test_move_user_incorrect_account_id | `Error` | 0.84 | test_accounts.py
test_move_user_incorrect_account_name | `Error` | 0.83 | test_accounts.py
test_move_user_to_accountID | `Error` | 0.82 | test_accounts.py
test_move_user_to_account_name | `Error` | 0.84 | test_accounts.py
test_move_user_to_different_domain | `Error` | 0.84 | test_accounts.py
test_01_non_root_admin_Privileges | `Error` | 0.81 | test_accounts.py
ContextSuite context=TestRemoveUserFromAccount>:setup | `Error` | 3.78 | test_accounts.py
ContextSuite context=TestUserAPIKeys>:setup | `Error` | 6.28 | test_accounts.py
test_updateUserDetails | `Error` | 0.90 | test_accounts.py
test_LoginApiDomain | `Error` | 1.93 | test_accounts.py
test_LoginApiUuidResponse | `Error` | 0.83 | test_accounts.py
ContextSuite context=TestDeployVmWithAffinityGroup>:setup | `Error` | 0.00 | test_affinity_groups.py
ContextSuite context=TestRVPCSite2SiteVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py
ContextSuite context=TestVPCSite2SiteVPNMultipleOptions>:setup | `Error` | 0.00 | test_vpc_vpn.py
ContextSuite context=TestVpcRemoteAccessVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py
ContextSuite context=TestVpcSite2SiteVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py
test_nic_secondaryip_add_remove | `Error` | 16.09 | test_multipleips_per_nic.py
ContextSuite context=TestDeployVmWithAffinityGroup>:setup | `Error` | 0.00 | test_affinity_groups_projects.py
ContextSuite context=TestCreateTemplateWithDirectDownload>:setup | `Error` | 17.48 | test_templates.py
ContextSuite context=TestTemplates>:setup | `Error` | 19.88 | test_templates.py
ContextSuite context=TestAnnotations>:setup | `Error` | 0.00 | test_annotations.py
test_01_import_storage_policies | `Error` | 0.89 | test_storage_policy.py
ContextSuite context=TestRemoteDiagnostics>:setup | `Error` | 0.00 | test_diagnostics.py
test_query_async_job_result | `Error` | 0.85 | test_async_job.py
ContextSuite context=TestNestedVirtualization>:setup | `Error` | 0.00 | test_nested_virtualization.py
ContextSuite context=TestDedicatePublicIPRange>:setup | `Error` | 0.00 | test_public_ip_range.py
ContextSuite context=TestAddConfigtoDeployVM>:setup | `Error` | 0.00 | test_deploy_vm_extra_config_data.py
ContextSuite context=TestCreateVolume>:setup | `Error` | 0.00 | test_volumes.py
ContextSuite context=TestVolumes>:setup | `Error` | 0.00 | test_volumes.py
test_01_add_primary_storage_disabled_host | `Error` | 32.78 | test_primary_storage.py
test_01_primary_storage_nfs | `Error` | 0.11 | test_primary_storage.py
ContextSuite context=TestStorageTags>:setup | `Error` | 0.19 | test_primary_storage.py
ContextSuite context=TestResourceDetail>:setup | `Error` | 0.00 | test_resource_detail.py
ContextSuite context=TestDeployVirtioSCSIVM>:setup | `Error` | 0.00 | test_deploy_virtio_scsi_vm.py
test_deploy_vm_from_iso | `Error` | 0.84 | test_deploy_vm_iso.py
test_default_role_deletion | `Error` | 0.43 | test_dynamicroles.py
test_role_account_acls | `Error` | 0.40 | test_dynamicroles.py
test_role_account_acls_multiple_mgmt_servers | `Error` | 0.39 | test_dynamicroles.py
test_role_inuse_deletion | `Error` | 0.41 | test_dynamicroles.py
test_role_lifecycle_clone | `Error` | 0.37 | test_dynamicroles.py
test_role_lifecycle_create | `Error` | 0.37 | test_dynamicroles.py
test_role_lifecycle_delete | `Error` | 0.38 | test_dynamicroles.py
test_role_lifecycle_import | `Error` | 0.40 | test_dynamicroles.py
test_role_lifecycle_list | `Error` | 0.35 | test_dynamicroles.py
test_role_lifecycle_update | `Error` | 0.47 | test_dynamicroles.py
test_role_lifecycle_update_role_inuse | `Error` | 0.46 | test_dynamicroles.py
test_rolepermission_lifecycle_concurrent_updates | `Error` | 0.37 | test_dynamicroles.py
test_rolepermission_lifecycle_create | `Error` | 0.38 | test_dynamicroles.py
test_rolepermission_lifecycle_delete | `Error` | 0.40 | test_dynamicroles.py
test_rolepermission_lifecycle_list | `Error` | 0.40 | test_dynamicroles.py
test_rolepermission_lifecycle_update | `Error` | 0.38 | test_dynamicroles.py
test_rolepermission_lifecycle_update_permission | `Error` | 0.38 | test_dynamicroles.py
test_rolepermission_lifecycle_update_permission_negative | `Error` | 0.39 | test_dynamicroles.py
login_test_saml_user | `Error` | 0.84 | test_login.py
ContextSuite context=TestDeployVmWithUserData>:setup | `Error` | 0.00 | test_deploy_vm_with_userdata.py
ContextSuite context=TestDeployVmWithVariedPlanners>:setup | `Error` | 0.00 | test_deploy_vms_with_varied_deploymentplanners.py
ContextSuite context=TestResetVmOnReboot>:setup | `Error` | 0.00 | test_reset_vm_on_reboot.py
test_01_create_delete_portforwarding_fornonvpc | `Error` | 0.83 | test_portforwardingrules.py
test_03_create_volume_domain_disk_offering | `Error` | 0.86 | test_domain_disk_offerings.py
test_03_create_network_domain_network_offering | `Error` | 0.86 | test_domain_network_offerings.py
test_03_deploy_vm_domain_service_offering | `Error` | 0.87 | test_domain_service_offerings.py
test_03_create_vpc_domain_vpc_offering | `Error` | 0.84 | test_domain_vpc_offerings.py
ContextSuite context=TestISOUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestLBRuleUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestNatRuleUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestPublicIPUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestSnapshotUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestVmUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestVolumeUsage>:setup | `Error` | 0.00 | test_usage.py
test_01_disable_account_settings_for_domain | `Error` | 0.91 | test_enable_account_settings_for_domain.py
test_02_enable_account_settings_for_domain | `Error` | 0.90 | test_enable_account_settings_for_domain.py
test_03_enable_account_settings_for_domain | `Error` | 0.91 | test_enable_account_settings_for_domain.py
test_add_account_to_project_with_project_role | `Error` | 3.06 | test_enable_role_based_users_in_projects.py
test_add_multiple_admins_in_project | `Error` | 3.08 | test_enable_role_based_users_in_projects.py
test_add_user_to_project_with_project_role | `Error` | 3.12 | test_enable_role_based_users_in_projects.py
ContextSuite context=TestDedicateGuestVlanRange>:setup | `Error` | 0.00 | test_guest_vlan_range.py
test_01_positive_tests_usage | `Error` | 0.85 | test_usage_events.py
ContextSuite context=TestRouterServices>:setup | `Error` | 0.00 | test_routers.py
ContextSuite context=TestVMDeploymentPlanner>:setup | `Error` | 0.00 | test_vm_deployment_planner.py
ContextSuite context=TestSnapshotRootDisk>:setup | `Error` | 0.00 | test_snapshots.py
ContextSuite context=TestInternalLb>:setup | `Error` | 0.00 | test_internal_lb.py
test_01_create_iso | `Error` | 0.93 | test_iso.py
ContextSuite context=TestISO>:setup | `Error` | 1.85 | test_iso.py
ContextSuite context=TestAdapterTypeForNic>:setup | `Error` | 0.00 | test_nic_adapter_type.py
ContextSuite context=TestKubernetesCluster>:setup | `Error` | 0.00 | test_kubernetes_clusters.py
ContextSuite context=TestListIdsParams>:setup | `Error` | 0.00 | test_list_ids_parameter.py
ContextSuite context=TestPublicIP>:setup | `Error` | 2.33 | test_network.py
ContextSuite context=TestDeployVM>:setup | `Error` | 0.00 | test_vm_life_cycle.py
ContextSuite context=TestKVMLiveMigration>:setup | `Error` | 0.00 | test_vm_life_cycle.py
ContextSuite context=TestMigrateVMwithVolume>:setup | `Error` | 0.00 | test_vm_life_cycle.py
ContextSuite context=TestSecuredVmMigration>:setup | `Error` | 0.00 | test_vm_life_cycle.py
ContextSuite context=TestUnmanageVM>:setup | `Error` | 0.00 | test_vm_life_cycle.py
ContextSuite context=TestVMLifeCycle>:setup | `Error` | 0.87 | test_vm_life_cycle.py
ContextSuite context=TestNetworkACL>:setup | `Error` | 0.00 | test_network_acl.py
test_01_nic | `Error` | 0.88 | test_nic.py
ContextSuite context=TestCpuCapServiceOfferings>:setup | `Error` | 0.00 | test_service_offerings.py
ContextSuite context=TestServiceOfferings>:setup | `Error` | 0.96 | test_service_offerings.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5879: Role escalation prevention
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5879:
URL: https://github.com/apache/cloudstack/pull/5879#issuecomment-1019763756
<b>Trillian Build Failed (tid-2952)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #5879: Role escalation prevention
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #5879:
URL: https://github.com/apache/cloudstack/pull/5879#issuecomment-1019766932
Most / all test failures report the following error: `Execute cmd: createaccount failed, due to: errorCode: 531, errorText:user of account admin/1 (5af79319-7414-4df3-bffb-ec4ef9728066) can not create an account with access to notifyBaremetalProvisionDone\n']` and the `notifyBaremetalProvisionDone` is only allowed for an account having User role.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5879: Role escalation prevention
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5879:
URL: https://github.com/apache/cloudstack/pull/5879#issuecomment-1021067980
Packaging result: :heavy_multiplication_x: el7 :heavy_multiplication_x: el8 :heavy_multiplication_x: debian :heavy_multiplication_x: suse15. SL-JID 2295
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5879: Role escalation prevention
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5879:
URL: https://github.com/apache/cloudstack/pull/5879#issuecomment-1030118977
@DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #5879: Role escalation prevention
Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on pull request #5879:
URL: https://github.com/apache/cloudstack/pull/5879#issuecomment-1032943698
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #5879: Role escalation prevention
Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on pull request #5879:
URL: https://github.com/apache/cloudstack/pull/5879#issuecomment-1032382140
@sureshanaparti I'll review the code changes but not able to test it. Pl ask @borisstoyanov @vladimirpetrov or one of the 4.16.1 team.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #5879: Role escalation prevention
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #5879:
URL: https://github.com/apache/cloudstack/pull/5879#issuecomment-1032507781
> @sureshanaparti I'll review the code changes but not able to test it. Pl ask @borisstoyanov @vladimirpetrov or one of the 4.16.1 team.
sure @rohityadavcloud , please review the changes. thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #5879: Role escalation prevention
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #5879:
URL: https://github.com/apache/cloudstack/pull/5879#issuecomment-1034597507
> @DaanHoogland one remark this doesn't fix/address if the issue already exists, we should update the doc (if not already done) to explain how roles work and precautions for non-admin roles that can create accounts.
I don't agree, there is a doc PR out. Please comment there if there is anything missing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #5879: Role escalation prevention
Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on pull request #5879:
URL: https://github.com/apache/cloudstack/pull/5879#issuecomment-1034612805
Cool thanks for the link @sureshanaparti @DaanHoogland - as I said my remark was only if you've not already done the doc PR - which you've.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #5879: Role escalation prevention
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #5879:
URL: https://github.com/apache/cloudstack/pull/5879#issuecomment-1033941189
Do we need this re-test
> @sureshanaparti a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
I think the one before showed no errors and we didn't re-build in between.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti removed a comment on pull request #5879: Role escalation prevention
Posted by GitBox <gi...@apache.org>.
sureshanaparti removed a comment on pull request #5879:
URL: https://github.com/apache/cloudstack/pull/5879#issuecomment-1019761870
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan removed a comment on pull request #5879: Role escalation prevention
Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #5879:
URL: https://github.com/apache/cloudstack/pull/5879#issuecomment-1026705210
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland removed a comment on pull request #5879: Role escalation prevention
Posted by GitBox <gi...@apache.org>.
DaanHoogland removed a comment on pull request #5879:
URL: https://github.com/apache/cloudstack/pull/5879#issuecomment-1021128421
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5879: Role escalation prevention
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5879:
URL: https://github.com/apache/cloudstack/pull/5879#issuecomment-1026319768
<b>Trillian test result (tid-3080)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 31158 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5879-t3080-kvm-centos7.zip
Smoke tests completed. 85 look OK, 7 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_invalid_upgrade_kubernetes_cluster | `Failure` | 4.45 | test_kubernetes_clusters.py
test_02_upgrade_kubernetes_cluster | `Failure` | 4.26 | test_kubernetes_clusters.py
test_03_deploy_and_scale_kubernetes_cluster | `Failure` | 3.28 | test_kubernetes_clusters.py
test_04_autoscale_kubernetes_cluster | `Failure` | 4.27 | test_kubernetes_clusters.py
test_05_basic_lifecycle_kubernetes_cluster | `Failure` | 4.25 | test_kubernetes_clusters.py
test_06_delete_kubernetes_cluster | `Failure` | 4.27 | test_kubernetes_clusters.py
test_07_deploy_kubernetes_ha_cluster | `Failure` | 3.26 | test_kubernetes_clusters.py
test_08_upgrade_kubernetes_ha_cluster | `Failure` | 4.29 | test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_cluster | `Failure` | 4.25 | test_kubernetes_clusters.py
ContextSuite context=TestKubernetesCluster>:teardown | `Error` | 64.37 | test_kubernetes_clusters.py
test_01_native_to_native_network_migration | `Error` | 10.21 | test_migration.py
test_02_native_to_native_vpc_migration | `Error` | 6.86 | test_migration.py
test_delete_network_while_vm_on_it | `Error` | 2.27 | test_network.py
test_delete_network_while_vm_on_it | `Error` | 2.28 | test_network.py
test_deploy_vm_l2network | `Error` | 2.27 | test_network.py
test_deploy_vm_l2network | `Error` | 2.28 | test_network.py
test_l2network_restart | `Error` | 3.37 | test_network.py
test_l2network_restart | `Error` | 3.38 | test_network.py
ContextSuite context=TestL2Networks>:teardown | `Error` | 4.47 | test_network.py
ContextSuite context=TestPortForwarding>:setup | `Error` | 7.39 | test_network.py
ContextSuite context=TestPublicIP>:setup | `Error` | 4.70 | test_network.py
test_reboot_router | `Error` | 2.98 | test_network.py
test_releaseIP | `Error` | 2.87 | test_network.py
ContextSuite context=TestRouterRules>:setup | `Error` | 5.77 | test_network.py
test_01_deployVMInSharedNetwork | `Failure` | 1.20 | test_network.py
test_02_verifyRouterIpAfterNetworkRestart | `Failure` | 1.08 | test_network.py
test_03_destroySharedNetwork | `Failure` | 1.08 | test_network.py
ContextSuite context=TestSharedNetwork>:teardown | `Error` | 2.19 | test_network.py
ContextSuite context=TestDeployVM>:setup | `Error` | 0.00 | test_vm_life_cycle.py
test_01_secure_vm_migration | `Error` | 70.21 | test_vm_life_cycle.py
test_02_unsecure_vm_migration | `Error` | 214.81 | test_vm_life_cycle.py
test_03_secured_to_nonsecured_vm_migration | `Error` | 144.02 | test_vm_life_cycle.py
test_04_nonsecured_to_secured_vm_migration | `Error` | 144.95 | test_vm_life_cycle.py
ContextSuite context=TestVMLifeCycle>:setup | `Error` | 2.74 | test_vm_life_cycle.py
test_network_acl | `Error` | 5.27 | test_network_acl.py
ContextSuite context=TestCpuCapServiceOfferings>:setup | `Error` | 0.00 | test_service_offerings.py
test_02_routervm_iptables_policies | `Error` | 1.20 | test_routers_iptables_default_policy.py
test_01_single_VPC_iptables_policies | `Error` | 6.32 | test_routers_iptables_default_policy.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5879: Role escalation prevention
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5879:
URL: https://github.com/apache/cloudstack/pull/5879#issuecomment-1026705210
@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5879: Role escalation prevention
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5879:
URL: https://github.com/apache/cloudstack/pull/5879#issuecomment-1027365785
@sureshanaparti a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5879: Role escalation prevention
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5879:
URL: https://github.com/apache/cloudstack/pull/5879#issuecomment-1027967054
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 2433
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #5879: Role escalation prevention
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #5879:
URL: https://github.com/apache/cloudstack/pull/5879#issuecomment-1025797642
@blueorangutan test keepEnv
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #5879: Role escalation prevention
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on a change in pull request #5879:
URL: https://github.com/apache/cloudstack/pull/5879#discussion_r792431977
##########
File path: server/src/main/java/com/cloud/user/AccountManagerImpl.java
##########
@@ -358,10 +391,46 @@ public UserVO getSystemUser() {
@Override
public boolean start() {
+ if (apiNameList == null) {
+ long startTime = System.nanoTime();
+ apiNameList = new ArrayList<String>();
+ Set<Class<?>> cmdClasses = new LinkedHashSet<Class<?>>();
+ for (PluggableService service : services) {
+ s_logger.debug(String.format("getting api commands of service: %s", service.getClass().getName()));
+ cmdClasses.addAll(service.getCommands());
+ }
+ apiNameList = createApiNameList(cmdClasses);
+ long endTime = System.nanoTime();
+ s_logger.info("Api Discovery Service: Annotation, docstrings, api relation graph processed in " + (endTime - startTime) / 1000000.0 + " ms");
+ }
_executor.scheduleAtFixedRate(new AccountCleanupTask(), _cleanupInterval, _cleanupInterval, TimeUnit.SECONDS);
return true;
}
+ protected List<String> createApiNameList(Set<Class<?>> cmdClasses) {
+ List<String> apiNameList = new ArrayList<String>();
+
+ for (Class<?> cmdClass : cmdClasses) {
Review comment:
I'll look into it again. It didn't seem prudent when I implemented this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #5879: Role escalation prevention
Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on pull request #5879:
URL: https://github.com/apache/cloudstack/pull/5879#issuecomment-1017222117
Thanks @DaanHoogland, I'll review and get back in a few days. Meanwhile, do add/ask other devs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5879: Role escalation prevention
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5879:
URL: https://github.com/apache/cloudstack/pull/5879#issuecomment-1017230972
@sureshanaparti a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5879: Role escalation prevention
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5879:
URL: https://github.com/apache/cloudstack/pull/5879#issuecomment-1018422776
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 2268
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #5879: Role escalation prevention
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #5879:
URL: https://github.com/apache/cloudstack/pull/5879#issuecomment-1018660087
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on a change in pull request #5879: Role escalation prevention
Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on a change in pull request #5879:
URL: https://github.com/apache/cloudstack/pull/5879#discussion_r789558979
##########
File path: api/src/test/java/org/apache/cloudstack/api/command/admin/account/CreateAccountCmdTest.java
##########
@@ -73,7 +73,7 @@ public void testExecuteWithNotBlankPassword() {
} catch (ServerApiException e) {
Assert.assertTrue("Received exception as the mock accountService createUserAccount returns null user", true);
}
- Mockito.verify(accountService, Mockito.times(1)).createUserAccount(null, "Test", null, null, null, null, null, accountType, roleId, domainId, null, null, null, null);
+ Mockito.verify(accountService, Mockito.times(1)).createUserAccount(createAccountCmd);
Review comment:
in setUp(), should we set the roleId field too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #5879: Role escalation prevention
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #5879:
URL: https://github.com/apache/cloudstack/pull/5879#issuecomment-1017229611
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5879: Role escalation prevention
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5879:
URL: https://github.com/apache/cloudstack/pull/5879#issuecomment-1018661165
@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #5879: Role escalation prevention
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #5879:
URL: https://github.com/apache/cloudstack/pull/5879#issuecomment-1021053219
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5879: Role escalation prevention
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5879:
URL: https://github.com/apache/cloudstack/pull/5879#issuecomment-1033678699
@sureshanaparti a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5879: Role escalation prevention
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5879:
URL: https://github.com/apache/cloudstack/pull/5879#issuecomment-1019762863
@sureshanaparti a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5879: Role escalation prevention
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5879:
URL: https://github.com/apache/cloudstack/pull/5879#issuecomment-1021445130
@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #5879: Role escalation prevention
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on a change in pull request #5879:
URL: https://github.com/apache/cloudstack/pull/5879#discussion_r792524917
##########
File path: server/src/main/java/com/cloud/user/AccountManagerImpl.java
##########
@@ -358,10 +391,46 @@ public UserVO getSystemUser() {
@Override
public boolean start() {
+ if (apiNameList == null) {
+ long startTime = System.nanoTime();
+ apiNameList = new ArrayList<String>();
+ Set<Class<?>> cmdClasses = new LinkedHashSet<Class<?>>();
+ for (PluggableService service : services) {
Review comment:
the role service can be dis-/enabled dynamically. we need a conclusive list of all API. It needs to be done independent of which checker is active.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5879: Role escalation prevention
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5879:
URL: https://github.com/apache/cloudstack/pull/5879#issuecomment-1021054048
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5879: Role escalation prevention
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5879:
URL: https://github.com/apache/cloudstack/pull/5879#issuecomment-1027286943
<b>Trillian test result (tid-3098)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 35821 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5879-t3098-kvm-centos7.zip
Smoke tests completed. 82 look OK, 10 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_redundant_vpc_site2site_vpn | `Failure` | 7.49 | test_vpc_vpn.py
test_01_vpc_site2site_vpn_multiple_options | `Failure` | 5.35 | test_vpc_vpn.py
test_01_vpc_remote_access_vpn | `Failure` | 4.17 | test_vpc_vpn.py
test_01_vpc_site2site_vpn | `Failure` | 5.36 | test_vpc_vpn.py
test_02_deploy_vm_from_direct_download_template | `Error` | 1.19 | test_templates.py
ContextSuite context=TestTemplates>:setup | `Error` | 20.12 | test_templates.py
ContextSuite context=TestRemoteDiagnostics>:setup | `Error` | 0.00 | test_diagnostics.py
test_01_deploy_vm_from_direct_download_template_nfs_storage | `Error` | 1.19 | test_direct_download.py
ContextSuite context=TestDirectDownloadTemplates>:teardown | `Error` | 0.05 | test_direct_download.py
test_01_isolated_persistent_network | `Error` | 2.79 | test_persistent_network.py
test_03_deploy_and_destroy_VM_and_verify_network_resources_persist | `Failure` | 2.41 | test_persistent_network.py
test_03_deploy_and_destroy_VM_and_verify_network_resources_persist | `Error` | 2.41 | test_persistent_network.py
ContextSuite context=TestL2PersistentNetworks>:teardown | `Error` | 2.45 | test_persistent_network.py
test_00_deploy_vm_root_resize | `Error` | 1.25 | test_deploy_vm_root_resize.py
test_deployvm_userdata | `Error` | 1.25 | test_deploy_vm_with_userdata.py
test_deployvm_userdata_post | `Error` | 1.21 | test_deploy_vm_with_userdata.py
test_deployvm_firstfit | `Error` | 1.24 | test_deploy_vms_with_varied_deploymentplanners.py
test_deployvm_userconcentrated | `Error` | 1.19 | test_deploy_vms_with_varied_deploymentplanners.py
test_deployvm_userdispersing | `Error` | 1.19 | test_deploy_vms_with_varied_deploymentplanners.py
ContextSuite context=TestResetVmOnReboot>:setup | `Error` | 0.00 | test_reset_vm_on_reboot.py
test_disable_oobm_ha_state_ineligible | `Error` | 1511.78 | test_hostha_kvm.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan removed a comment on pull request #5879: Role escalation prevention
Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #5879:
URL: https://github.com/apache/cloudstack/pull/5879#issuecomment-1027365785
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5879: Role escalation prevention
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5879:
URL: https://github.com/apache/cloudstack/pull/5879#issuecomment-1027920580
@DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan removed a comment on pull request #5879: Role escalation prevention
Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #5879:
URL: https://github.com/apache/cloudstack/pull/5879#issuecomment-1018422776
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 2268
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5879: Role escalation prevention
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5879:
URL: https://github.com/apache/cloudstack/pull/5879#issuecomment-1031373031
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 2495
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #5879: Role escalation prevention
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #5879:
URL: https://github.com/apache/cloudstack/pull/5879#issuecomment-1031375654
ping @rohityadavcloud can you test this changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5879: Role escalation prevention
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5879:
URL: https://github.com/apache/cloudstack/pull/5879#issuecomment-1030163380
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 2463
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org