You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Gabor Apati-Nagy <ga...@citrix.com> on 2014/03/27 21:39:47 UTC
Re: Review Request 19751: Fixed [CLOUDSTACK-5962]: Value of Global parameter
"custom.diskoffering.size.min" is not reflected in UI during new instance
creation
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19751/
-----------------------------------------------------------
(Updated March 27, 2014, 8:39 p.m.)
Review request for cloudstack.
Summary (updated)
-----------------
Fixed [CLOUDSTACK-5962]: Value of Global parameter "custom.diskoffering.size.min" is not reflected in UI during new instance creation
Bugs: CLOUDSTACK-5962
https://issues.apache.org/jira/browse/CLOUDSTACK-5962
Repository: cloudstack-git
Description (updated)
-------
Fix for [CLOUDSTACK-5962]: Value of Global parameter "custom.diskoffering.size.min" is not reflected in UI during new instance creation.
Added fields to /api and /server classes for CustomDiskOfferingMinSize to be available in CapabilitiesResponse. Fixed UI code in Instance Wizard to have this config value as the minimum selectable option when we are in custom disk size mode.
Diffs
-----
api/src/org/apache/cloudstack/api/ApiConstants.java 87fa8ee
api/src/org/apache/cloudstack/api/command/user/config/ListCapabilitiesCmd.java d47645b
api/src/org/apache/cloudstack/api/response/CapabilitiesResponse.java c8de587
server/src/com/cloud/server/ManagementServerImpl.java 7431891
ui/index.jsp 96cfeb5
ui/scripts/instanceWizard.js 03ee344
ui/scripts/ui-custom/instanceWizard.js c5e0ddb
Diff: https://reviews.apache.org/r/19751/diff/
Testing
-------
Thanks,
Gabor Apati-Nagy
Re: Review Request 19751: Fixed [CLOUDSTACK-5962]: Value of Global parameter
"custom.diskoffering.size.min" is not reflected in UI during new instance
creation
Posted by Alena Prokharchyk <al...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19751/#review39172
-----------------------------------------------------------
Java part of the fix looks fine to me.
- Alena Prokharchyk
On March 28, 2014, 2:45 p.m., Gabor Apati-Nagy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19751/
> -----------------------------------------------------------
>
> (Updated March 28, 2014, 2:45 p.m.)
>
>
> Review request for cloudstack, Brian Federle and Jessica Wang.
>
>
> Bugs: CLOUDSTACK-5962
> https://issues.apache.org/jira/browse/CLOUDSTACK-5962
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Fix for [CLOUDSTACK-5962]: Value of Global parameter "custom.diskoffering.size.min" is not reflected in UI during new instance creation.
>
> Added fields to /api and /server classes for CustomDiskOfferingMinSize to be available in CapabilitiesResponse. Fixed UI code in Instance Wizard to have this config value as the minimum selectable option when we are in custom disk size mode.
>
>
> Diffs
> -----
>
> api/src/org/apache/cloudstack/api/ApiConstants.java 87fa8ee
> api/src/org/apache/cloudstack/api/command/user/config/ListCapabilitiesCmd.java d47645b
> api/src/org/apache/cloudstack/api/response/CapabilitiesResponse.java c8de587
> server/src/com/cloud/server/ManagementServerImpl.java 7431891
> ui/index.jsp dce2aa8
> ui/scripts/instanceWizard.js 03ee344
> ui/scripts/ui-custom/instanceWizard.js c5e0ddb
>
> Diff: https://reviews.apache.org/r/19751/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Gabor Apati-Nagy
>
>
Re: Review Request 19751: Fixed [CLOUDSTACK-5962]: Value of Global parameter
"custom.diskoffering.size.min" is not reflected in UI during new instance
creation
Posted by Brian Federle <br...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19751/#review39178
-----------------------------------------------------------
Ship it!
Ship It!
- Brian Federle
On March 28, 2014, 2:45 p.m., Gabor Apati-Nagy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19751/
> -----------------------------------------------------------
>
> (Updated March 28, 2014, 2:45 p.m.)
>
>
> Review request for cloudstack, Brian Federle and Jessica Wang.
>
>
> Bugs: CLOUDSTACK-5962
> https://issues.apache.org/jira/browse/CLOUDSTACK-5962
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Fix for [CLOUDSTACK-5962]: Value of Global parameter "custom.diskoffering.size.min" is not reflected in UI during new instance creation.
>
> Added fields to /api and /server classes for CustomDiskOfferingMinSize to be available in CapabilitiesResponse. Fixed UI code in Instance Wizard to have this config value as the minimum selectable option when we are in custom disk size mode.
>
>
> Diffs
> -----
>
> api/src/org/apache/cloudstack/api/ApiConstants.java 87fa8ee
> api/src/org/apache/cloudstack/api/command/user/config/ListCapabilitiesCmd.java d47645b
> api/src/org/apache/cloudstack/api/response/CapabilitiesResponse.java c8de587
> server/src/com/cloud/server/ManagementServerImpl.java 7431891
> ui/index.jsp dce2aa8
> ui/scripts/instanceWizard.js 03ee344
> ui/scripts/ui-custom/instanceWizard.js c5e0ddb
>
> Diff: https://reviews.apache.org/r/19751/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Gabor Apati-Nagy
>
>
Re: Review Request 19751: Fixed [CLOUDSTACK-5962]: Value of Global parameter
"custom.diskoffering.size.min" is not reflected in UI during new instance
creation
Posted by Gabor Apati-Nagy <ga...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19751/
-----------------------------------------------------------
(Updated March 28, 2014, 2:45 p.m.)
Review request for cloudstack, Brian Federle and Jessica Wang.
Bugs: CLOUDSTACK-5962
https://issues.apache.org/jira/browse/CLOUDSTACK-5962
Repository: cloudstack-git
Description
-------
Fix for [CLOUDSTACK-5962]: Value of Global parameter "custom.diskoffering.size.min" is not reflected in UI during new instance creation.
Added fields to /api and /server classes for CustomDiskOfferingMinSize to be available in CapabilitiesResponse. Fixed UI code in Instance Wizard to have this config value as the minimum selectable option when we are in custom disk size mode.
Diffs
-----
api/src/org/apache/cloudstack/api/ApiConstants.java 87fa8ee
api/src/org/apache/cloudstack/api/command/user/config/ListCapabilitiesCmd.java d47645b
api/src/org/apache/cloudstack/api/response/CapabilitiesResponse.java c8de587
server/src/com/cloud/server/ManagementServerImpl.java 7431891
ui/index.jsp dce2aa8
ui/scripts/instanceWizard.js 03ee344
ui/scripts/ui-custom/instanceWizard.js c5e0ddb
Diff: https://reviews.apache.org/r/19751/diff/
Testing
-------
Thanks,
Gabor Apati-Nagy
Re: Review Request 19751: Fixed [CLOUDSTACK-5962]: Value of Global parameter
"custom.diskoffering.size.min" is not reflected in UI during new instance
creation
Posted by Gabor Apati-Nagy <ga...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19751/
-----------------------------------------------------------
(Updated March 28, 2014, 2:45 p.m.)
Review request for cloudstack.
Changes
-------
Changed diff to proper git patch.
Bugs: CLOUDSTACK-5962
https://issues.apache.org/jira/browse/CLOUDSTACK-5962
Repository: cloudstack-git
Description
-------
Fix for [CLOUDSTACK-5962]: Value of Global parameter "custom.diskoffering.size.min" is not reflected in UI during new instance creation.
Added fields to /api and /server classes for CustomDiskOfferingMinSize to be available in CapabilitiesResponse. Fixed UI code in Instance Wizard to have this config value as the minimum selectable option when we are in custom disk size mode.
Diffs (updated)
-----
api/src/org/apache/cloudstack/api/ApiConstants.java 87fa8ee
api/src/org/apache/cloudstack/api/command/user/config/ListCapabilitiesCmd.java d47645b
api/src/org/apache/cloudstack/api/response/CapabilitiesResponse.java c8de587
server/src/com/cloud/server/ManagementServerImpl.java 7431891
ui/index.jsp dce2aa8
ui/scripts/instanceWizard.js 03ee344
ui/scripts/ui-custom/instanceWizard.js c5e0ddb
Diff: https://reviews.apache.org/r/19751/diff/
Testing
-------
Thanks,
Gabor Apati-Nagy