svn commit: r550636 - /httpd/httpd/trunk/modules/experimental/mod_example.c

[sc...@apache.org]

Author: sctemme
Date: Mon Jun 25 16:22:30 2007
New Revision: 550636

URL: http://svn.apache.org/viewvc?view=rev&rev=550636
Log:
Complete cleanup of global variable use by mod_example.  This should take away 
any existing reservation about thread-safety of this code.  Add warning that 
this code is now too top heavy and implements too many obscure callbacks to 
serve a s point of departure for one's own development effort. 


Modified:
    httpd/httpd/trunk/modules/experimental/mod_example.c

Modified: httpd/httpd/trunk/modules/experimental/mod_example.c
URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/experimental/mod_example.c?view=diff&rev=550636&r1=550635&r2=550636
==============================================================================
--- httpd/httpd/trunk/modules/experimental/mod_example.c (original)
+++ httpd/httpd/trunk/modules/experimental/mod_example.c Mon Jun 25 16:22:30 2007
@@ -25,14 +25,38 @@
  * this module, but which may have counterparts in *real* modules, are
  * prefixed with 'x_' instead of 'example_'.
  *
- * IMPORTANT NOTE
- * ==============
- *
- * Some of the code in this module has problems.
- * Before using it to base your work on, see
- *
- * http://issues.apache.org/bugzilla/show_bug.cgi?id=29709
- * http://issues.apache.org/bugzilla/show_bug.cgi?id=32051
+ * To use mod_example, configure the Apache build with --enable-example and 
+ * compile.  Set up a <Location> block in your configuration file like so: 
+ * 
+ * <Location /example>
+ *    SetHandler example-handler
+ * </Location> 
+ * 
+ * When you look at that location on your server, you will see a backtrace of 
+ * the callbacks that have been invoked up to that point.  See the ErrorLog for 
+ * more information on code paths that  touch mod_example. 
+ *
+ * IMPORTANT NOTES
+ * ===============
+ * 
+ * Do NOT use this module on a production server. It attaches itself to every
+ * phase of the server runtime operations including startup, shutdown and
+ * request processing, and produces copious amounts of logging data.  This will 
+ * negatively affect server performance. 
+ * 
+ * Do NOT use mod_example as the basis for your own code.  This module
+ * implements every callback hook offered by the Apache core, and your
+ * module will almost certainly not have to implement this much.  If you
+ * want a simple module skeleton to start development, use apxs -g. 
+ * 
+ * XXX TO DO XXX
+ * =============
+ *
+ * * Enable HTML backtrace entries for more callbacks that are not directly 
+ *   associated with a request
+ * * Make sure every callback that posts an HTML backtrace entry does so in the *   right category, so nothing gets overwritten
+ * * Implement some logic to show what happens in the parent, and what in the 
+ *   child(ren)
  */
 
 #include "httpd.h"
@@ -94,24 +118,10 @@
 } x_cfg;
 
 /*
- * Let's set up a module-local static cell to point to the accreting callback
- * trace.  As each API callback is made to us, we'll tack on the particulars
- * to whatever we've already recorded.  To avoid massive memory bloat as
- * directories are walked again and again, we record the routine/environment
- * the first time (non-request context only), and ignore subsequent calls for
- * the same routine/environment.
+ * String pointer to hold the startup trace. No harm working with a global until 
+ * the server is (may be) multi-threaded. 
  */
 static const char *trace = NULL;
-static apr_table_t *static_calls_made = NULL;
-
-/*
- * To avoid leaking memory from pools other than the per-request one, we
- * allocate a module-private pool, and then use a sub-pool of that which gets
- * freed each time we modify the trace.  That way previous layers of trace
- * data don't get lost.
- */
-static apr_pool_t *x_pool = NULL;
-static apr_pool_t *x_subpool = NULL;
 
 /*
  * Declare ourselves so the configuration routines can find and know us.
@@ -303,26 +313,6 @@
 }
 
 /*
- * This routine sets up some module-wide cells if they haven't been already.
- */
-static void setup_module_cells(void)
-{
-    /*
-     * If we haven't already allocated our module-private pool, do so now.
-     */
-    if (x_pool == NULL) {
-        apr_pool_create(&x_pool, NULL);
-    };
-    /*
-     * Likewise for the table of routine/environment pairs we visit outside of
-     * request context.
-     */
-    if (static_calls_made == NULL) {
-        static_calls_made = apr_table_make(x_pool, 16);
-    };
-}
-
-/*
  * You *could* change the following if you wanted to see the calling
  * sequence reported in the server's error_log, but beware - almost all of
  * these co-routines are called for every single request, and the impact
@@ -860,10 +850,6 @@
     char *note;
     char *sname = s->server_hostname;
 
-    /*
-     * Set up any module cells that ought to be initialised.
-     */
-    setup_module_cells();
     /*
      * The arbitrary text we add to our trace entry indicates for which server
      * we're being called.