You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by James Peach <jp...@apache.org> on 2018/06/30 08:10:53 UTC
Review Request 67792: Moved tests sources from libmesos to
mesos-tests.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67792/
-----------------------------------------------------------
Review request for mesos and Benjamin Bannier.
Repository: mesos
Description
-------
Since libmesos should not contain any tests, move test
headers into `mesos_tests_SOURCES`.
Diffs
-----
src/Makefile.am bd94a6488c1c1cc2481b9e9edb25307ced8c0d21
Diff: https://reviews.apache.org/r/67792/diff/1/
Testing
-------
make check (Fedora 28)
Thanks,
James Peach
Re: Review Request 67792: Moved tests sources from libmesos to
mesos-tests.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67792/#review205605
-----------------------------------------------------------
Ship it!
We should confirm changes such changes to the autotools build with `make distcheck`. Looking good.
- Benjamin Bannier
On June 30, 2018, 10:10 a.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67792/
> -----------------------------------------------------------
>
> (Updated June 30, 2018, 10:10 a.m.)
>
>
> Review request for mesos and Benjamin Bannier.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Since libmesos should not contain any tests, move test
> headers into `mesos_tests_SOURCES`.
>
>
> Diffs
> -----
>
> src/Makefile.am bd94a6488c1c1cc2481b9e9edb25307ced8c0d21
>
>
> Diff: https://reviews.apache.org/r/67792/diff/1/
>
>
> Testing
> -------
>
> make check (Fedora 28)
>
>
> Thanks,
>
> James Peach
>
>
Re: Review Request 67792: Moved tests sources from libmesos to
mesos-tests.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67792/#review205607
-----------------------------------------------------------
FAIL: Some of the unit tests failed. Please check the relevant logs.
Reviews applied: `['67792']`
Failed command: `Start-MesosCITesting`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67792
Relevant logs:
- [mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67792/logs/mesos-tests-stdout.log):
```
[ OK ] Endpoint/SlaveEndpointTest.NoAuthorizer/2 (111 ms)
[----------] 9 tests from Endpoint/SlaveEndpointTest (1095 ms total)
[----------] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest
[ RUN ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0
[ OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0 (34 ms)
[ RUN ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1
[ OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1 (38 ms)
[----------] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest (73 ms total)
[----------] 1 test from IsolationFlag/CpuIsolatorTest
[ RUN ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0
[ OK ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0 (996 ms)
[----------] 1 test from IsolationFlag/CpuIsolatorTest (1018 ms total)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest
[ RUN ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0
[ OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (1051 ms)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest (1074 ms total)
[----------] Global test environment tear-down
[==========] 994 tests from 98 test cases ran. (582061 ms total)
[ PASSED ] 993 tests.
[ FAILED ] 1 test, listed below:
[ FAILED ] DockerTest.ROOT_DOCKER_interface
1 FAILED TEST
YOU HAVE 220 DISABLED TESTS
```
- [mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67792/logs/mesos-tests-stderr.log):
```
I0630 09:53:50.109210 15432 master.cpp:11032] Updating the state of task cdcc18f0-f6b0-436b-9204-8868fa0356ac of framework 3fa7f036-dc4c-4549-9a19-cd7f402834c2-0000 (latest state: TASK_KILLED, status update state: TASK_KILLED)
I0630 09:53:50.110208 16588 slave.cpp:3939] Shutting down framework 3fa7f036-dc4c-4549-9a19-cd7f402834c2-0000
I0630 09:53:50.110208 16588 slave.cpp:6660] Shutting down executor 'cdcc18f0-f6b0-436b-9204-8868fa0356ac' of framework 3fa7f036-dc4c-4549-9a19-cd7f402834c2-0000 at executor(1)@192.10.1.6:64728
I0630 09:53:50.112205 16588 slave.cpp:931] Agent terminating
W0630 09:53:50.112205 16588 slave.cpp:3935] Ignoring shutdown framework 3fa7f036-dc4c-4549-9I0630 09:53:49.891201 17372 exec.cpp:162] Version: 1.7.0
I0630 09:53:49.917204 21692 exec.cpp:236] Executor registered on agent 3fa7f036-dc4c-4549-9a19-cd7f402834c2-S0
I0630 09:53:49.922204 21092 executor.cpp:182] Received SUBSCRIBED event
I0630 09:53:49.926198 21092 executor.cpp:186] Subscribed executor on windows-02.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net
I0630 09:53:49.926198 21092 executor.cpp:182] Received LAUNCH event
I0630 09:53:49.931197 21092 executor.cpp:679] Starting task cdcc18f0-f6b0-436b-9204-8868fa0356ac
I0630 09:53:50.012202 21092 executor.cpp:499] Running 'D:\DCOS\mesos\src\mesos-containerizer.exe launch <POSSIBLY-SENSITIVE-DATA>'
I0630 09:53:50.082204 21092 executor.cpp:693] Forked command at 21648
I0630 09:53:50.112205 17372 exec.cpp:445] Executor asked to shutdown
I0630 09:53:50.113206 21692 executor.cpp:182] Received SHUTDOWN event
I0630 09:53:50.113206 21692 executor.cpp:796] Shutting down
I0630 09:53:50.114205 21692 executor.cpp:909] Sending SIGTERM to process tree at pid 21a19-cd7f402834c2-0000 because it is terminating
I0630 09:53:50.113206 15432 master.cpp:11131] Removing task cdcc18f0-f6b0-436b-9204-8868fa0356ac with resources cpus(allocated: *):4; mem(allocated: *):2048; disk(allocated: *):1024; ports(allocated: *):[31000-32000] of framework 3fa7f036-dc4c-4549-9a19-cd7f402834c2-0000 on agent 3fa7f036-dc4c-4549-9a19-cd7f402834c2-S0 at slave(449)@192.10.1.6:64707 (windows-02.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net)
I0630 09:53:50.116207 15432 master.cpp:1330] Agent 3fa7f036-dc4c-4549-9a19-cd7f402834c2-S0 at slave(449)@192.10.1.6:64707 (windows-02.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net) disconnected
I0630 09:53:50.116207 15432 master.cpp:3340] Disconnecting agent 3fa7f036-dc4c-4549-9a19-cd7f402834c2-S0 at slave(449)@192.10.1.6:64707 (windows-02.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net)
I0630 09:53:50.117205 15432 master.cpp:3359] Deactivating agent 3fa7f036-dc4c-4549-9a19-cd7f402834c2-S0 at slave(449)@192.10.1.6:64707 (windows-02.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net)
I0630 09:53:50.117205 22236 containerizer.cpp:2407] Destroying container 47763890-d0e3-438d-8208-93d7503e302e in RUNNING state
I0630 09:53:50.118203 22236 containerizer.cpp:3021] Transitioning the state of container 47763890-d0e3-438d-8208-93d7503e302e from RUNNING to DESTROYING
I0630 09:53:50.118203 22236 launcher.cpp:155] Asked to destroy container 47763890-d0e3-438d-8208-93d7503e302e
I0630 09:53:50.118203 11600 hierarchical.cpp:346] Removed framework 3fa7f036-dc4c-4549-9a19-cd7f402834c2-0000
I0630 09:53:50.119210 11600 hierarchical.cpp:769] Agent 3fa7f036-dc4c-4549-9a19-cd7f402834c2-S0 deactivated
I0630 09:53:50.176215 20172 containerizer.cpp:2860] Container 47763890-d0e3-438d-8208-93d7503e302e has exited
I0630 09:53:50.204347 19328 master.cpp:1172] Master terminating
I0630 09:53:50.208214 15432 hierarchical.cpp:612] Removed agent 3fa7f036-dc4c-4549-9a19-cd7f402834c2-S0
I0630 09:53:50.574203 4408 process.cpp:940] Stopped the socket accept loop
```
- Mesos Reviewbot Windows
On June 30, 2018, 8:10 a.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67792/
> -----------------------------------------------------------
>
> (Updated June 30, 2018, 8:10 a.m.)
>
>
> Review request for mesos and Benjamin Bannier.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Since libmesos should not contain any tests, move test
> headers into `mesos_tests_SOURCES`.
>
>
> Diffs
> -----
>
> src/Makefile.am bd94a6488c1c1cc2481b9e9edb25307ced8c0d21
>
>
> Diff: https://reviews.apache.org/r/67792/diff/1/
>
>
> Testing
> -------
>
> make check (Fedora 28)
>
>
> Thanks,
>
> James Peach
>
>