You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by Hari Shreedharan <hs...@cloudera.com> on 2013/04/11 01:18:14 UTC

Review Request: FLUME-1980. Log4jAppender should optionally drop events if append fails

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10412/
-----------------------------------------------------------

Review request for Flume.


Description
-------

Added a new "UnsafeMode" to the log4jappender and load balancing lo4j appender.


This addresses bug FLUME-1980.
    https://issues.apache.org/jira/browse/FLUME-1980


Diffs
-----

  flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestFileChannelRestart.java fb0e208 
  flume-ng-clients/flume-ng-log4jappender/src/main/java/org/apache/flume/clients/log4jappender/LoadBalancingLog4jAppender.java 9fb115e 
  flume-ng-clients/flume-ng-log4jappender/src/main/java/org/apache/flume/clients/log4jappender/Log4jAppender.java d61f807 
  flume-ng-clients/flume-ng-log4jappender/src/test/java/org/apache/flume/clients/log4jappender/TestLoadBalancingLog4jAppender.java 657af67 
  flume-ng-clients/flume-ng-log4jappender/src/test/java/org/apache/flume/clients/log4jappender/TestLog4jAppender.java de88730 
  flume-ng-doc/sphinx/FlumeUserGuide.rst 693c0d7 

Diff: https://reviews.apache.org/r/10412/diff/


Testing
-------

Added unit tests.


Thanks,

Hari Shreedharan


Re: Review Request: FLUME-1980. Log4jAppender should optionally drop events if append fails

Posted by Hari Shreedharan <hs...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10412/
-----------------------------------------------------------

(Updated April 10, 2013, 11:21 p.m.)


Review request for Flume.


Changes
-------

Removed an accidentally added file.


Description
-------

Added a new "UnsafeMode" to the log4jappender and load balancing lo4j appender.


This addresses bug FLUME-1980.
    https://issues.apache.org/jira/browse/FLUME-1980


Diffs (updated)
-----

  flume-ng-clients/flume-ng-log4jappender/src/main/java/org/apache/flume/clients/log4jappender/LoadBalancingLog4jAppender.java 9fb115e 
  flume-ng-clients/flume-ng-log4jappender/src/main/java/org/apache/flume/clients/log4jappender/Log4jAppender.java d61f807 
  flume-ng-clients/flume-ng-log4jappender/src/test/java/org/apache/flume/clients/log4jappender/TestLoadBalancingLog4jAppender.java 657af67 
  flume-ng-clients/flume-ng-log4jappender/src/test/java/org/apache/flume/clients/log4jappender/TestLog4jAppender.java de88730 
  flume-ng-doc/sphinx/FlumeUserGuide.rst 693c0d7 

Diff: https://reviews.apache.org/r/10412/diff/


Testing
-------

Added unit tests.


Thanks,

Hari Shreedharan