You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/04/02 04:45:24 UTC

[GitHub] [incubator-tvm] gmagogsfm opened a new pull request #5217: Move Graph Runtime header file to tvm/include for easier access

gmagogsfm opened a new pull request #5217: Move Graph Runtime header file to tvm/include for easier access
URL: https://github.com/apache/incubator-tvm/pull/5217
 
 
   graph_runtime.h contains C++ API for graph runtime. However, it has been placed under tvm/src, which is less accessible. This PR moves it to tvm/include/tvm/runtime/graph/.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-tvm] tqchen edited a comment on issue #5217: Move Graph Runtime header file to tvm/include for easier access

Posted by GitBox <gi...@apache.org>.
tqchen edited a comment on issue #5217: Move Graph Runtime header file to tvm/include for easier access
URL: https://github.com/apache/incubator-tvm/pull/5217#issuecomment-607972074
 
 
   We intentionally keep the graph runtime header inside `src/` because they are considered as private APIs used inside the project and are not public APIs. We prefer to use the public PackedFunc and NDArray API to handle all the executions related to the gaph runtime and other generated code.
   
   Such unification will also bring benefit later when we decide to swap the implementation of the graph runtime to other backends(e.g. vm or AOT)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-tvm] tqchen commented on issue #5217: Move Graph Runtime header file to tvm/include for easier access

Posted by GitBox <gi...@apache.org>.
tqchen commented on issue #5217: Move Graph Runtime header file to tvm/include for easier access
URL: https://github.com/apache/incubator-tvm/pull/5217#issuecomment-607972074
 
 
   We intentionally keep the graph runtime header inside `src/` because they are considered as private APIs used inside the TVM. We prefer to use the public PackedFunc and NDArray API to handle all the executions related to the gaph runtime and other generated code.
   
   Such unification will also bring benefit later when we decide to swap the implementation of the graph runtime to other backends(e.g. vm or AOT)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-tvm] gmagogsfm commented on issue #5217: Move Graph Runtime header file to tvm/include for easier access

Posted by GitBox <gi...@apache.org>.
gmagogsfm commented on issue #5217: Move Graph Runtime header file to tvm/include for easier access
URL: https://github.com/apache/incubator-tvm/pull/5217#issuecomment-608079590
 
 
   Thanks for the clarification. Closing this now. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-tvm] tqchen closed pull request #5217: Move Graph Runtime header file to tvm/include for easier access

Posted by GitBox <gi...@apache.org>.
tqchen closed pull request #5217: Move Graph Runtime header file to tvm/include for easier access
URL: https://github.com/apache/incubator-tvm/pull/5217
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services