You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "errose28 (via GitHub)" <gi...@apache.org> on 2024/02/13 02:01:29 UTC
[PR] HDDS-10355. Consolidate label and title check to the same workflow. [ozone-site]
errose28 opened a new pull request, #75:
URL: https://github.com/apache/ozone-site/pull/75
## Summary
Minor cleanup of new website github actions. The title check was added to its own workflow so it could be cherry-picked to the master branch. Now that the cherry-pick is done, the new website's branch has two different workflows for the labeler and the title check that pertain to pull request metadata. We can combine them to one workflow.
IMO this looks cleaner when viewing run output as we add more workflows.
## Jira
HDDS-10355
## Testing
A [PR](https://github.com/errose28/ozone-site/pull/3) against this branch on my fork still ran the title and label checks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-10355. Consolidate label and title check to the same workflow. [ozone-site]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on code in PR #75:
URL: https://github.com/apache/ozone-site/pull/75#discussion_r1489240858
##########
.github/workflows/pull-request.yml:
##########
@@ -16,22 +16,31 @@
name: pull request
on:
- pull_request:
+ pull_request_target:
types:
- - reopened
- - opened
- - edited
- - synchronize
+ - reopened
+ - opened
+ - edited
+ - synchronize
+ - pull_request_target
jobs:
title:
runs-on: ubuntu-latest
steps:
- - name: Checkout project
- uses: actions/checkout@v4
- - name: Check pull request title
- env:
- TITLE: ${{ github.event.pull_request.title }}
- run:
- .github/scripts/pr_title_check.sh "${TITLE}"
-
+ - name: Checkout project
+ uses: actions/checkout@v4
+ - name: Check pull request title
+ env:
+ TITLE: ${{ github.event.pull_request.title }}
+ run:
+ .github/scripts/pr_title_check.sh "${TITLE}"
Review Comment:
GitHub Actions doc [says](https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#pull_request_target) about `pull_request_target`:
> Avoid using this event if you need to build or run code from the pull request.
Thus, I think we should keep these checks separate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-10355. Consolidate label and title check to the same workflow. [ozone-site]
Posted by "errose28 (via GitHub)" <gi...@apache.org>.
errose28 closed pull request #75: HDDS-10355. Consolidate label and title check to the same workflow.
URL: https://github.com/apache/ozone-site/pull/75
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-10355. Consolidate label and title check to the same workflow. [ozone-site]
Posted by "errose28 (via GitHub)" <gi...@apache.org>.
errose28 commented on code in PR #75:
URL: https://github.com/apache/ozone-site/pull/75#discussion_r1489927979
##########
.github/workflows/pull-request.yml:
##########
@@ -16,22 +16,31 @@
name: pull request
on:
- pull_request:
+ pull_request_target:
types:
- - reopened
- - opened
- - edited
- - synchronize
+ - reopened
+ - opened
+ - edited
+ - synchronize
+ - pull_request_target
jobs:
title:
runs-on: ubuntu-latest
steps:
- - name: Checkout project
- uses: actions/checkout@v4
- - name: Check pull request title
- env:
- TITLE: ${{ github.event.pull_request.title }}
- run:
- .github/scripts/pr_title_check.sh "${TITLE}"
-
+ - name: Checkout project
+ uses: actions/checkout@v4
+ - name: Check pull request title
+ env:
+ TITLE: ${{ github.event.pull_request.title }}
+ run:
+ .github/scripts/pr_title_check.sh "${TITLE}"
Review Comment:
Ah makes sense. Let's keep the scope of this workflow restricted since it requires greater permissions. I'll close this as won't fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org