You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2020/10/10 05:27:41 UTC
[GitHub] [iceberg] kbendick opened a new pull request #1576: Add in a `METASTORE` tag and place /hive-metastore underneath it
kbendick opened a new pull request #1576:
URL: https://github.com/apache/iceberg/pull/1576
We currently use top level names to the use our labels, with a few exceptions for build and infra related purposes.
The relatively recently added `hive-metastore` module could arguably be labeled as `HIVE` given that it is the hive metastore, but I feel that metastore related changes might be of interest to a wider audience.
Admittedly, the audience that would be most interested in those changes would be more interested in a `CATALOG` tag, but given the current way the autolabeler is set up, we don't support that.
I'm opening this PR to add everything underneath `/hive-metastore` to a label `METASTORE`, though I'm open to changing it. I'm also opening another PR to add in the other recently added hive modules to the hive tag.
This closes this issue: https://github.com/apache/iceberg/issues/1575
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] kbendick commented on pull request #1576: Add in a `METASTORE` tag and place /hive-metastore underneath it
Posted by GitBox <gi...@apache.org>.
kbendick commented on pull request #1576:
URL: https://github.com/apache/iceberg/pull/1576#issuecomment-706492965
I've somewhat changed my mind and am also tagging this one underneath `hive`. The labels need to indicate changes to code that are important to the different stakeholders. It would likely be a mistake to not still tag this as `HIVE`. https://github.com/apache/iceberg/pull/1577
It can still be tagged as `METASTORE` as well. After these are merged in, I'd like to consider some syntax cleanup over the whole file and then possibly add in tags for `CATALOG` and possibly `INPUTFORMAT`, which I also think are relevant.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on pull request #1576: Create a new METASTORE PR label and add it to changes made underneath /hive-metastore
Posted by GitBox <gi...@apache.org>.
rdblue commented on pull request #1576:
URL: https://github.com/apache/iceberg/pull/1576#issuecomment-707248445
I think I like the idea to add a CATALOG tag and apply it to all of our catalog implementation modules. Since one for Nessie has been added, that probably makes more sense than a METASTORE tag that applies mainly to Hive.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org