You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/05/20 02:14:07 UTC
[GitHub] [shardingsphere] lanchengx opened a new pull request, #17820: Rename schema to database
lanchengx opened a new pull request, #17820:
URL: https://github.com/apache/shardingsphere/pull/17820
Changes proposed in this pull request:
- Rename schema to database
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang commented on a diff in pull request #17820: Rename schema to database
Posted by GitBox <gi...@apache.org>.
RaigorJiang commented on code in PR #17820:
URL: https://github.com/apache/shardingsphere/pull/17820#discussion_r877835599
##########
shardingsphere-test/shardingsphere-parser-test/src/main/java/org/apache/shardingsphere/test/sql/parser/parameterized/asserts/statement/distsql/rql/impl/rule/ShowShadowTableRulesStatementAssert.java:
##########
@@ -42,10 +42,10 @@ public final class ShowShadowTableRulesStatementAssert {
*/
public static void assertIs(final SQLCaseAssertContext assertContext, final ShowShadowTableRulesStatement actual, final ShowShadowTableRulesStatementTestCase expected) {
if (null != expected.getSchema()) {
- assertTrue(assertContext.getText("Actual schema should exist."), actual.getSchema().isPresent());
- SchemaAssert.assertIs(assertContext, actual.getSchema().get(), expected.getSchema());
+ assertTrue(assertContext.getText("Actual schema should exist."), actual.getDatabase().isPresent());
+ DatabaseAssert.assertIs(assertContext, actual.getDatabase().get(), expected.getSchema());
Review Comment:
expected.getDatabase())
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang commented on a diff in pull request #17820: Rename schema to database
Posted by GitBox <gi...@apache.org>.
RaigorJiang commented on code in PR #17820:
URL: https://github.com/apache/shardingsphere/pull/17820#discussion_r877836696
##########
shardingsphere-test/shardingsphere-parser-test/src/main/java/org/apache/shardingsphere/test/sql/parser/parameterized/asserts/statement/distsql/rql/impl/rule/ShowUnusedShardingKeyGeneratorsStatementAssert.java:
##########
@@ -21,6 +21,7 @@
import lombok.NoArgsConstructor;
import org.apache.shardingsphere.sharding.distsql.parser.statement.ShowUnusedShardingKeyGeneratorsStatement;
import org.apache.shardingsphere.test.sql.parser.parameterized.asserts.SQLCaseAssertContext;
+import org.apache.shardingsphere.test.sql.parser.parameterized.asserts.segment.schema.DatabaseAssert;
Review Comment:
segment.schema.DatabaseAssert - > segment.database.DatabaseAssert;
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang commented on a diff in pull request #17820: Rename schema to database
Posted by GitBox <gi...@apache.org>.
RaigorJiang commented on code in PR #17820:
URL: https://github.com/apache/shardingsphere/pull/17820#discussion_r877835837
##########
shardingsphere-test/shardingsphere-parser-test/src/main/java/org/apache/shardingsphere/test/sql/parser/parameterized/asserts/statement/distsql/rql/impl/rule/ShowShadowTableRulesStatementAssert.java:
##########
@@ -42,10 +42,10 @@ public final class ShowShadowTableRulesStatementAssert {
*/
public static void assertIs(final SQLCaseAssertContext assertContext, final ShowShadowTableRulesStatement actual, final ShowShadowTableRulesStatementTestCase expected) {
if (null != expected.getSchema()) {
- assertTrue(assertContext.getText("Actual schema should exist."), actual.getSchema().isPresent());
- SchemaAssert.assertIs(assertContext, actual.getSchema().get(), expected.getSchema());
+ assertTrue(assertContext.getText("Actual schema should exist."), actual.getDatabase().isPresent());
+ DatabaseAssert.assertIs(assertContext, actual.getDatabase().get(), expected.getSchema());
} else {
- assertFalse(assertContext.getText("Actual schema should not exist."), actual.getSchema().isPresent());
+ assertFalse(assertContext.getText("Actual schema should not exist."), actual.getDatabase().isPresent());
Review Comment:
Actual database
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang commented on a diff in pull request #17820: Rename schema to database
Posted by GitBox <gi...@apache.org>.
RaigorJiang commented on code in PR #17820:
URL: https://github.com/apache/shardingsphere/pull/17820#discussion_r877836115
##########
shardingsphere-test/shardingsphere-parser-test/src/main/java/org/apache/shardingsphere/test/sql/parser/parameterized/asserts/statement/distsql/rql/impl/rule/ShowShardingAlgorithmsStatementAssert.java:
##########
@@ -42,10 +42,10 @@ public final class ShowShardingAlgorithmsStatementAssert {
*/
public static void assertIs(final SQLCaseAssertContext assertContext, final ShowShardingAlgorithmsStatement actual, final ShowShardingAlgorithmsStatementTestCase expected) {
if (null != expected.getSchema()) {
- assertTrue(assertContext.getText("Actual schema should exist."), actual.getSchema().isPresent());
- SchemaAssert.assertIs(assertContext, actual.getSchema().get(), expected.getSchema());
+ assertTrue(assertContext.getText("Actual schema should exist."), actual.getDatabase().isPresent());
+ DatabaseAssert.assertIs(assertContext, actual.getDatabase().get(), expected.getSchema());
} else {
- assertFalse(assertContext.getText("Actual schema should not exist."), actual.getSchema().isPresent());
+ assertFalse(assertContext.getText("Actual schema should not exist."), actual.getDatabase().isPresent());
Review Comment:
Actual database
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang commented on a diff in pull request #17820: Rename schema to database
Posted by GitBox <gi...@apache.org>.
RaigorJiang commented on code in PR #17820:
URL: https://github.com/apache/shardingsphere/pull/17820#discussion_r877835275
##########
shardingsphere-test/shardingsphere-parser-test/src/main/java/org/apache/shardingsphere/test/sql/parser/parameterized/asserts/statement/distsql/rql/impl/rule/ShowShadowAlgorithmsStatementAssert.java:
##########
@@ -42,10 +42,10 @@ public final class ShowShadowAlgorithmsStatementAssert {
*/
public static void assertIs(final SQLCaseAssertContext assertContext, final ShowShadowAlgorithmsStatement actual, final ShowShadowAlgorithmsStatementTestCase expected) {
if (null != expected.getSchema()) {
- assertTrue(assertContext.getText("Actual schema should exist."), actual.getSchema().isPresent());
- SchemaAssert.assertIs(assertContext, actual.getSchema().get(), expected.getSchema());
+ assertTrue(assertContext.getText("Actual schema should exist."), actual.getDatabase().isPresent());
+ DatabaseAssert.assertIs(assertContext, actual.getDatabase().get(), expected.getSchema());
Review Comment:
expected.getDatabase()
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #17820: Rename schema to database
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #17820:
URL: https://github.com/apache/shardingsphere/pull/17820#issuecomment-1132401588
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/17820?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17820](https://codecov.io/gh/apache/shardingsphere/pull/17820?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6ff89ff) into [master](https://codecov.io/gh/apache/shardingsphere/commit/50ad6cf68ce1b11c01644c6d0f86d036bf9a60ae?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (50ad6cf) will **increase** coverage by `0.00%`.
> The diff coverage is `42.18%`.
```diff
@@ Coverage Diff @@
## master #17820 +/- ##
=========================================
Coverage 59.12% 59.13%
Complexity 2134 2134
=========================================
Files 3599 3599
Lines 53464 53464
Branches 9118 9118
=========================================
+ Hits 31611 31614 +3
+ Misses 19173 19170 -3
Partials 2680 2680
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/17820?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ser/core/common/CommonDistSQLStatementVisitor.java](https://codecov.io/gh/apache/shardingsphere/pull/17820/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZGlzdHNxbC9zaGFyZGluZ3NwaGVyZS1kaXN0c3FsLXBhcnNlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGlzdHNxbC9wYXJzZXIvY29yZS9jb21tb24vQ29tbW9uRGlzdFNRTFN0YXRlbWVudFZpc2l0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...ueryable/ExportDatabaseConfigurationStatement.java](https://codecov.io/gh/apache/shardingsphere/pull/17820/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZGlzdHNxbC9zaGFyZGluZ3NwaGVyZS1kaXN0c3FsLXN0YXRlbWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGlzdHNxbC9wYXJzZXIvc3RhdGVtZW50L3JhbC9jb21tb24vcXVlcnlhYmxlL0V4cG9ydERhdGFiYXNlQ29uZmlndXJhdGlvblN0YXRlbWVudC5qYXZh) | `0.00% <ø> (ø)` | |
| [...l/common/queryable/ShowTableMetadataStatement.java](https://codecov.io/gh/apache/shardingsphere/pull/17820/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZGlzdHNxbC9zaGFyZGluZ3NwaGVyZS1kaXN0c3FsLXN0YXRlbWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGlzdHNxbC9wYXJzZXIvc3RhdGVtZW50L3JhbC9jb21tb24vcXVlcnlhYmxlL1Nob3dUYWJsZU1ldGFkYXRhU3RhdGVtZW50LmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...tatement/rql/show/CountDatabaseRulesStatement.java](https://codecov.io/gh/apache/shardingsphere/pull/17820/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZGlzdHNxbC9zaGFyZGluZ3NwaGVyZS1kaXN0c3FsLXN0YXRlbWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGlzdHNxbC9wYXJzZXIvc3RhdGVtZW50L3JxbC9zaG93L0NvdW50RGF0YWJhc2VSdWxlc1N0YXRlbWVudC5qYXZh) | `0.00% <ø> (ø)` | |
| [...ser/statement/rql/show/ShowResourcesStatement.java](https://codecov.io/gh/apache/shardingsphere/pull/17820/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZGlzdHNxbC9zaGFyZGluZ3NwaGVyZS1kaXN0c3FsLXN0YXRlbWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGlzdHNxbC9wYXJzZXIvc3RhdGVtZW50L3JxbC9zaG93L1Nob3dSZXNvdXJjZXNTdGF0ZW1lbnQuamF2YQ==) | `0.00% <ø> (ø)` | |
| [.../parser/statement/rql/show/ShowRulesStatement.java](https://codecov.io/gh/apache/shardingsphere/pull/17820/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZGlzdHNxbC9zaGFyZGluZ3NwaGVyZS1kaXN0c3FsLXN0YXRlbWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGlzdHNxbC9wYXJzZXIvc3RhdGVtZW50L3JxbC9zaG93L1Nob3dSdWxlc1N0YXRlbWVudC5qYXZh) | `0.00% <ø> (ø)` | |
| [...ement/rql/show/ShowRulesUsedResourceStatement.java](https://codecov.io/gh/apache/shardingsphere/pull/17820/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZGlzdHNxbC9zaGFyZGluZ3NwaGVyZS1kaXN0c3FsLXN0YXRlbWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGlzdHNxbC9wYXJzZXIvc3RhdGVtZW50L3JxbC9zaG93L1Nob3dSdWxlc1VzZWRSZXNvdXJjZVN0YXRlbWVudC5qYXZh) | `0.00% <ø> (ø)` | |
| [...atement/rql/show/ShowUnusedResourcesStatement.java](https://codecov.io/gh/apache/shardingsphere/pull/17820/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZGlzdHNxbC9zaGFyZGluZ3NwaGVyZS1kaXN0c3FsLXN0YXRlbWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGlzdHNxbC9wYXJzZXIvc3RhdGVtZW50L3JxbC9zaG93L1Nob3dVbnVzZWRSZXNvdXJjZXNTdGF0ZW1lbnQuamF2YQ==) | `0.00% <ø> (ø)` | |
| [...core/DatabaseDiscoveryDistSQLStatementVisitor.java](https://codecov.io/gh/apache/shardingsphere/pull/17820/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtZGItZGlzY292ZXJ5L3NoYXJkaW5nc3BoZXJlLWRiLWRpc2NvdmVyeS1kaXN0c3FsL3NoYXJkaW5nc3BoZXJlLWRiLWRpc2NvdmVyeS1kaXN0c3FsLXBhcnNlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGJkaXNjb3ZlcnkvZGlzdHNxbC9wYXJzZXIvY29yZS9EYXRhYmFzZURpc2NvdmVyeURpc3RTUUxTdGF0ZW1lbnRWaXNpdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...ql/parser/core/EncryptDistSQLStatementVisitor.java](https://codecov.io/gh/apache/shardingsphere/pull/17820/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtZW5jcnlwdC9zaGFyZGluZ3NwaGVyZS1lbmNyeXB0LWRpc3RzcWwvc2hhcmRpbmdzcGhlcmUtZW5jcnlwdC1kaXN0c3FsLXBhcnNlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZW5jcnlwdC9kaXN0c3FsL3BhcnNlci9jb3JlL0VuY3J5cHREaXN0U1FMU3RhdGVtZW50VmlzaXRvci5qYXZh) | `0.00% <0.00%> (ø)` | |
| ... and [55 more](https://codecov.io/gh/apache/shardingsphere/pull/17820/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/17820?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/17820?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [50ad6cf...6ff89ff](https://codecov.io/gh/apache/shardingsphere/pull/17820?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang commented on a diff in pull request #17820: Rename schema to database
Posted by GitBox <gi...@apache.org>.
RaigorJiang commented on code in PR #17820:
URL: https://github.com/apache/shardingsphere/pull/17820#discussion_r878804722
##########
shardingsphere-test/shardingsphere-parser-test/src/main/java/org/apache/shardingsphere/test/sql/parser/parameterized/asserts/statement/distsql/rql/impl/rule/CountDatabaseRulesStatementAssert.java:
##########
@@ -31,21 +31,21 @@
* Count schema rules statement assert.
Review Comment:
Missed comment.
##########
shardingsphere-test/shardingsphere-parser-test/src/main/java/org/apache/shardingsphere/test/sql/parser/parameterized/asserts/statement/distsql/rql/impl/rule/CountDatabaseRulesStatementAssert.java:
##########
@@ -31,21 +31,21 @@
* Count schema rules statement assert.
Review Comment:
Missed comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] TeslaCN commented on a diff in pull request #17820: Rename schema to database
Posted by GitBox <gi...@apache.org>.
TeslaCN commented on code in PR #17820:
URL: https://github.com/apache/shardingsphere/pull/17820#discussion_r877979543
##########
shardingsphere-distsql/shardingsphere-distsql-statement/src/main/java/org/apache/shardingsphere/distsql/parser/statement/rql/show/CountDatabaseRulesStatement.java:
##########
@@ -19,15 +19,15 @@
import lombok.Getter;
import org.apache.shardingsphere.distsql.parser.subject.DistSQLSubjectTypeEnum;
-import org.apache.shardingsphere.sql.parser.sql.common.segment.generic.SchemaSegment;
+import org.apache.shardingsphere.sql.parser.sql.common.segment.generic.DatabaseSegment;
/**
* Count schema rules statement.
Review Comment:
Missed here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang commented on a diff in pull request #17820: Rename schema to database
Posted by GitBox <gi...@apache.org>.
RaigorJiang commented on code in PR #17820:
URL: https://github.com/apache/shardingsphere/pull/17820#discussion_r877834271
##########
shardingsphere-test/shardingsphere-parser-test/src/main/java/org/apache/shardingsphere/test/sql/parser/parameterized/asserts/statement/distsql/rql/impl/ShowRulesStatementAssert.java:
##########
@@ -136,8 +136,8 @@ public static void assertIs(final SQLCaseAssertContext assertContext, final Show
ShowUnusedShardingAlgorithmsStatementAssert.assertIs(assertContext, (ShowUnusedShardingAlgorithmsStatement) actual, (ShowUnusedShardingAlgorithmsStatementTestCase) expected);
} else if (actual instanceof ShowUnusedShardingKeyGeneratorsStatement) {
ShowUnusedShardingKeyGeneratorsStatementAssert.assertIs(assertContext, (ShowUnusedShardingKeyGeneratorsStatement) actual, (ShowUnusedShardingKeyGeneratorsStatementTestCase) expected);
- } else if (actual instanceof CountSchemaRulesStatement) {
- CountSchemaRulesStatementAssert.assertIs(assertContext, (CountSchemaRulesStatement) actual, (CountSchemaRulesStatementTestCase) expected);
+ } else if (actual instanceof CountDatabaseRulesStatement) {
+ CountSchemaRulesStatementAssert.assertIs(assertContext, (CountDatabaseRulesStatement) actual, (CountSchemaRulesStatementTestCase) expected);
Review Comment:
CountDatabaseRulesStatementAssert
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang merged pull request #17820: Rename schema to database
Posted by GitBox <gi...@apache.org>.
RaigorJiang merged PR #17820:
URL: https://github.com/apache/shardingsphere/pull/17820
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org