[GitHub] [flink] LadyForest commented on a diff in pull request #21683: [FLINK-30672][table] Support 'EXPLAIN PLAN_ADVICE' statement

[GitBox <gi...@apache.org>]

LadyForest commented on code in PR #21683:
URL: https://github.com/apache/flink/pull/21683#discussion_r1073598187


##########
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/utils/FlinkRelOptUtil.scala:
##########
@@ -90,6 +90,38 @@ object FlinkRelOptUtil {
     sw.toString
   }
 
+  def toPlanAdvice(

Review Comment:
   Thanks for the suggestion. 
   Since Scala does not allow overloaded methods with default arguments, and `detailLevel` and `withChangelogTraits` are always specified explicitly, what about
   ```scala
     def toString(
         relNodes: Seq[RelNode],
         detailLevel: SqlExplainLevel,
         withChangelogTraits: Boolean): String = {
   }
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org