[GitHub] [daffodil-vscode] Shanedell commented on a diff in pull request #626: Keep terminal open after debug ends

["Shanedell (via GitHub)" <gi...@apache.org>]

Shanedell commented on code in PR #626:
URL: https://github.com/apache/daffodil-vscode/pull/626#discussion_r1187617385


##########
src/utils.ts:
##########
@@ -26,6 +26,18 @@ import { TDMLConfig } from './adapter/activateDaffodilDebug'
 const defaultConf = vscode.workspace.getConfiguration()
 let currentConfig: vscode.DebugConfiguration
 
+// if active termainl is one of these, use the active terminal instead of making a new one
+const allowedShells = [

Review Comment:
   We possibly could support allow them. Should I just make in `bash` and `cmd`? `cmd` is used for windows and then `bash` is linux/mac



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org