You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@nifi.apache.org by mosermw <gi...@git.apache.org> on 2017/04/21 19:06:04 UTC

[GitHub] nifi pull request #1688: NIFI-3553 FetchFileTransfer fix

GitHub user mosermw opened a pull request:

    https://github.com/apache/nifi/pull/1688

    NIFI-3553 FetchFileTransfer fix

    This is a port from master to the 0.x branch.  Reviewer can squash to remove my commit for Java 7 compatibility.
    
    Thank you for submitting a contribution to Apache NiFi.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [ ] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [ ] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
    - [ ] Have you written or updated unit tests to verify your changes?
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
    - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
    - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mosermw/nifi nifi-3553

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/1688.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1688
    
----
commit fa012fed04a8149edf775514a9a3dc395a3f619a
Author: Mark Payne <ma...@hotmail.com>
Date:   2017-03-03T18:18:41Z

    NIFI-3553: If IOException is thrown when completing FTP transfer, do not update the FlowFile to point to the content that was streamed but instead leave FlowFile pointing to original version

commit 7b4287eda1ed46e70c10d1835fdb9bb66af8b7b6
Author: Mike Moser <mo...@apache.org>
Date:   2017-04-21T19:00:53Z

    NIFI-3553 added final keyword for java 7 compatibility

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request #1688: NIFI-3553 FetchFileTransfer fix

Posted by mosermw <gi...@git.apache.org>.

Github user mosermw closed the pull request at:

    https://github.com/apache/nifi/pull/1688


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #1688: NIFI-3553 FetchFileTransfer fix

Posted by jskora <gi...@git.apache.org>.

Github user jskora commented on the issue:

    https://github.com/apache/nifi/pull/1688
  
    Reviewing


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #1688: NIFI-3553 FetchFileTransfer fix

Posted by jskora <gi...@git.apache.org>.

Github user jskora commented on the issue:

    https://github.com/apache/nifi/pull/1688
  
    Committed on https://github.com/apache/nifi/commit/b69b3b6c622d27544df70e157f8d8b1531a881c6 and https://github.com/apache/nifi/commit/c1e65f95bd9951390215c8ef7e2b25cf95f8b5f1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---