[GitHub] [beam] ihji commented on a change in pull request #14671: [BEAM-12244] Use GRPC insecure_channel in expansion service

[GitBox <gi...@apache.org>]

ihji commented on a change in pull request #14671:
URL: https://github.com/apache/beam/pull/14671#discussion_r652316078



##########
File path: sdks/python/apache_beam/transforms/external.py
##########
@@ -319,25 +319,9 @@ def _service(self):
     if isinstance(self._expansion_service, str):
       channel_options = [("grpc.max_receive_message_length", -1),
                          ("grpc.max_send_message_length", -1)]
-      if hasattr(grpc, 'local_channel_credentials'):
-        # Some environments may not support insecure channels. Hence use a
-        # secure channel with local credentials here.

Review comment:
       @mxm I think the issue here is not whether the channel is secure or insecure. The point is `local_channel_credentials` only allows local connections so we can't use the expansion service running on a remote server. This PR makes sense to me.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org