You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by Gary Gregory <ga...@gmail.com> on 2021/06/12 12:44:30 UTC
[Compress] Java 16 and 17-ea
Please note that the Java 16 and 17 builds are now green on GitHub after my
changes this morning to update some dependencies. Let's try to keep it
green which will make looking at PRs that much better.
Gary
Re: [Compress] Java 16 and 17-ea
Posted by Stefan Bodewig <bo...@apache.org>.
On 2021-07-03, Gary Gregory wrote:
> This is the approach I've taken: I merged the pack200 branch into
> master as is.
Thank you
Stefan
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [Compress] Java 16 and 17-ea
Posted by Gary Gregory <ga...@gmail.com>.
On Fri, Jul 2, 2021 at 11:19 AM Stefan Bodewig <bo...@apache.org> wrote:
>
> On 2021-06-12, Gary Gregory wrote:
>
> > Please have a look at the pack200 branch if you want, there are still
> > Javadoc TODOs but it's all there.
>
> Just so we get this into this list's archive properly: I've propsed a
> few changes in https://github.com/apache/commons-compress/pull/210 but
> completely leave it up to you whether you want to apply them or just
> merge your branch as it is.
Thank you for the PR. This is the approach I've taken: I merged the
pack200 branch into master as is. That builds green. This allows us to
exercise the pack200 code now and on all builds. I think this will be
better in the long term because will find out sooner when the code
needs adjusting as opposed to when someone only runs on a Java version
that does not contain pack200; fail fast and all that. If others feel
strongly otherwise, then we can revisit PR 210 and make it build
green.
TY!
Gary
>
> Thanks
>
> Stefan
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [Compress] Java 16 and 17-ea
Posted by Stefan Bodewig <bo...@apache.org>.
On 2021-06-12, Gary Gregory wrote:
> Please have a look at the pack200 branch if you want, there are still
> Javadoc TODOs but it's all there.
Just so we get this into this list's archive properly: I've propsed a
few changes in https://github.com/apache/commons-compress/pull/210 but
completely leave it up to you whether you want to apply them or just
merge your branch as it is.
Thanks
Stefan
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [Compress] Java 16 and 17-ea
Posted by Gary Gregory <ga...@gmail.com>.
Please have a look at the pack200 branch if you want, there are still
Javadoc TODOs but it's all there.
Gary
On Sat, Jun 12, 2021, 14:50 Stefan Bodewig <bo...@apache.org> wrote:
> On 2021-06-12, Stefan Bodewig wrote:
>
> > On 2021-06-12, Gary Gregory wrote:
>
> >> Please note that the Java 16 and 17 builds are now green on GitHub
> after my
> >> changes this morning to update some dependencies.
>
> > They haven't been green before - or for any JDK > 14 - because of
> > missing pack200 classes inside of the classlib.
>
> Sorry, obviously I missed Peter's change
>
>
> https://github.com/apache/commons-compress/commit/92d9df3320d00dee0edef8290ef325bc83b9255a
>
> and somehow never looked at the broken builds as I assumed it must have
> been the pack200 thing.
>
> Stefan
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>
Re: [Compress] Java 16 and 17-ea
Posted by Stefan Bodewig <bo...@apache.org>.
On 2021-06-12, Stefan Bodewig wrote:
> On 2021-06-12, Gary Gregory wrote:
>> Please note that the Java 16 and 17 builds are now green on GitHub after my
>> changes this morning to update some dependencies.
> They haven't been green before - or for any JDK > 14 - because of
> missing pack200 classes inside of the classlib.
Sorry, obviously I missed Peter's change
https://github.com/apache/commons-compress/commit/92d9df3320d00dee0edef8290ef325bc83b9255a
and somehow never looked at the broken builds as I assumed it must have
been the pack200 thing.
Stefan
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [Compress] Java 16 and 17-ea
Posted by Stefan Bodewig <bo...@apache.org>.
On 2021-06-12, Gary Gregory wrote:
> Please note that the Java 16 and 17 builds are now green on GitHub after my
> changes this morning to update some dependencies.
They haven't been green before - or for any JDK > 14 - because of
missing pack200 classes inside of the classlib.
Stefan
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org