You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Jeff Trawick <tr...@bellsouth.net> on 2000/06/01 16:51:18 UTC

Re: PATCH: Change Accept Serialization Mechanism for OS/390 USS

> Date: Tue, 30 May 2000 16:13:02 -0700
> From: Ovies Brabson <ov...@us.ibm.com>
...
> This patch changes the serialization mechanism used on the OS/390
> platform from FCNTL to SYS V Semaphores.  We did some performance runs
> and the System V semaphore serialization seemed to perform better than
> FCNTL
> ? apache-1.3/cgi-src
> ? apache-1.3/htdocs/manual/info
> ? apache-1.3/src/os/emx
> Index: apache-1.3/src/include/ap_config.h
> ===================================================================
> RCS file: /home/cvs/apache-1.3/src/include/ap_config.h,v
> retrieving revision 1.286
> diff -u -r1.286 ap_config.h
> --- apache-1.3/src/include/ap_config.h	2000/04/01 05:02:06	1.286
> +++ apache-1.3/src/include/ap_config.h	2000/05/30 17:04:30
> @@ -954,7 +954,8 @@
>  #define HAVE_SHMGET
>  #define USE_SHMGET_SCOREBOARD
>  #define USE_MMAP_FILES
> -#define USE_FCNTL_SERIALIZED_ACCEPT
> +#define NEED_UNION_SEMUN
> +#define USE_SYSVSEM_SERIALIZED_ACCEPT
>  #define _POSIX_SOURCE
>  #include <signal.h>
>  #ifdef SIGDUMP  /* SIGDUMP is not defined by OS/390 v1r2 */
 -=- MIME -=- 
This is a multi-part message in MIME format.
--------------ED12D53C5D85236F72913E2E
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit

This patch changes the serialization mechanism used on the OS/390
platform from FCNTL to SYS V Semaphores.  We did some performance runs
and the System V semaphore serialization seemed to perform better than
FCNTL

--------------ED12D53C5D85236F72913E2E
Content-Type: text/plain; charset=us-ascii;
 name="os390SysVSerAccpt.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
 filename="os390SysVSerAccpt.diff"

? apache-1.3/cgi-src
? apache-1.3/htdocs/manual/info
? apache-1.3/src/os/emx
Index: apache-1.3/src/include/ap_config.h
===================================================================
RCS file: /home/cvs/apache-1.3/src/include/ap_config.h,v
retrieving revision 1.286
diff -u -r1.286 ap_config.h
--- apache-1.3/src/include/ap_config.h	2000/04/01 05:02:06	1.286
+++ apache-1.3/src/include/ap_config.h	2000/05/30 17:04:30
@@ -954,7 +954,8 @@
 #define HAVE_SHMGET
 #define USE_SHMGET_SCOREBOARD
 #define USE_MMAP_FILES
-#define USE_FCNTL_SERIALIZED_ACCEPT
+#define NEED_UNION_SEMUN
+#define USE_SYSVSEM_SERIALIZED_ACCEPT
 #define _POSIX_SOURCE
 #include <signal.h>
 #ifdef SIGDUMP  /* SIGDUMP is not defined by OS/390 v1r2 */

--------------ED12D53C5D85236F72913E2E--



I don't know how other folks feel about most of Ovies' patches.  This one is
surely low risk and shouldn't hurt anybody.

Is there any consensus on what has to be done before I can commit
this?

a) nothing; it isn't "operational" code
b) need three +1s (probably will never happen; nobody that has used
   OS/390 within the last 10 years even has a vote, and most folks are
   understandably reluctant to stick their nose where they know not)
c) wait until certain people are on vacation
d) forget about it; we had problems with a buggy SysV sem
   implementation on Solaris so you shouldn't use them on OS/390
   (humor) 

-- 
Jeff Trawick | trawick@ibm.net | PGP public key at web site:
     http://www.geocities.com/SiliconValley/Park/9289/
          Born in Roswell... married an alien...