[jira] [Commented] (HIVE-29413) Generalise column related APIs in Table.java

["Denys Kuzmenko (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HIVE-29413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18095041#comment-18095041 ] 

Denys Kuzmenko commented on HIVE-29413:
---------------------------------------

Merged to master

Thank you for the big refactor [~ramitg254] and thorough review [~kkasa] !!

> Generalise column related APIs in Table.java
> --------------------------------------------
>
>                 Key: HIVE-29413
>                 URL: https://issues.apache.org/jira/browse/HIVE-29413
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Ramit Gupta
>            Assignee: Ramit Gupta
>            Priority: Major
>              Labels: pull-request-available
>
> there are several occurrences of below code block:
> {code:java}
> partitionColumns = table.hasNonNativePartitionSupport() ?
> table.getStorageHandler().getPartitionKeys(table) :
> table.getPartCols();{code}
> in [https://github.com/apache/hive/pull/6259] which need to be implemented inside getPartCols() method of ql/src/java/org/apache/hadoop/hive/ql/metadata/Table.java but avoided at that time due to some issues caused by this change
> so this needs to be implemented and handle any issues related to it
> and similar to that APIs like getCols() and getAllCols() should also be generalised similar to getPartCols()



--
This message was sent by Atlassian Jira
(v8.20.10#820010)