You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2012/10/13 00:54:16 UTC
Review Request: Refactoring http::get to take path and query as separate
arguments.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7574/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman and Vinod Kone.
Summary (updated)
-----------------
Refactoring http::get to take path and query as separate arguments.
Description (updated)
-------
See above.
Diffs (updated)
-----
src/tests/files_tests.cpp 764d2c7fdec4a21b9698eb4cb9e0673bd7f20e9d
src/tests/logging_tests.cpp bf839f2aece5f1661446bfa7f1ddd6d1ab6e1104
third_party/libprocess/include/process/http.hpp 3d2922507bdb904e5bdebefbafb6ccae98c021c4
third_party/libprocess/src/process.cpp e887feb1070cdd03a6d81b8f798145ed8bda7b5c
Diff: https://reviews.apache.org/r/7574/diff/
Testing (updated)
-------
make check
Thanks,
Ben Mahler
Re: Review Request: Refactoring http::get to take path and query as separate
arguments.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7574/#review12442
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Hindman
On Oct. 12, 2012, 10:54 p.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7574/
> -----------------------------------------------------------
>
> (Updated Oct. 12, 2012, 10:54 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Description
> -------
>
> See above.
>
>
> Diffs
> -----
>
> src/tests/files_tests.cpp 764d2c7fdec4a21b9698eb4cb9e0673bd7f20e9d
> src/tests/logging_tests.cpp bf839f2aece5f1661446bfa7f1ddd6d1ab6e1104
> third_party/libprocess/include/process/http.hpp 3d2922507bdb904e5bdebefbafb6ccae98c021c4
> third_party/libprocess/src/process.cpp e887feb1070cdd03a6d81b8f798145ed8bda7b5c
>
> Diff: https://reviews.apache.org/r/7574/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Ben Mahler
>
>